Conditions | 1 |
Paths | 1 |
Total Lines | 57 |
Code Lines | 41 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
46 | public function shouldGenerateCorrectXML() |
||
47 | { |
||
48 | //given |
||
49 | $tokenizer = new Tokenizer(); |
||
50 | $parameters1 = [Parameter::fromTokens($tokenizer->lex('string $userName'))]; |
||
51 | $return1 = Parameter::fromTokens($tokenizer->lex('string $uppercasedUserName')); |
||
52 | |||
53 | $parameters2 = [ |
||
54 | Parameter::fromTokens($tokenizer->lex('int[] $numbers')), |
||
55 | Parameter::fromTokens($tokenizer->lex('string $prefix')) |
||
56 | ]; |
||
57 | $return2 = Parameter::fromTokens($tokenizer->lex('string[] $numbersWithPrefix')); |
||
58 | |||
59 | $parameters3 = [Parameter::fromTokens($tokenizer->lex('object $user { string $name int $age }'))]; |
||
60 | $return3 = Parameter::fromTokens($tokenizer->lex('object $userContext { int $id object $userInfo { string $name int $age } }')); |
||
61 | |||
62 | $parameters4 = [Parameter::fromTokens($tokenizer->lex('object[] $companies { string $name int $postcode }'))]; |
||
63 | $return4 = Parameter::fromTokens($tokenizer->lex('string[] $companiesNames')); |
||
64 | |||
65 | $parameters5 = [Parameter::fromTokens($tokenizer->lex('string[] $errors'))]; |
||
66 | $return5 = Parameter::fromTokens($tokenizer->lex('object $result { boolean $result string[] $errors }')); |
||
67 | |||
68 | $parameters6 = [ |
||
69 | Parameter::fromTokens($tokenizer->lex('object $serviceAuth { string $token int $id }'), true), |
||
70 | Parameter::fromTokens($tokenizer->lex('string $name')), |
||
71 | Parameter::fromTokens($tokenizer->lex('string $surname')) |
||
72 | ]; |
||
73 | $return6 = Parameter::fromTokens($tokenizer->lex('string $nameWithSurname')); |
||
74 | |||
75 | $parameters7 = [Parameter::fromTokens($tokenizer->lex('string $userToken'))]; |
||
76 | |||
77 | $return8 = Parameter::fromTokens($tokenizer->lex('string $responseForMethodWithoutParameters')); |
||
78 | $builder = WSDLBuilder::instance() |
||
79 | ->setName('RpcLiteralService') |
||
80 | ->setTargetNamespace('http://foo.bar/rpcliteralservice') |
||
81 | ->setNs('http://foo.bar/rpcliteralservice/types') |
||
82 | ->setLocation('http://localhost:7777/wsdl-creator/examples/rpc_literal/service.php') |
||
83 | ->setStyle(SoapBinding::RPC) |
||
84 | ->setUse(SoapBinding::LITERAL) |
||
85 | ->setSoapVersion(BindingType::SOAP_11) |
||
86 | ->setMethod(new Method('uppercaseUserName', $parameters1, $return1)) |
||
87 | ->setMethod(new Method('appendPrefixToNumbers', $parameters2, $return2)) |
||
88 | ->setMethod(new Method('getUserContext', $parameters3, $return3)) |
||
89 | ->setMethod(new Method('extractCompaniesNames', $parameters4, $return4)) |
||
90 | ->setMethod(new Method('wrapErrors', $parameters5, $return5)) |
||
91 | ->setMethod(new Method('authorizedMethod', $parameters6, $return6)) |
||
92 | ->setMethod(new Method('methodWithoutReturn', $parameters7, null)) |
||
93 | ->setMethod(new Method('methodWithoutParameters', [], $return8)); |
||
94 | $XMLProvider = new XMLProvider($builder); |
||
95 | $XMLProvider->generate(); |
||
96 | |||
97 | //when |
||
98 | $xml = $XMLProvider->getXml(); |
||
99 | |||
100 | //then |
||
101 | $this->assertXmlStringEqualsXmlFile(Path::join(__DIR__, 'xml_file_asserts', 'correct_xml.wsdl'), $xml); |
||
102 | } |
||
103 | } |
||
104 |