Pinepain\ObjectMaps\Tests\ObjectBiMapTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	249
Duplicated Lines	20.08 %

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	hp$0 ➔ __construct()	5	5	1
A	hp$1 ➔ __construct()	5	5	1
A	buildMap()	0	4	1
B	testValuesForRegularMap()	0	40	1
B	testValuesForWeakKeyMap()	0	45	1
B	testValuesForWeakValueMap()	0	42	1
A	testValuesForWeakKeyValueMap()	0	50	1
B	testKeyValuesOutOfSyncPutFails()	25	25	1
B	testKeyValuesOutOfSyncRemoveFails()	25	25	1

<?php declare(strict_types=1);

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 25 and the first side effect is on line 273.

/*
 * This file is part of the pinepain/php-object-maps PHP library.
 *
 * Copyright (c) 2016-2017 Bogdan Padalko <pinepain@gmail.com>
 *
 * Licensed under the MIT license: http://opensource.org/licenses/MIT
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code or visit http://opensource.org/licenses/MIT
 */


namespace Pinepain\ObjectMaps\Tests;


use Pinepain\ObjectMaps\ObjectBiMap;
use Pinepain\ObjectMaps\ObjectBiMapInterface;
use Pinepain\ObjectMaps\ObjectMap;
use Pinepain\ObjectMaps\ObjectMapInterface;
use stdClass;


class ObjectBiMapTest extends AbstractObjectMapInterfaceTest
{
    public function buildMap(int $behavior = ObjectMapInterface::DEFAULT)

Possible parse error: non-abstract method defined as abstract

It is generally advisable to only define one property per statement.

    {
        return new ObjectBiMap($behavior);
    }

    public function testValuesForRegularMap()
    {
        $map = $this->buildMap();

        $key   = new stdClass();
        $value = new stdClass();

        $map->put($key, $value);

        $this->assertTrue($map->has($key));
        $this->assertFalse($map->has($value));

        $vmap = $map->values();

        $this->assertInstanceOf(ObjectBiMapInterface::class, $vmap);

        $this->assertFalse($vmap->has($key));
        $this->assertTrue($vmap->has($value));

        $map->clear();

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());

        $vmap->put($key, $value);

        $this->assertSame(1, $vmap->count());
        $this->assertSame(1, $map->count());

        $this->assertFalse($map->has($key));
        $this->assertTrue($map->has($value));

        $key = null;

$key is not used, you could remove the assignment.

        $this->assertSame(1, $vmap->count());
        $this->assertSame(1, $map->count());

        $value = null;

$value is not used, you could remove the assignment.

        $this->assertSame(1, $vmap->count());
        $this->assertSame(1, $map->count());
    }

    public function testValuesForWeakKeyMap()
    {
        $map = $this->buildMap(ObjectBiMapInterface::WEAK_KEY);

        $key   = new stdClass();
        $value = new stdClass();

        $map->put($key, $value);

        $this->assertSame(1, $map->count());

        $vmap = $map->values();

        $this->assertInstanceOf(ObjectBiMapInterface::class, $vmap);

        $this->assertFalse($vmap->has($key));
        $this->assertTrue($vmap->has($value));

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value = null;

$value is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $key = null;

$key is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());

        $key   = new stdClass();
        $value = new stdClass();

        $vmap->put($key, $value);

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $key = null;

$key is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value = null;

$value is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());
    }

    public function testValuesForWeakValueMap()
    {
        $map = $this->buildMap(ObjectBiMapInterface::WEAK_VALUE);

        $key   = new stdClass();
        $value = new stdClass();

        $map->put($key, $value);

        $this->assertSame(1, $map->count());

        $vmap = $map->values();

        $this->assertInstanceOf(ObjectBiMapInterface::class, $vmap);

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $key = null;

$key is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value = null;

$value is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());

        $key   = new stdClass();
        $value = new stdClass();

        $vmap->put($key, $value);

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value = null;

$value is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $key = null;

$key is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());
    }


    public function testValuesForWeakKeyValueMap()
    {
        $map = $this->buildMap(ObjectBiMapInterface::WEAK_KEY_VALUE);

        $key_1   = new stdClass();
        $value_1 = new stdClass();

        $key_2   = new stdClass();
        $value_2 = new stdClass();

        $map->put($key_1, $value_1);
        $map->put($key_2, $value_2);

        $this->assertSame(2, $map->count());

        $vmap = $map->values();

        $this->assertInstanceOf(ObjectBiMapInterface::class, $vmap);

        $this->assertSame(2, $map->count());
        $this->assertSame(2, $vmap->count());

        $key_1 = null;

$key_1 is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value_2 = null;

$value_2 is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());

        $key_1   = new stdClass();
        $value_1 = new stdClass();

        $key_2   = new stdClass();
        $value_2 = new stdClass();

        $vmap->put($key_1, $value_1);
        $vmap->put($key_2, $value_2);

        $this->assertSame(2, $map->count());
        $this->assertSame(2, $vmap->count());

        $key_1 = null;

$key_1 is not used, you could remove the assignment.

        $this->assertSame(1, $map->count());
        $this->assertSame(1, $vmap->count());

        $value_2 = null;

$value_2 is not used, you could remove the assignment.

        $this->assertSame(0, $map->count());
        $this->assertSame(0, $vmap->count());
    }

    /**
     * @expectedException \Pinepain\ObjectMaps\Exceptions\OverflowException
     * @expectedExceptionMessage Key with such value already exists
     */
    public function testKeyValuesOutOfSyncPutFails()

This method seems to be duplicated in your project.

    {
        $key_1   = new stdClass();
        $value_1 = new stdClass();

        $key_2   = new stdClass();
        $value_2 = new stdClass();

        $keys_map   = new ObjectMap();
        $values_map = new ObjectMap();

        $keys_map->put($key_1, $value_1);
        $values_map->put($value_2, $key_2);

        $map = new class($keys_map, $values_map) extends ObjectBiMap
        {
            public function __construct(ObjectMapInterface $keys, ObjectMapInterface $values)
            {
                $this->keys   = $keys;

$keys is of type object<Pinepain\ObjectMaps\ObjectMapInterface>, but the property $keys was declared to be of type object<Pinepain\ObjectMaps\ObjectMap>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

                $this->values = $values;

$values is of type object<Pinepain\ObjectMaps\ObjectMapInterface>, but the property $values was declared to be of type object<Pinepain\ObjectMaps\ObjectMap>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

            }
        };

        $map->put($key_2, $value_2);
    }

    /**
     * @expectedException \Pinepain\ObjectMaps\Exceptions\OutOfBoundsException
     * @expectedExceptionMessage Key with such value not found
     */
    public function testKeyValuesOutOfSyncRemoveFails()

This method seems to be duplicated in your project.

    {
        $key_1   = new stdClass();
        $value_1 = new stdClass();

        $key_2   = new stdClass();
        $value_2 = new stdClass();

        $keys_map   = new ObjectMap();
        $values_map = new ObjectMap();

        $keys_map->put($key_1, $value_1);
        $values_map->put($value_2, $key_2);

        $map = new class($keys_map, $values_map) extends ObjectBiMap
        {
            public function __construct(ObjectMapInterface $keys, ObjectMapInterface $values)
            {
                $this->keys   = $keys;

$keys is of type object<Pinepain\ObjectMaps\ObjectMapInterface>, but the property $keys was declared to be of type object<Pinepain\ObjectMaps\ObjectMap>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

                $this->values = $values;

$values is of type object<Pinepain\ObjectMaps\ObjectMapInterface>, but the property $values was declared to be of type object<Pinepain\ObjectMaps\ObjectMap>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

            }
        };

        $map->remove($key_1);
    }
}