pinepain /
js-sandbox
| Conditions | 3 |
| Paths | 3 |
| Total Lines | 18 |
| Code Lines | 7 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 12 |
| Changes | 0 | ||
| 1 | <?php declare(strict_types=1); |
||
| 30 | public function handle(Isolate $isolate, Context $context, Throwable $throwable, ThrowSpecListInterface $throw_specs): bool |
||
| 31 | { |
||
| 32 | foreach ($throw_specs->getThrowSpecs() as $throw_spec) { |
||
| 33 | // TODO: what about if ($throw_spec->canHandle($throwable)) { ... }, anyway, there are already one function call - $throw_spec->getClass() |
||
|
|
|||
| 34 | |||
| 35 | $filter_class = $throw_spec->getClass(); |
||
| 36 | |||
| 37 | if (is_subclass_of($throwable, $filter_class)) { |
||
| 38 | //if ($throwable instanceof $filter_class) { |
||
| 39 | $throw_spec->getHandler()->handle($isolate, $context, $throwable); |
||
| 40 | |||
| 41 | // TODO: as handling mean to re-throw exception with maybe different desc, return statement here MAY be redundant |
||
| 42 | return true; |
||
| 43 | } |
||
| 44 | } |
||
| 45 | |||
| 46 | return false; |
||
| 47 | } |
||
| 48 | } |
||
| 49 |
Loading history...
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.