Pilipinews\Common\Client

Complexity

Total Complexity

6

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	request()	0	7	1
A	__construct()	0	11	1
A	url()	0	3	1
A	execute()	0	7	2
A	set()	0	5	1

<?php

namespace Pilipinews\Common;

/**
 * Client
 *
 * @package Pilipinews
 * @author  Rougin Gutib <rougingutib@gmail.com>
 */
class Client
{
    const USER_AGENT = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36';

    /**
     * @var resource
     */
    protected $curl;

    /**
     * Initializes the cURL session.
     */
    public function __construct()
    {
        $curl = curl_init();

        curl_setopt($curl, CURLOPT_ENCODING, '');

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($curl, CURLOPT_USERAGENT, self::USER_AGENT);

        curl_setopt($curl, CURLOPT_RETURNTRANSFER, 1);

        $this->curl = $curl;

It seems like $curl can also be of type false. However, the property $curl is declared as type resource. Maybe add an additional type check?

    }

    /**
     * Performs the cURL session.
     *
     * @param  boolean $close
     * @return mixed
     */
    public function execute($close = true)
    {
        $result = curl_exec($this->curl);

        $close && curl_close($this->curl);

        return $result;
    }

    /**
     * Sets an option to the cURL session.
     *
     * @param  integer $key
     * @param  mixed   $value
     * @return self
     */
    public function set($key, $value)
    {
        curl_setopt($this->curl, $key, $value);

        return $this;
    }

    /**
     * Sets the URL to be used in the cURL session.
     *
     * @param  string $link
     * @return self
     */
    public function url($link)
    {
        return $this->set(CURLOPT_URL, $link);
    }

    /**
     * Performs a new cURL session with an URL.
     *
     * @param  string $url
     * @return string
     */
    public static function request($url)
    {
        $curl = new static;

        $curl->url((string) $url);

        return $curl->execute();
    }
}