App\Reuse\Controllers\Api\TRelay

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	apiRelayRequest()	0	35	5

<?php

namespace App\Reuse\Controllers\Api;

use App\Http\Request;

trait TRelay
{

    protected $apiRelayResponse;
    protected $apiRelayHttpCode;
    protected $apiRelayHeaders;
    protected $apiRelayOptionHeader = false;
    protected $apiRelayOptionVerbose = false;

    /**
     * make http request to url with method and headers
     * then set apiRelayResponse with reponse content
     * and apiRelayHttpCode with status code
     *
     * @param string $method
     * @param string $url
     * @param array $headers
     * @param array $datas
     * @return void
     */
    protected function apiRelayRequest(string $method, string $url, array $headers = [], $datas = [])
    {
        $cha = curl_init();
        curl_setopt($cha, CURLOPT_VERBOSE, false);

It seems like $cha can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($cha, CURLOPT_URL, $url);
        curl_setopt($cha, CURLOPT_POST, ($method == Request::METHOD_POST));
        curl_setopt($cha, CURLOPT_TIMEOUT, 300);
        curl_setopt($cha, CURLOPT_USERAGENT, self::USER_AGENT);

The constant App\Reuse\Controllers\Api\TRelay::USER_AGENT was not found. Maybe you did not declare it correctly or list all dependencies?

        curl_setopt($cha, CURLOPT_BUFFERSIZE, self::BUFFER_SIZE);

The constant App\Reuse\Controllers\Api\TRelay::BUFFER_SIZE was not found. Maybe you did not declare it correctly or list all dependencies?

        curl_setopt($cha, CURLOPT_HTTPHEADER, $headers);
        if ($this->apiRelayOptionHeader) {
            curl_setopt($cha, CURLOPT_VERBOSE, 1);
            curl_setopt($cha, CURLOPT_HEADER, 1);
        }
        if ($method == Request::METHOD_POST && $datas) {

The expression $datas of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            curl_setopt(
                $cha,
                CURLOPT_POSTFIELDS,
                http_build_query($datas)
            );
        }
        curl_setopt($cha, CURLOPT_RETURNTRANSFER, 1);
        $this->apiRelayResponse = curl_exec($cha);

It seems like $cha can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        $this->apiRelayHttpCode = curl_getinfo($cha, CURLINFO_HTTP_CODE);

It seems like $cha can also be of type false; however, parameter $ch of curl_getinfo() does only seem to accept resource, maybe add an additional type check?

        if ($this->apiRelayOptionHeader) {
            $this->apiRelayHeaders = [];
            $headerSize = curl_getinfo($cha, CURLINFO_HEADER_SIZE);
            $rawHeaders = substr($this->apiRelayResponse, 0, $headerSize);
            $this->apiRelayHeaders = explode("\r\n\r\n", $rawHeaders, 2);
            $this->apiRelayResponse = substr(
                $this->apiRelayResponse,
                $headerSize
            );
        }
        curl_close($cha);

It seems like $cha can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

    }
}