App\Reuse\Controllers\Api\TRelay

Complexity

Total Complexity

13

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Test Coverage

Coverage

57.89%

Importance

Changes	5
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	apiRelayRequestSetPostData()	0	8	4
B	apiRelayRequest()	0	41	9

<?php

namespace App\Reuse\Controllers\Api;

use App\Http\Request;
use App\Interfaces\Controllers\IApi;

trait TRelay
{

    protected $apiRelayResponse;
    protected $apiRelayHttpCode;
    protected $apiRelayHeaders;
    protected $apiRelayOptionHeader = false;
    protected $apiRelayOptionVerbose = false;

    /**
     * make http request to url with method and headers
     * then set apiRelayResponse with reponse content
     * and apiRelayHttpCode with status code
     *
     * @param string $method
     * @param string $url
     * @param array $headers
     * @param array $datas
     * @return self
     */
    protected function apiRelayRequest(
        string $method,
        string $url,
        array $headers = [],
        $datas = []
    ): self {
        $cha = curl_init();
        if (false !== $cha) {
            curl_setopt($cha, CURLOPT_VERBOSE, false);
            curl_setopt($cha, CURLOPT_URL, $url);
            curl_setopt($cha, CURLOPT_POST, ($method == Request::METHOD_POST));
            curl_setopt($cha, CURLOPT_TIMEOUT, 300);
            curl_setopt($cha, CURLOPT_USERAGENT, IApi::USER_AGENT);
            curl_setopt($cha, CURLOPT_BUFFERSIZE, IApi::BUFFER_SIZE);
            curl_setopt($cha, CURLOPT_HTTPHEADER, $headers);
            if ($this->apiRelayOptionHeader) {
                curl_setopt($cha, CURLOPT_VERBOSE, 1);
                curl_setopt($cha, CURLOPT_HEADER, 1);
            }
            $this->apiRelayRequestSetPostData($cha, $method, $datas);
            curl_setopt($cha, CURLOPT_RETURNTRANSFER, 1);
            $result = curl_exec($cha);
            $error = (false === $result);
            $this->apiRelayResponse = ($error) ? 'Api relay error' : $result;
            $curlInfoCode = ($error) ? 500 : curl_getinfo($cha, CURLINFO_HTTP_CODE);
            $this->apiRelayHttpCode = (false === $curlInfoCode) ? 500 : $curlInfoCode;
            if ($this->apiRelayOptionHeader && false === $error) {
                $this->apiRelayHeaders = [];
                $headerSize = curl_getinfo($cha, CURLINFO_HEADER_SIZE);
                $rawHeaders = substr($this->apiRelayResponse, 0, $headerSize);

It seems like $this->apiRelayResponse can also be of type true; however, parameter $string of substr() does only seem to accept string, maybe add an additional type check?

                $this->apiRelayHeaders = explode("\r\n\r\n", $rawHeaders, 2);
                $this->apiRelayResponse = substr(
                    $this->apiRelayResponse,
                    $headerSize
                );
            }
            if (false === $error) {
                curl_close($cha);
            }
        }
        return $this;
    }

    /**
     * patch curl instance to provide posted datas if required
     *
     * @param mixed $cha
     * @param string $method
     * @param array $datas
     * @return void
     */
    protected function apiRelayRequestSetPostData(&$cha, string $method, array $datas)
    {
        if (is_resource($cha)) {
            if (Request::METHOD_POST == $method && !empty($datas)) {
                curl_setopt(
                    $cha,
                    CURLOPT_POSTFIELDS,
                    http_build_query($datas)
                );
            }
        }
    }
}