App\Component\Cache\Redis\Adapter

Complexity

Total Complexity

8

Size/Duplication

Total Lines	124
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	isError()	0	3	1
A	getErrorCode()	0	3	1
A	getErrorMessage()	0	3	1
A	applyConfig()	0	5	1
A	getClient()	0	13	3
A	__construct()	0	7	1

<?php

namespace App\Component\Cache\Redis;

use Nymfonya\Component\Config;
use \Redis;

class Adapter
{
    const _REDIS = 'redis';
    const _HOST = 'host';
    const _PORT = 'port';

    /**
     * redis server hostname
     *
     * @var string
     */
    protected $host;

    /**
     * redis server port
     *
     * @var integer
     */
    protected $port;

    /**
     * redis instance
     *
     * @var \Redis
     */
    protected $instance;

    /**
     * error
     *
     * @var Boolean
     */
    protected $error;

    /**
     * error code
     *
     * @var int
     */
    protected $errorCode;

    /**
     * error message
     *
     * @var string
     */
    protected $errorMessage;

    /**
     * instanciate
     *
     * @param Config $config
     */
    public function __construct(Config $config)
    {
        $config = $config->getSettings(self::_REDIS);
        $this->applyConfig($config[self::_HOST], $config[self::_PORT]);
        $this->error = false;
        $this->errorCode = 0;
        $this->errorMessage = '';
    }

    /**
     * return redis client instance
     *
     * @return Redis
     */
    public function getClient(): Redis
    {
        if (is_null($this->instance)) {
            try {
                $this->instance =  new Redis();
                @$this->instance->connect($this->host, $this->port);

It seems like you do not handle an error condition for connect(). This can introduce security issues, and is generally not recommended.

            } catch (\RedisException $e) {
                $this->error = true;
                $this->errorMessage = $e->getMessage();
                $this->errorCode = 1;
            }
        }
        return $this->instance;
    }

    /**
     * return true if error
     *
     * @return boolean
     */
    public function isError(): bool
    {
        return $this->error === true;
    }

    /**
     * return code error
     *
     * @return int
     */
    public function getErrorCode(): int
    {
        return $this->errorCode;
    }

    /**
     * return error message
     *
     * @return string
     */
    public function getErrorMessage(): string
    {
        return $this->errorMessage;
    }

    /**
     * set redis server config
     *
     * @param string $host
     * @param integer $port
     * @return Adapter
     */
    protected function applyConfig(string $host, int $port): Adapter
    {
        $this->host = $host;
        $this->port = $port;
        return $this;
    }
}