Routes::get() - Code Metrics - pierre-fromager/nymfonya-http-foundation - Measure and Improve Code Quality continuously with Scrutinizer

Routes::get() A
last analyzed 2021-02-01 12:50 UTC

↳ Parent: Routes

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

declare(strict_types=1);

namespace Nymfonya\Component\Http;

use Nymfonya\Component\Http\Interfaces\RoutesInterface;
use Nymfonya\Component\Http\Route;

class Routes implements RoutesInterface
{

    /**
     * route list as array
     *
     * @var array
     */
    private $routes = [];

    /**
     * __construct
     *
     * @param array $routesConfig
     */
    public function __construct(array $routesConfig = [])
    {
        if (!empty($routesConfig)) {
            $this->set($routesConfig);
        }
    }

    /**
     * set routes as array and stack Route collection
     *
     * @param array $routesConfig
     * @return RoutesInterface
     */
    public function set(array $routesConfig): RoutesInterface
    {
        $this->routes = [];
        $this->prepare($routesConfig);
        $this->validate();
        return $this;
    }

    /**
     * returns routes as array
     *
     * @return array
     */
    public function get(): array
    {
        return $this->routes;
    }

    /**
     * returns routes as array
     *
     * @return array
     */
    public function getExpr(): array
    {
        $patterns = array_map(
            function (Route $i) {
                return $i->getExpr();
            },
            $this->routes
        );
        return $patterns;
    }

    /**
     * stacks routes as Route object collection from routes config
     *
     * @param array $routesConfig
     * @return RoutesInterface
     */
    protected function prepare(array $routesConfig): RoutesInterface
    {
        $count = count($routesConfig);
        for ($c = 0; $c < $count; $c++) {
            $this->routes[] = new Route($routesConfig[$c]);
        }
        return $this;
    }

    /**
     * validate routes to be an array of regexp string
     *
     * @throws Exception
     */
    protected function validate()
    {
        $count = count($this->routes);
        for ($c = 0; $c < $count; $c++) {
            $route = $this->routes[$c]->getExpr();
            if ($this->isInvalidRegexp($route)) {
                throw new \Exception('Route invalid expr ' . $route);
            }
        }
    }

     /**
      * return true if regexp is invalid
      *
      * @param string $regExp
      * @return boolean
      */
    protected function isInvalidRegexp(string $regExp): bool
    {
        @preg_match($regExp, '');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        return (preg_last_error() != PREG_NO_ERROR);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Nymfonya\Component\Http;
6
7		use Nymfonya\Component\Http\Interfaces\RoutesInterface;
8		use Nymfonya\Component\Http\Route;
9
10		class Routes implements RoutesInterface
11		{
12
13		/**
14		* route list as array
15		*
16		* @var array
17		*/
18		private $routes = [];
19
20		/**
21		* __construct
22		*
23		* @param array $routesConfig
24		*/
25	5	public function __construct(array $routesConfig = [])
26		{
27	5	if (!empty($routesConfig)) {
28	5	$this->set($routesConfig);
29		}
30		}
31
32		/**
33		* set routes as array and stack Route collection
34		*
35		* @param array $routesConfig
36		* @return RoutesInterface
37		*/
38	5	public function set(array $routesConfig): RoutesInterface
39		{
40	5	$this->routes = [];
41	5	$this->prepare($routesConfig);
42	5	$this->validate();
43	5	return $this;
44		}
45
46		/**
47		* returns routes as array
48		*
49		* @return array
50		*/
51	1	public function get(): array
52		{
53	1	return $this->routes;
54		}
55
56		/**
57		* returns routes as array
58		*
59		* @return array
60		*/
61	2	public function getExpr(): array
62		{
63	2	$patterns = array_map(
64		function (Route $i) {
65	2	return $i->getExpr();
66	2	},
67	2	$this->routes
68		);
69	2	return $patterns;
70		}
71
72		/**
73		* stacks routes as Route object collection from routes config
74		*
75		* @param array $routesConfig
76		* @return RoutesInterface
77		*/
78	1	protected function prepare(array $routesConfig): RoutesInterface
79		{
80	1	$count = count($routesConfig);
81	1	for ($c = 0; $c < $count; $c++) {
82	1	$this->routes[] = new Route($routesConfig[$c]);
83		}
84	1	return $this;
85		}
86
87		/**
88		* validate routes to be an array of regexp string
89		*
90		* @throws Exception
91		*/
92	2	protected function validate()
93		{
94	2	$count = count($this->routes);
95	2	for ($c = 0; $c < $count; $c++) {
96	2	$route = $this->routes[$c]->getExpr();
97	2	if ($this->isInvalidRegexp($route)) {
98	1	throw new \Exception('Route invalid expr ' . $route);
99		}
100		}
101		}
102
103		/**
104		* return true if regexp is invalid
105		*
106		* @param string $regExp
107		* @return boolean
108		*/
109		protected function isInvalidRegexp(string $regExp): bool
110		{
111		@preg_match($regExp, '');
		0 ignored issues – show Security Best Practice introduced 2020-12-30 05:26 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
112		return (preg_last_error() != PREG_NO_ERROR);
113		}
114		}
115

pierre-fromager / nymfonya-http-foundation

Routes::get() A last analyzed 2021-02-01 12:50 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Routes::get() A
last analyzed 2021-02-01 12:50 UTC