Phuria\QueryBuilder\TableRecognizer

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

68.75%

Importance

Changes	4
Bugs	0	Features	2

2 Methods

Rating	Name	Duplication	Size	Complexity
B	recognizeType()	0	15	5
A	extractClassName()	0	7	1

<?php
namespace Phuria\QueryBuilder;

/**
 * @author Beniamin Jonatan Šimko <spam@simko.it>
 */
class TableRecognizer
{
    const TYPE_CLOSURE = 1;
    const TYPE_ROUTE = 2;
    const TYPE_CLASS_NAME = 3;
    const TYPE_TABLE_NAME = 4;
    const TYPE_SUB_QUERY = 5;

    /**
     * @param mixed $stuff
     *
     * @return int
     */
    public function recognizeType($stuff)
    {
        switch (true) {

It seems like you are loosely comparing strpos($stuff, '\\') of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

            case $stuff instanceof \Closure:
                return static::TYPE_CLOSURE;
            case $stuff instanceof QueryBuilder:
                return static::TYPE_SUB_QUERY;
            case false !== strpos($stuff, '.'):
                return static::TYPE_ROUTE;
            case strpos($stuff, '\\'):
                return static::TYPE_CLASS_NAME;
        }

        return static::TYPE_TABLE_NAME;
    }

    /**
     * @param \Closure $closure
     *
     * @return string
     */
    public function extractClassName(\Closure $closure)
    {
        $ref = new \ReflectionFunction($closure);
        $firstParameter = $ref->getParameters()[0];

        return $firstParameter->getClass()->getName();
    }
}