Phuria\SQLBuilder\QueryBuilder\Component\TableComponentTrait

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

75%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
	getTableFactory()	0	1	?
	getQueryBuilder()	0	1	?
A	getRootTables()	0	4	1
A	addRootTable()	0	10	2

<?php

/**
 * This file is part of Phuria SQL Builder package.
 *
 * Copyright (c) 2016 Beniamin Jonatan Šimko
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Phuria\SQLBuilder\QueryBuilder\Component;

use Phuria\SQLBuilder\QueryBuilder\BuilderInterface;
use Phuria\SQLBuilder\Table\AbstractTable;
use Phuria\SQLBuilder\TableFactory\TableFactoryInterface;

/**
 * @author Beniamin Jonatan Šimko <spam@simko.it>
 */
trait TableComponentTrait
{
    /**
     * @var AbstractTable[] $tables
     */
    private $rootTables = [];

    /**
     * @return TableFactoryInterface
     */
    abstract protected function getTableFactory();

    /**
     * @return BuilderInterface
     */
    abstract public function getQueryBuilder();

    /**
     * @param mixed  $table
     * @param string $alias

Should the type for parameter $alias not be string|null?

     *
     * @return AbstractTable
     */
    protected function addRootTable($table, $alias = null)
    {
        $this->rootTables[] = $table = $this->getTableFactory()->createNewTable($table, $this->getQueryBuilder());

        if ($alias) {

The expression $alias of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $table->setAlias($alias);
        }

        return $table;
    }

    /**
     * @return AbstractTable[]
     */
    public function getRootTables()
    {
        return $this->rootTables;
    }
}