Phuria\SQLBuilder\QueryBuilder\AbstractInsertBuilder

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	into()	0	8	2

<?php

/**
 * This file is part of Phuria SQL Builder package.
 *
 * Copyright (c) 2016 Beniamin Jonatan Šimko
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Phuria\SQLBuilder\QueryBuilder;

use Phuria\SQLBuilder\Table\AbstractTable;

/**
 * @author Beniamin Jonatan Šimko <spam@simko.it>
 */
abstract class AbstractInsertBuilder extends AbstractBuilder implements
    Clause\InsertColumnsClauseInterface,
    Component\TableComponentInterface
{
    use Clause\InsertColumnsClauseTrait;
    use Component\QueryComponentTrait;
    use Component\TableComponentTrait;

    /**
     * @param mixed $table
     * @param array $columns
     *
     * @return AbstractTable
     */
    public function into($table, array $columns = [])
    {
        if ($columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->setColumns($columns);
        }

        return $this->addRootTable($table);
    }
}