Completed
Branch feature/scrutinizer (10e3c1)
by Tobias
05:25
created
src/commands/AppController.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -115,6 +115,9 @@
 block discarded – undo
115 115
         }
116 116
     }
117 117
 
118
+    /**
119
+     * @param string $command
120
+     */
118 121
     protected function action($command, $params = [])
119 122
     {
120 123
         echo "\nRunning action '$command'...\n";
Please login to merge, or discard this patch.
src/components/User.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
      * @param array     $params
26 26
      * @param bool|true $allowCaching
27 27
      *
28
-     * @return bool
28
+     * @return boolean|null
29 29
      */
30 30
     public function can($permissionName, $params = [], $allowCaching = true)
31 31
     {
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     /**
46 46
      * Checks permissions from guest role, when no user is logged in.
47 47
      *
48
-     * @param $permissionName
48
+     * @param string $permissionName
49 49
      * @param $params
50 50
      * @param $allowCaching
51 51
      *
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      * Splits `permissionName` by underscore and match parts against more global rule
65 65
      * eg. a permission `app_site` will match, `app_site_foo`
66 66
      *
67
-     * @param $permissionName
67
+     * @param string $permissionName
68 68
      * @param $params
69 69
      * @param $allowCaching
70 70
      *
Please login to merge, or discard this patch.
src/modules/prototype/controllers/base/LessController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	
44 44
 	/**
45 45
 	 * Lists all Less models.
46
-	 * @return mixed
46
+	 * @return string
47 47
 	 */
48 48
 	public function actionIndex()
49 49
 	{
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 	 * Displays a single Less model.
66 66
 	 * @param integer $id
67 67
      *
68
-	 * @return mixed
68
+	 * @return string
69 69
 	 */
70 70
 	public function actionView($id)
71 71
 	{
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
 	 * Deletes an existing Less model.
124 124
 	 * If deletion is successful, the browser will be redirected to the 'index' page.
125 125
 	 * @param integer $id
126
-	 * @return mixed
126
+	 * @return \yii\web\Response
127 127
 	 */
128 128
 	public function actionDelete($id)
129 129
 	{
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 				'rules' => [
35 35
 					[
36 36
 						'allow' => true,
37
-						'matchCallback' => function ($rule, $action) {return \Yii::$app->user->can($this->module->id . '_' . $this->id . '_' . $action->id, ['route' => true]);},
37
+						'matchCallback' => function($rule, $action) {return \Yii::$app->user->can($this->module->id.'_'.$this->id.'_'.$action->id, ['route' => true]); },
38 38
 					]
39 39
 				]
40 40
 			]
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
                 $model->load($_GET);
95 95
             }
96 96
         } catch (\Exception $e) {
97
-            $msg = (isset($e->errorInfo[2]))?$e->errorInfo[2]:$e->getMessage();
97
+            $msg = (isset($e->errorInfo[2])) ? $e->errorInfo[2] : $e->getMessage();
98 98
             $model->addError('_exception', $msg);
99 99
 		}
100 100
         return $this->render('create', ['model' => $model]);
@@ -130,13 +130,13 @@  discard block
 block discarded – undo
130 130
         try {
131 131
             $this->findModel($id)->delete();
132 132
         } catch (\Exception $e) {
133
-            $msg = (isset($e->errorInfo[2]))?$e->errorInfo[2]:$e->getMessage();
133
+            $msg = (isset($e->errorInfo[2])) ? $e->errorInfo[2] : $e->getMessage();
134 134
             \Yii::$app->getSession()->addFlash('error', $msg);
135 135
             return $this->redirect(Url::previous());
136 136
         }
137 137
 
138 138
         // TODO: improve detection
139
-        $isPivot = strstr('$id',',');
139
+        $isPivot = strstr('$id', ',');
140 140
         if ($isPivot == true) {
141 141
             return $this->redirect(Url::previous());
142 142
         } elseif (isset(\Yii::$app->session['__crudReturnUrl']) && \Yii::$app->session['__crudReturnUrl'] != '/') {
Please login to merge, or discard this patch.
src/config/giiant.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 use schmunk42\giiant\generators\crud\callbacks\yii\Db;
6 6
 use schmunk42\giiant\generators\crud\callbacks\yii\Html;
7 7
 
8
-$aceEditorField = function ($attribute, $model, $generator) {
8
+$aceEditorField = function($attribute, $model, $generator) {
9 9
     return "\$form->field(\$model, '{$attribute}')->widget(\\trntv\\aceeditor\\AceEditor::className())";
10 10
 };
11 11
 
Please login to merge, or discard this patch.
src/config/main.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,8 +18,7 @@  discard block
 block discarded – undo
18 18
             // Note: For using mounted volumes or shared folders
19 19
             'dirMode' => YII_ENV_PROD ? 0777 : null,
20 20
             'bundles' => getenv('APP_ASSET_USE_BUNDLED') ?
21
-                require(__DIR__.'/assets-gen/prod.php') :
22
-                [
21
+                require(__DIR__.'/assets-gen/prod.php') : [
23 22
                     // Note: if your asset bundle includes bootstrap, you can disable the default asset
24 23
                     #'yii\bootstrap\BootstrapAsset' => false,
25 24
                 ],
@@ -78,7 +77,7 @@  discard block
 block discarded – undo
78 77
                 'docs/<file:[a-zA-Z0-9_\-\./]+>' => 'docs',
79 78
                 #'docs' => 'docs/default/index',
80 79
             ],
81
-            'languages' => explode(',',getenv('APP_LANGUAGES')),
80
+            'languages' => explode(',', getenv('APP_LANGUAGES')),
82 81
         ],
83 82
         'user' => [
84 83
             'class' => 'app\components\User',
Please login to merge, or discard this patch.
src/modules/backend/controllers/DefaultController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@
 block discarded – undo
28 28
                     ],
29 29
                     [
30 30
                         'allow' => true,
31
-                        'matchCallback' => function ($rule, $action) {
31
+                        'matchCallback' => function($rule, $action) {
32 32
                             return \Yii::$app->user->can(
33 33
                                 $this->module->id.'_'.$this->id.'_'.$action->id,
34 34
                                 ['route' => true]
Please login to merge, or discard this patch.
src/modules/backend/views/layouts/_sidebar.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,8 +60,7 @@
 block discarded – undo
60 60
 
61 61
     // check for module configuration and assign to favourites
62 62
     $moduleConfigItem = (is_object($module)) ?
63
-        (isset($module->params['menuItems']) ? $module->params['menuItems'] : []) :
64
-        (isset($module['params']['menuItems']) ? $module['params']['menuItems'] : []);
63
+        (isset($module->params['menuItems']) ? $module->params['menuItems'] : []) : (isset($module['params']['menuItems']) ? $module['params']['menuItems'] : []);
65 64
     switch (true) {
66 65
         case !empty($moduleConfigItem):
67 66
             $moduleConfigItem = array_merge($defaultItem, $moduleConfigItem);
Please login to merge, or discard this patch.
src/modules/prototype/controllers/api/LessController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
                     'rules' => [
26 26
                         [
27 27
                             'allow' => true,
28
-                            'matchCallback' => function ($rule, $action) {return \Yii::$app->user->can($this->module->id . '_' . $this->id . '_' . $action->id, ['route' => true]);},
28
+                            'matchCallback' => function($rule, $action) {return \Yii::$app->user->can($this->module->id.'_'.$this->id.'_'.$action->id, ['route' => true]); },
29 29
                         ]
30 30
                     ]
31 31
                 ]
Please login to merge, or discard this patch.
src/modules/prototype/migrations/m151226_111407_init.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,17 +9,17 @@
 block discarded – undo
9 9
     {
10 10
         $this->createTable('{{%html}}', [
11 11
             'id' => Schema::TYPE_PK,
12
-            'key' => Schema::TYPE_STRING . ' NOT NULL',
13
-            'value' => Schema::TYPE_TEXT . ' NOT NULL',
12
+            'key' => Schema::TYPE_STRING.' NOT NULL',
13
+            'value' => Schema::TYPE_TEXT.' NOT NULL',
14 14
         ]);
15
-        $this->createIndex('html_key_unique','{{%html}}', 'key', true);
15
+        $this->createIndex('html_key_unique', '{{%html}}', 'key', true);
16 16
 
17 17
         $this->createTable('{{%less}}', [
18 18
             'id' => Schema::TYPE_PK,
19
-            'key' => Schema::TYPE_STRING . ' NOT NULL',
19
+            'key' => Schema::TYPE_STRING.' NOT NULL',
20 20
             'value' => Schema::TYPE_TEXT,
21 21
         ]);
22
-        $this->createIndex('less_key_unique','{{%less}}', 'key', true);
22
+        $this->createIndex('less_key_unique', '{{%less}}', 'key', true);
23 23
     }
24 24
 
25 25
     public function down()
Please login to merge, or discard this patch.