app\modules\prototype\assets\DbAsset

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	init()	0	25	4

<?php
namespace app\modules\prototype\assets;

/**
 * @link http://www.diemeisterei.de/
 *
 * @copyright Copyright (c) 2015 diemeisterei GmbH, Stuttgart
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use app\modules\prototype\models\Less;
use yii\caching\FileDependency;
use yii\helpers\FileHelper;
use yii\helpers\Json;
use yii\web\AssetBundle;

class DbAsset extends AssetBundle
{
    const CACHE_ID = 'app\assets\SettingsAsset';
    const SETTINGS_KEY = 'app.less';
    const MAIN_LESS_FILE = 'main.less';

    public $sourcePath = '@runtime/settings-asset';

    public $css = [
        self::MAIN_LESS_FILE,
    ];

    public $depends = [
        // if a full Bootstrap CSS is compiled, it's recommended to disable the asset in assetManager configuration
        'yii\bootstrap\BootstrapAsset',
    ];

    public function init()
    {
        parent::init();

        $sourcePath = \Yii::getAlias($this->sourcePath);
        @mkdir($sourcePath);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $models = Less::find()->all();
        $hash = sha1(Json::encode($models));

        if ($hash !== \Yii::$app->cache->get(self::CACHE_ID)) {
            $lessFiles = FileHelper::findFiles($sourcePath, ['only' => ['*.less']]);

It seems like $sourcePath defined by \Yii::getAlias($this->sourcePath) on line 40 can also be of type boolean; however, yii\helpers\BaseFileHelper::findFiles() does only seem to accept string, maybe add an additional type check?

            foreach ($lessFiles as $file) {
                unlink($file);
            }
            foreach ($models as $model) {
                file_put_contents("$sourcePath/{$model->key}.less", $model->value);
            }

            $dependency = new FileDependency();
            $dependency->fileName = __FILE__;
            \Yii::$app->cache->set(self::CACHE_ID, $hash, 0, $dependency);
            @touch($sourcePath);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }
    }
}