ResponseSignatureValidation::validateSignature() - Code Metrics - phpviet/omnipay-vnpay - Measure and Improve Code Quality continuously with Scrutinizer

ResponseSignatureValidation::validateSignature() A
last analyzed 2020-07-09 07:48 UTC

↳ Parent: ResponseSignatureValidation

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	23
rs	9.2408
c	0
b	0
f	0
cc	5
nc	3
nop	0

<?php
/**
 * @link https://github.com/phpviet/omnipay-vnpay
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\VNPay\Message\Concerns;

use Omnipay\Common\Exception\InvalidResponseException;
use Omnipay\VNPay\Support\Signature;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait ResponseSignatureValidation
{
    /**
     * Kiểm tra tính hợp lệ của dữ liệu do VNPay phản hồi.
     *
     * @throws InvalidResponseException
     */
    protected function validateSignature(): void
    {
        $data = $this->getData();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (! isset($data['vnp_SecureHash'])) {
            throw new InvalidResponseException('Response from VNPay is invalid!');
        }

        $dataSignature = array_filter($this->getData(), function ($parameter) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return 0 === strpos($parameter, 'vnp_')
                && 'vnp_SecureHash' !== $parameter
                && 'vnp_SecureHashType' !== $parameter;
        }, ARRAY_FILTER_USE_KEY);

        $signature = new Signature(
            $this->getRequest()->getVnpHashSecret(),
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $data['vnp_SecureHashType'] ?? 'md5'
        );

        if (! $signature->validate($dataSignature, $data['vnp_SecureHash'])) {
            throw new InvalidResponseException(sprintf('Data signature response from VNPay is invalid!'));
        }
    }
}


1			<?php
2			/**
3			* @link https://github.com/phpviet/omnipay-vnpay
4			* @copyright (c) PHP Viet
5			* @license [MIT](http://www.opensource.org/licenses/MIT)
6			*/
7
8			namespace Omnipay\VNPay\Message\Concerns;
9
10			use Omnipay\Common\Exception\InvalidResponseException;
11			use Omnipay\VNPay\Support\Signature;
12
13			/**
14			* @author Vuong Minh <[email protected]>
15			* @since 1.0.0
16			*/
17			trait ResponseSignatureValidation
18			{
19			/**
20			* Kiểm tra tính hợp lệ của dữ liệu do VNPay phản hồi.
21			*
22			* @throws InvalidResponseException
23			*/
24			protected function validateSignature(): void
25			{
26			$data = $this->getData();
			0 ignored issues – show Bug introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report It seems like `getData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27
28			if (! isset($data['vnp_SecureHash'])) {
29			throw new InvalidResponseException('Response from VNPay is invalid!');
30			}
31
32			$dataSignature = array_filter($this->getData(), function ($parameter) {
			0 ignored issues – show Bug introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report It seems like `getData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33			return 0 === strpos($parameter, 'vnp_')
34			&& 'vnp_SecureHash' !== $parameter
35			&& 'vnp_SecureHashType' !== $parameter;
36			}, ARRAY_FILTER_USE_KEY);
37
38			$signature = new Signature(
39			$this->getRequest()->getVnpHashSecret(),
			0 ignored issues – show Bug introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report It seems like `getRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40			$data['vnp_SecureHashType'] ?? 'md5'
41			);
42
43			if (! $signature->validate($dataSignature, $data['vnp_SecureHash'])) {
44			throw new InvalidResponseException(sprintf('Data signature response from VNPay is invalid!'));
45			}
46			}
47			}
48

phpviet / omnipay-vnpay

ResponseSignatureValidation::validateSignature() A last analyzed 2020-07-09 07:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ResponseSignatureValidation::validateSignature() A
last analyzed 2020-07-09 07:48 UTC