RequestEndpoint::getEndpoint() - Code Metrics - phpviet/omnipay-vnpay - Measure and Improve Code Quality continuously with Scrutinizer

RequestEndpoint::getEndpoint() A
last analyzed 2020-07-09 07:48 UTC

↳ Parent: RequestEndpoint

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php
/**
 * @link https://github.com/phpviet/omnipay-vnpay
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\VNPay\Message\Concerns;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait RequestEndpoint
{
    /**
     * Đường dẫn giao tiếp với VNPay ở môi trường production.
     *
     * @var string
     */
    protected $productionEndpoint;

    /**
     * Đường dẫn giao tiếp với VNPay ở môi trường test.
     *
     * @var string
     */
    protected $testEndpoint;

    /**
     * Trả về url kết nối VNPay.
     *
     * @return string
     */
    protected function getEndpoint(): string
    {
        return $this->getTestMode() ? $this->testEndpoint : $this->productionEndpoint;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2			/**
3			* @link https://github.com/phpviet/omnipay-vnpay
4			* @copyright (c) PHP Viet
5			* @license [MIT](http://www.opensource.org/licenses/MIT)
6			*/
7
8			namespace Omnipay\VNPay\Message\Concerns;
9
10			/**
11			* @author Vuong Minh <[email protected]>
12			* @since 1.0.0
13			*/
14			trait RequestEndpoint
15			{
16			/**
17			* Đường dẫn giao tiếp với VNPay ở môi trường production.
18			*
19			* @var string
20			*/
21			protected $productionEndpoint;
22
23			/**
24			* Đường dẫn giao tiếp với VNPay ở môi trường test.
25			*
26			* @var string
27			*/
28			protected $testEndpoint;
29
30			/**
31			* Trả về url kết nối VNPay.
32			*
33			* @return string
34			*/
35			protected function getEndpoint(): string
36			{
37			return $this->getTestMode() ? $this->testEndpoint : $this->productionEndpoint;
			0 ignored issues – show Bug introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report It seems like `getTestMode()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38			}
39			}
40

phpviet / omnipay-vnpay

RequestEndpoint::getEndpoint() A last analyzed 2020-07-09 07:48 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RequestEndpoint::getEndpoint() A
last analyzed 2020-07-09 07:48 UTC