ResponseProperties - Code Metrics - phpviet/omnipay-vnpay - Measure and Improve Code Quality continuously with Scrutinizer

ResponseProperties A
last analyzed 2020-07-09 07:48 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	40.74 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	0
dl	22
loc	54
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__get()	12	12	2
A	__set()	10	10	2
A	propertyNormalize()	0	8	3

How to fix Duplicated Code

<?php
/**
 * @link https://github.com/phpviet/omnipay-vnpay
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\VNPay\Message\Concerns;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait ResponseProperties
{
    /**
     * Phương thức hổ trợ tạo các thuộc tính của đối tượng từ dữ liệu gửi về từ VNPay.
     *
     * @param  string  $name
     * @return null|string
     */
    public function __get($name)

    {
        $property = $this->propertyNormalize($name);

        if (isset($this->data[$property])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return $this->data[$property];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            trigger_error(sprintf('Undefined property: %s::%s', __CLASS__, '$'.$name), E_USER_NOTICE);

            return;
        }
    }

    /**
     * Phương thức hổ trợ bảo vệ các thuộc tính của đối tượng từ dữ liệu gửi về từ VNPay.
     *
     * @param  string  $name
     * @param  mixed  $value
     * @return null|string
     */
    public function __set($name, $value)

    {
        $property = $this->propertyNormalize($name);

        if (isset($this->data[$property])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            trigger_error(sprintf('Undefined property: %s::%s', __CLASS__, '$'.$name), E_USER_NOTICE);
        } else {
            $this->$name = $value;
        }
    }

    /**
     * Phương thức hổ trợ chuyển đổi property `vpcAbc` thành `vpc_Abc`.
     *
     * @param  string  $property
     * @return string
     */
    private function propertyNormalize(string $property): string
    {
        if (0 === strpos($property, 'vnp') && false === strpos($property, '_')) {
            return 'vnp_'.substr($property, 3);
        }

        return $property;
    }
}


1		<?php
2		/**
3		* @link https://github.com/phpviet/omnipay-vnpay
4		* @copyright (c) PHP Viet
5		* @license [MIT](http://www.opensource.org/licenses/MIT)
6		*/
7
8		namespace Omnipay\VNPay\Message\Concerns;
9
10		/**
11		* @author Vuong Minh <[email protected]>
12		* @since 1.0.0
13		*/
14		trait ResponseProperties
15		{
16		/**
17		* Phương thức hổ trợ tạo các thuộc tính của đối tượng từ dữ liệu gửi về từ VNPay.
18		*
19		* @param string $name
20		* @return null\|string
21		*/
22	View Code Duplication	public function __get($name)
		0 ignored issues – show Duplication introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$property = $this->propertyNormalize($name);
25
26		if (isset($this->data[$property])) {
		0 ignored issues – show Documentation introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report The property `data` does not exist on `object<Omnipay\VNPay\Mes...rns\ResponseProperties>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
27		return $this->data[$property];
		0 ignored issues – show Documentation introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report The property `data` does not exist on `object<Omnipay\VNPay\Mes...rns\ResponseProperties>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
28		} else {
29		trigger_error(sprintf('Undefined property: %s::%s', __CLASS__, '$'.$name), E_USER_NOTICE);
30
31		return;
32		}
33		}
34
35		/**
36		* Phương thức hổ trợ bảo vệ các thuộc tính của đối tượng từ dữ liệu gửi về từ VNPay.
37		*
38		* @param string $name
39		* @param mixed $value
40		* @return null\|string
41		*/
42	View Code Duplication	public function __set($name, $value)
		0 ignored issues – show Duplication introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$property = $this->propertyNormalize($name);
45
46		if (isset($this->data[$property])) {
		0 ignored issues – show Documentation introduced 2019-07-05 10:23 UTC by Report Bug Copy Issue Report The property `data` does not exist on `object<Omnipay\VNPay\Mes...rns\ResponseProperties>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
47		trigger_error(sprintf('Undefined property: %s::%s', __CLASS__, '$'.$name), E_USER_NOTICE);
48		} else {
49		$this->$name = $value;
50		}
51		}
52
53		/**
54		* Phương thức hổ trợ chuyển đổi property `vpcAbc` thành `vpc_Abc`.
55		*
56		* @param string $property
57		* @return string
58		*/
59		private function propertyNormalize(string $property): string
60		{
61		if (0 === strpos($property, 'vnp') && false === strpos($property, '_')) {
62		return 'vnp_'.substr($property, 3);
63		}
64
65		return $property;
66		}
67		}
68

phpviet / omnipay-vnpay

ResponseProperties A last analyzed 2020-07-09 07:48 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ResponseProperties A
last analyzed 2020-07-09 07:48 UTC