Omnipay\VNPay\Message\Concerns\RequestSignature

Complexity

Total Complexity

2

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	generateSignature()	0	14	2
	getSignatureParameters()	0	1	?

<?php
/**
 * @link https://github.com/phpviet/omnipay-vnpay
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\VNPay\Message\Concerns;

use Omnipay\VNPay\Support\Signature;

/**
 * @author Vuong Minh <vuongxuongminh@gmail.com>
 * @since 1.0.0
 */
trait RequestSignature
{
    /**
     * Trả về chữ ký điện tử gửi đến VNPay dựa theo [[getSignatureParameters()]].
     *
     * @param  string  $hashType
     * @return string
     */
    protected function generateSignature(string $hashType = 'sha256'): string
    {
        $data = [];
        $signature = new Signature(
            $this->getVnpHashSecret(),

It seems like getVnpHashSecret() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $hashType
        );

        foreach ($this->getSignatureParameters() as $parameter) {
            $data[$parameter] = $this->getParameter($parameter);

It seems like getParameter() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $signature->generate($data);
    }

    /**
     * Trả về danh sách parameters dùng để tạo chữ ký số.
     *
     * @return array
     */
    abstract protected function getSignatureParameters(): array;
}