RequestSignature::generateSignature() - Code Metrics - phpviet/omnipay-onepay - Measure and Improve Code Quality continuously with Scrutinizer

RequestSignature::generateSignature() A
last analyzed 2020-08-07 14:34 UTC

↳ Parent: RequestSignature

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	0

<?php
/**
 * @link https://github.com/phpviet/omnipay-onepay
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\OnePay\Message\Concerns;

use Omnipay\OnePay\Support\Signature;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait RequestSignature
{
    /**
     * Trả về chữ ký điện tử gửi đến OnePay dựa theo [[getSignatureParameters()]].
     *
     * @return string
     */
    protected function generateSignature(): string
    {
        $data = [];
        $signature = new Signature(
            $this->getVpcHashKey()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );

        foreach ($this->getSignatureParameters() as $parameter) {
            $data[$parameter] = $this->getParameter($parameter);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $signature->generate($data);
    }

    /**
     * Trả về danh sách parameters dùng để tạo chữ ký số.
     *
     * @return array
     */
    abstract protected function getSignatureParameters(): array;
}


1			<?php
2			/**
3			* @link https://github.com/phpviet/omnipay-onepay
4			* @copyright (c) PHP Viet
5			* @license [MIT](http://www.opensource.org/licenses/MIT)
6			*/
7
8			namespace Omnipay\OnePay\Message\Concerns;
9
10			use Omnipay\OnePay\Support\Signature;
11
12			/**
13			* @author Vuong Minh <[email protected]>
14			* @since 1.0.0
15			*/
16			trait RequestSignature
17			{
18			/**
19			* Trả về chữ ký điện tử gửi đến OnePay dựa theo [[getSignatureParameters()]].
20			*
21			* @return string
22			*/
23			protected function generateSignature(): string
24			{
25			$data = [];
26			$signature = new Signature(
27			$this->getVpcHashKey()
			0 ignored issues – show Bug introduced 2019-07-03 08:49 UTC by Report Bug Copy Issue Report It seems like `getVpcHashKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			);
29
30			foreach ($this->getSignatureParameters() as $parameter) {
31			$data[$parameter] = $this->getParameter($parameter);
			0 ignored issues – show Bug introduced 2019-07-03 08:49 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33
34			return $signature->generate($data);
35			}
36
37			/**
38			* Trả về danh sách parameters dùng để tạo chữ ký số.
39			*
40			* @return array
41			*/
42			abstract protected function getSignatureParameters(): array;
43			}
44

phpviet / omnipay-onepay

RequestSignature::generateSignature() A last analyzed 2020-08-07 14:34 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RequestSignature::generateSignature() A
last analyzed 2020-08-07 14:34 UTC