ResponseSignatureValidation::validateSignature() - Code Metrics - phpviet/omnipay-momo - Measure and Improve Code Quality continuously with Scrutinizer

ResponseSignatureValidation::validateSignature() A
last analyzed 2019-08-11 11:37 UTC

↳ Parent: ResponseSignatureValidation

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	25
rs	9.2088
c	0
b	0
f	0
cc	5
nc	7
nop	0

<?php
/**
 * @link https://github.com/phpviet/omnipay-momo
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace Omnipay\MoMo\Message\Concerns;

use Omnipay\MoMo\Support\Arr;
use Omnipay\MoMo\Support\Signature;
use Omnipay\Common\Exception\InvalidResponseException;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait ResponseSignatureValidation
{
    /**
     * Kiểm tra tính hợp lệ của dữ liệu do MoMo phản hồi.
     *
     * @throws InvalidResponseException
     */
    protected function validateSignature(): void
    {
        $data = $this->getData();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (! isset($data['signature'])) {
            throw new InvalidResponseException(sprintf('Response from MoMo is invalid!'));
        }

        $dataSignature = [];
        $signature = new Signature(
            $this->getRequest()->getSecretKey()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        );

        foreach ($this->getSignatureParameters() as $pos => $parameter) {
            if (! is_string($pos)) {
                $pos = $parameter;
            }

            $dataSignature[$pos] = Arr::getValue($parameter, $data);
        }

        if (! $signature->validate($dataSignature, $data['signature'])) {
            throw new InvalidResponseException(sprintf('Data signature response from MoMo is invalid!'));
        }
    }

    /**
     * Trả về danh sách các param data đã dùng để tạo chữ ký dữ liệu.
     *
     * @return array
     */
    abstract protected function getSignatureParameters(): array;
}


1			<?php
2			/**
3			* @link https://github.com/phpviet/omnipay-momo
4			* @copyright (c) PHP Viet
5			* @license [MIT](http://www.opensource.org/licenses/MIT)
6			*/
7
8			namespace Omnipay\MoMo\Message\Concerns;
9
10			use Omnipay\MoMo\Support\Arr;
11			use Omnipay\MoMo\Support\Signature;
12			use Omnipay\Common\Exception\InvalidResponseException;
13
14			/**
15			* @author Vuong Minh <[email protected]>
16			* @since 1.0.0
17			*/
18			trait ResponseSignatureValidation
19			{
20			/**
21			* Kiểm tra tính hợp lệ của dữ liệu do MoMo phản hồi.
22			*
23			* @throws InvalidResponseException
24			*/
25			protected function validateSignature(): void
26			{
27			$data = $this->getData();
			0 ignored issues – show Bug introduced 2019-07-05 06:02 UTC by Report Bug Copy Issue Report It seems like `getData()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28
29			if (! isset($data['signature'])) {
30			throw new InvalidResponseException(sprintf('Response from MoMo is invalid!'));
31			}
32
33			$dataSignature = [];
34			$signature = new Signature(
35			$this->getRequest()->getSecretKey()
			0 ignored issues – show Bug introduced 2019-07-03 05:23 UTC by Report Bug Copy Issue Report It seems like `getRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			);
37
38			foreach ($this->getSignatureParameters() as $pos => $parameter) {
39			if (! is_string($pos)) {
40			$pos = $parameter;
41			}
42
43			$dataSignature[$pos] = Arr::getValue($parameter, $data);
44			}
45
46			if (! $signature->validate($dataSignature, $data['signature'])) {
47			throw new InvalidResponseException(sprintf('Data signature response from MoMo is invalid!'));
48			}
49			}
50
51			/**
52			* Trả về danh sách các param data đã dùng để tạo chữ ký dữ liệu.
53			*
54			* @return array
55			*/
56			abstract protected function getSignatureParameters(): array;
57			}
58

phpviet / omnipay-momo

ResponseSignatureValidation::validateSignature() A last analyzed 2019-08-11 11:37 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ResponseSignatureValidation::validateSignature() A
last analyzed 2019-08-11 11:37 UTC