AwsS3v2FilesystemCompatible::getUrl() - Code Metrics - phpviet/laravel-flysystem - Measure and Improve Code Quality continuously with Scrutinizer

AwsS3v2FilesystemCompatible::getUrl() A
last analyzed 2019-07-09 04:50 UTC

↳ Parent: AwsS3v2FilesystemCompatible

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php
/**
 * @link https://github.com/phpviet/laravel-flysystem
 * @copyright (c) PHP Viet
 * @license [MIT](http://www.opensource.org/licenses/MIT)
 */

namespace PHPViet\Laravel\Flysystem\Drivers;

/**
 * @author Vuong Minh <[email protected]>
 * @since 1.0.0
 */
trait AwsS3v2FilesystemCompatible
{
    /**
     * Trả về AWS S3v2 URL theo đường dẫn chỉ định.
     *
     * @param  string  $path
     * @return string
     */
    public function getUrl(string $path): string
    {
        $adapter = $this->getAdapter();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $path = $adapter->getPathPrefix().$path;

        if (! is_null($url = $this->getConfig()->get('url'))) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return rtrim($url, '/').'/'.ltrim($path, '/');
        }

        return $adapter->getClient()->getObjectUrl(
            $adapter->getBucket(),
            $path
        );
    }
}


1			<?php
2			/**
3			* @link https://github.com/phpviet/laravel-flysystem
4			* @copyright (c) PHP Viet
5			* @license [MIT](http://www.opensource.org/licenses/MIT)
6			*/
7
8			namespace PHPViet\Laravel\Flysystem\Drivers;
9
10			/**
11			* @author Vuong Minh <[email protected]>
12			* @since 1.0.0
13			*/
14			trait AwsS3v2FilesystemCompatible
15			{
16			/**
17			* Trả về AWS S3v2 URL theo đường dẫn chỉ định.
18			*
19			* @param string $path
20			* @return string
21			*/
22			public function getUrl(string $path): string
23			{
24			$adapter = $this->getAdapter();
			0 ignored issues – show Bug introduced 2019-07-09 04:50 UTC by Report Bug Copy Issue Report It seems like `getAdapter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			$path = $adapter->getPathPrefix().$path;
26
27			if (! is_null($url = $this->getConfig()->get('url'))) {
			0 ignored issues – show Bug introduced 2019-07-08 15:07 UTC by Report Bug Copy Issue Report It seems like `getConfig()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			return rtrim($url, '/').'/'.ltrim($path, '/');
29			}
30
31			return $adapter->getClient()->getObjectUrl(
32			$adapter->getBucket(),
33			$path
34			);
35			}
36			}
37

phpviet / laravel-flysystem

AwsS3v2FilesystemCompatible::getUrl() A last analyzed 2019-07-09 04:50 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AwsS3v2FilesystemCompatible::getUrl() A
last analyzed 2019-07-09 04:50 UTC