JSONTextTest - Code Metrics - Inspection of "Added basic Scrutinizer config." - phptek/silverstripe-jsontext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cb9664...d0d98a )

by Russell

created 2016-06-10 04:09 UTC

JSONTextTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	28.42 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	7
Bugs	1	Features	2

Metric	Value
wmc	9
c	7
b	1
f	2
lcom	1
cbo	0
dl	52
loc	183
rs	10

9 Methods

Rating	Name	Duplication	Size	Complexity
A	testgetValueAsIterable()	0	11	1
A	testFirst_AsArray()	13	13	1
A	testFirst_AsJson()	13	13	1
A	testLast_AsArray()	13	13	1
A	testLast_AsJson()	13	13	1
A	testNth_AsArray()	0	20	1
A	testNth_AsJson()	0	20	1
B	testquery_AsInt_AsArray()	0	26	1
B	testquery_AsStr_AsArray()	0	24	1

How to fix Duplicated Code

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <[email protected]>
 */
class JSONTextTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    /**
     * @var string
     */
    protected $fixture = [
        'indexed' => '["great wall", "ford", "trabant", "oldsmobile", "buick", "vauxhall", "morris"]',
        'hashed' => '{"chinese":"great wall","american":["buick","oldsmobile","ford"],"british":["vauxhall","morris"]}',
        'invalid' => '{"chinese":"great wall","american":["buick","oldsmobile","ford"],"british":["vauxhall","morris]',
        'nested' => '{"cars":{"american":["buick","oldsmobile"],"british":["vauxhall","morris"]},"planes":{"russian":["antonov","mig"],"french":"airbus"}}',
        'multiple' => '{"cars":{"american":["buick","oldsmobile"],"british":["vauxhall","morris"]},"planes":{"british":"airbus","french":"airbus"}}',
        'empty' => ''
    ];
    
    public function testgetValueAsIterable()
    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['invalid']);
        $this->setExpectedException('JSONTextException');
        $this->assertEquals(['chinese' => 'great wall'], $field->getValueAsIterable());

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $this->assertEquals([], $field->getValueAsIterable());
    }

    public function testFirst_AsArray()

    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('array');
        $this->assertEquals([0 => 'great wall'], $field->first());

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('array');
        $this->assertInternalType('array', $field->first());
        $this->assertCount(0, $field->first());
    }

    public function testFirst_AsJson()

    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('json');
        $this->assertEquals('["great wall"]', $field->first());

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('json');
        $this->assertInternalType('string', $field->first());
        $this->assertEquals('[]', $field->first());
    }

    public function testLast_AsArray()

    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('array');
        $this->assertEquals([6 => 'morris'], $field->last());

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('array');
        $this->assertInternalType('array', $field->first());
        $this->assertCount(0, $field->first());
    }

    public function testLast_AsJson()

    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('json');
        $this->assertEquals('{"6":"morris"}', $field->last());

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('json');
        $this->assertInternalType('string', $field->first());
        $this->assertEquals('[]', $field->first());
    }

    public function testNth_AsArray()
    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('array');
        $this->assertEquals([0 => 'great wall'], $field->nth(0));
        $this->assertEquals([2 => 'trabant'], $field->nth(2));

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('array');
        $this->assertInternalType('array', $field->first());
        $this->assertCount(0, $field->first());

        $this->setExpectedException('JSONTextException');
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['hashed']);
        $field->setReturnType('array');
        $this->assertEquals(['british' => ['vauxhall', 'morris']], $field->nth('2'));
    }

    public function testNth_AsJson()
    {
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['indexed']);
        $field->setReturnType('json');
        $this->assertEquals('["great wall"]', $field->nth(0));
        $this->assertEquals('{"2":"trabant"}', $field->nth(2));

        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('json');
        $this->assertInternalType('string', $field->first());
        $this->assertEquals('[]', $field->first());

        $this->setExpectedException('JSONTextException');
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['hashed']);
        $field->setReturnType('json');
        $this->assertEquals('{"british":["vauxhall","morris"]}', $field->nth('2'));
    }

    /**
     * Tests query() by means of the integer Postgres operator: ->
     */
    public function testquery_AsInt_AsArray()
    {
        // Hashed
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['hashed']);
        $field->setReturnType('array');
        
        $this->assertEquals(['british' => ['vauxhall', 'morris']], $field->query('->', 5));
        $this->assertEquals(['american' => ['buick', 'oldsmobile', 'ford']], $field->query('->', 1));
        $this->assertEquals([], $field->query('->', '6')); // strict handling

        // Empty
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('array');
        $this->assertEquals([], $field->query('->', 42));

        // Nested
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['nested']);
        $field->setReturnType('array');
        
        $this->assertEquals(['planes' => ['russian' => ['antonov', 'mig'], 'french' => 'airbus']], $field->query('->', 7));
        $this->assertEquals([], $field->query('->', '7')); // Attempt to match a string using the int matcher 
        $this->assertEquals([0 => 'buick'], $field->query('->', 2));
    }

    /**
     * Tests query() by means of the string Postgres operator: ->>
     */
    public function testquery_AsStr_AsArray()
    {
        // Hashed
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['hashed']);
        $field->setReturnType('array');

        $this->assertEquals(['british' => ['vauxhall', 'morris']], $field->query('->>', 'british'));
        $this->assertEquals([], $field->query('->', '6')); // strict handling

        // Empty
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['empty']);
        $field->setReturnType('array');
        $this->assertEquals([], $field->query('->>', 'british'));

        // Nested
        $field = JSONText::create('MyJSON');
        $field->setValue($this->fixture['nested']);
        $field->setReturnType('array');

        $this->assertEquals(['planes' => ['russian' => ['antonov', 'mig'], 'french' => 'airbus']], $field->query('->>', 'planes'));
        $this->assertEquals([], $field->query('->', '7')); // Attempt to match a string using the int matcher
    }

}


1		<?php
2
3		/**
4		* @package silverstripe-jsontext
5		* @subpackage fields
6		* @author Russell Michell <[email protected]>
7		*/
8		class JSONTextTest extends SapphireTest
		0 ignored issues – show Coding Style Compatibility introduced 2016-06-10 04:11 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9		{
10		/**
11		* @var string
12		*/
13		protected $fixture = [
14		'indexed' => '["great wall", "ford", "trabant", "oldsmobile", "buick", "vauxhall", "morris"]',
15		'hashed' => '{"chinese":"great wall","american":["buick","oldsmobile","ford"],"british":["vauxhall","morris"]}',
16		'invalid' => '{"chinese":"great wall","american":["buick","oldsmobile","ford"],"british":["vauxhall","morris]',
17		'nested' => '{"cars":{"american":["buick","oldsmobile"],"british":["vauxhall","morris"]},"planes":{"russian":["antonov","mig"],"french":"airbus"}}',
18		'multiple' => '{"cars":{"american":["buick","oldsmobile"],"british":["vauxhall","morris"]},"planes":{"british":"airbus","french":"airbus"}}',
19		'empty' => ''
20		];
21
22		public function testgetValueAsIterable()
23		{
24		$field = JSONText::create('MyJSON');
25		$field->setValue($this->fixture['invalid']);
26		$this->setExpectedException('JSONTextException');
27		$this->assertEquals(['chinese' => 'great wall'], $field->getValueAsIterable());
28
29		$field = JSONText::create('MyJSON');
30		$field->setValue($this->fixture['empty']);
31		$this->assertEquals([], $field->getValueAsIterable());
32		}
33
34	View Code Duplication	public function testFirst_AsArray()
		0 ignored issues – show Duplication introduced 2016-06-10 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$field = JSONText::create('MyJSON');
37		$field->setValue($this->fixture['indexed']);
38		$field->setReturnType('array');
39		$this->assertEquals([0 => 'great wall'], $field->first());
40
41		$field = JSONText::create('MyJSON');
42		$field->setValue($this->fixture['empty']);
43		$field->setReturnType('array');
44		$this->assertInternalType('array', $field->first());
45		$this->assertCount(0, $field->first());
46		}
47
48	View Code Duplication	public function testFirst_AsJson()
		0 ignored issues – show Duplication introduced 2016-06-10 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		$field = JSONText::create('MyJSON');
51		$field->setValue($this->fixture['indexed']);
52		$field->setReturnType('json');
53		$this->assertEquals('["great wall"]', $field->first());
54
55		$field = JSONText::create('MyJSON');
56		$field->setValue($this->fixture['empty']);
57		$field->setReturnType('json');
58		$this->assertInternalType('string', $field->first());
59		$this->assertEquals('[]', $field->first());
60		}
61
62	View Code Duplication	public function testLast_AsArray()
		0 ignored issues – show Duplication introduced 2016-06-10 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		{
64		$field = JSONText::create('MyJSON');
65		$field->setValue($this->fixture['indexed']);
66		$field->setReturnType('array');
67		$this->assertEquals([6 => 'morris'], $field->last());
68
69		$field = JSONText::create('MyJSON');
70		$field->setValue($this->fixture['empty']);
71		$field->setReturnType('array');
72		$this->assertInternalType('array', $field->first());
73		$this->assertCount(0, $field->first());
74		}
75
76	View Code Duplication	public function testLast_AsJson()
		0 ignored issues – show Duplication introduced 2016-06-10 04:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		$field = JSONText::create('MyJSON');
79		$field->setValue($this->fixture['indexed']);
80		$field->setReturnType('json');
81		$this->assertEquals('{"6":"morris"}', $field->last());
82
83		$field = JSONText::create('MyJSON');
84		$field->setValue($this->fixture['empty']);
85		$field->setReturnType('json');
86		$this->assertInternalType('string', $field->first());
87		$this->assertEquals('[]', $field->first());
88		}
89
90		public function testNth_AsArray()
91		{
92		$field = JSONText::create('MyJSON');
93		$field->setValue($this->fixture['indexed']);
94		$field->setReturnType('array');
95		$this->assertEquals([0 => 'great wall'], $field->nth(0));
96		$this->assertEquals([2 => 'trabant'], $field->nth(2));
97
98		$field = JSONText::create('MyJSON');
99		$field->setValue($this->fixture['empty']);
100		$field->setReturnType('array');
101		$this->assertInternalType('array', $field->first());
102		$this->assertCount(0, $field->first());
103
104		$this->setExpectedException('JSONTextException');
105		$field = JSONText::create('MyJSON');
106		$field->setValue($this->fixture['hashed']);
107		$field->setReturnType('array');
108		$this->assertEquals(['british' => ['vauxhall', 'morris']], $field->nth('2'));
109		}
110
111		public function testNth_AsJson()
112		{
113		$field = JSONText::create('MyJSON');
114		$field->setValue($this->fixture['indexed']);
115		$field->setReturnType('json');
116		$this->assertEquals('["great wall"]', $field->nth(0));
117		$this->assertEquals('{"2":"trabant"}', $field->nth(2));
118
119		$field = JSONText::create('MyJSON');
120		$field->setValue($this->fixture['empty']);
121		$field->setReturnType('json');
122		$this->assertInternalType('string', $field->first());
123		$this->assertEquals('[]', $field->first());
124
125		$this->setExpectedException('JSONTextException');
126		$field = JSONText::create('MyJSON');
127		$field->setValue($this->fixture['hashed']);
128		$field->setReturnType('json');
129		$this->assertEquals('{"british":["vauxhall","morris"]}', $field->nth('2'));
130		}
131
132		/**
133		* Tests query() by means of the integer Postgres operator: ->
134		*/
135		public function testquery_AsInt_AsArray()
136		{
137		// Hashed
138		$field = JSONText::create('MyJSON');
139		$field->setValue($this->fixture['hashed']);
140		$field->setReturnType('array');
141
142		$this->assertEquals(['british' => ['vauxhall', 'morris']], $field->query('->', 5));
143		$this->assertEquals(['american' => ['buick', 'oldsmobile', 'ford']], $field->query('->', 1));
144		$this->assertEquals([], $field->query('->', '6')); // strict handling
145
146		// Empty
147		$field = JSONText::create('MyJSON');
148		$field->setValue($this->fixture['empty']);
149		$field->setReturnType('array');
150		$this->assertEquals([], $field->query('->', 42));
151
152		// Nested
153		$field = JSONText::create('MyJSON');
154		$field->setValue($this->fixture['nested']);
155		$field->setReturnType('array');
156
157		$this->assertEquals(['planes' => ['russian' => ['antonov', 'mig'], 'french' => 'airbus']], $field->query('->', 7));
158		$this->assertEquals([], $field->query('->', '7')); // Attempt to match a string using the int matcher
159		$this->assertEquals([0 => 'buick'], $field->query('->', 2));
160		}
161
162		/**
163		* Tests query() by means of the string Postgres operator: ->>
164		*/
165		public function testquery_AsStr_AsArray()
166		{
167		// Hashed
168		$field = JSONText::create('MyJSON');
169		$field->setValue($this->fixture['hashed']);
170		$field->setReturnType('array');
171
172		$this->assertEquals(['british' => ['vauxhall', 'morris']], $field->query('->>', 'british'));
173		$this->assertEquals([], $field->query('->', '6')); // strict handling
174
175		// Empty
176		$field = JSONText::create('MyJSON');
177		$field->setValue($this->fixture['empty']);
178		$field->setReturnType('array');
179		$this->assertEquals([], $field->query('->>', 'british'));
180
181		// Nested
182		$field = JSONText::create('MyJSON');
183		$field->setValue($this->fixture['nested']);
184		$field->setReturnType('array');
185
186		$this->assertEquals(['planes' => ['russian' => ['antonov', 'mig'], 'french' => 'airbus']], $field->query('->>', 'planes'));
187		$this->assertEquals([], $field->query('->', '7')); // Attempt to match a string using the int matcher
188		}
189
190		}
191

phptek / silverstripe-jsontext

Push — master ( cb9664...d0d98a )

JSONTextTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like