JSONTextIntegrationTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	75
Duplicated Lines	64 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	testSetValueOnNestedArray()	24	24	1
B	testSetValueOnUnNestedArray()	24	24	1

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <russ@theruss.com>
 */

use JSONText\Fields;
use JSONText\Exceptions;

class JSONTextIntegrationTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    
    /**
     * @var string
     */
    protected static $fixture_file = '/tests/fixtures/yml/MyAwesomeJSONModel.yml';

    /**
     * Modifies fixtures property to be able to run on PHP <5.6 without use of constant in class property which 5.6+ allows
     */
    public function __construct()
    {
        self::$fixture_file = MODULE_DIR . '/tests/fixtures/yml/MyAwesomeJSONModel.yml';
    }

    /**
     * Tests JSONText::setValue() by means of a simple JSONPath expression operating on a nested JSON array
     * on a saved DataObject record.
     */
    public function testSetValueOnNestedArray()

This method seems to be duplicated in your project.

    {
        $model = $this->objFromFixture('MyAwesomeJSONModel', 'json-as-object');
        $expression = '$.cars.american.[0]';
        $field = $model->dbObject('MyJSON');
        
        // What's the value at $expression now? (JSON as return type is the default)
        $this->assertEquals('["buick"]', $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

        
        // How about now?
        $field->setValue('ford', null, $expression);
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals('["ford"]', $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

        // And now? (With chaining)

37% of this comment could be valid code. Did you maybe forget this after debugging?

        $field
            ->setValue('chrysler', null, $expression)
            ->setReturnType('array');

        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals(['chrysler'], $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

    }

    /**
     * Tests JSONText::setValue() by means of a simple JSONPath expression operating on a simple, un-nested JSON array
     * on a saved DataObject record.
     */
    public function testSetValueOnUnNestedArray()

This method seems to be duplicated in your project.

    {
        $model = $this->objFromFixture('MyAwesomeJSONModel', 'json-as-array');
        $expression = '$.[0]';
        $field = $model->dbObject('MyJSON');

        // What's the value at $expression now? (JSON as return type is the default)
        $this->assertEquals('["buick"]', $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

        // How about now?
        $field->setValue('ford', null, $expression);
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals('["ford"]', $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

        
        // And now? (With chaining)

37% of this comment could be valid code. Did you maybe forget this after debugging?

        $field
            ->setValue('chrysler', null, $expression)
            ->setReturnType('array');
        
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals(['chrysler'], $field->query($expression));

The method assertEquals() does not seem to exist on object<JSONTextIntegrationTest>.

    }

}

/**
 * @package silverstripe-jsontext
 */
class MyAwesomeJSONModel extends DataObject

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'MyJSON' => '\JSONText\Fields\JSONText'
    ];
}