JSONTextTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	56
Duplicated Lines	37.5 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	18
Bugs	4	Features	7

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testIsValidExpression()	10	10	1
A	testIsValidJson()	0	16	1
A	testIsValidDBValue()	11	11	1

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <russ@theruss.com>
 */

use JSONText\Fields\JSONText;

class JSONTextTest extends SapphireTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @todo There are a ton more permutations of a JSONPath regex
     * See the walk() method in JSONStore
     */
    public function testIsValidExpression()

This method seems to be duplicated in your project.

    {
        $field = JSONText::create('MyJSON');
        
        $this->assertTrue($field->isValidExpression('$..'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidExpression('$.[2]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidExpression('$.cars.american[*]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidExpression('$'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidExpression('$[2]'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

    }

    /**
     * @return void
     */
    public function testIsValidJson()
    {
        $field = JSONText::create('MyJSON');

        $this->assertFalse($field->isValidJson(''));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('true'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('false'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidJson('null'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidJson("['one']"));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidJson('["one]'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidJson('{{{'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('[]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('["one"]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('["one","two"]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('{"cars":{"american":["buick","oldsmobile"]}}'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

    }


    /**
     * Ordinarily we can just use !is_null(json_decode($json)) but SS allows empty strings passed to setValue() so we need
     * to allow otherwise invalid JSON by means of an optional 2nd param
     *
     * @return void
     */
    public function testIsValidDBValue()

This method seems to be duplicated in your project.

    {
        $field = JSONText::create('MyJSON');
        
        $this->assertFalse($field->isValidDBValue('true'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidDBValue('false'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertFalse($field->isValidDBValue('null'));

The method assertFalse() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidDBValue(''));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('["one","two"]'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

        $this->assertTrue($field->isValidJson('{"cars":{"american":["buick","oldsmobile"]}}'));

The method assertTrue() does not seem to exist on object<JSONTextTest>.

    }
}