PostgresJSONBackend::matchOnPath() - Code Metrics - Inspection of "Updated docs." - phptek/silverstripe-jsontext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d18b4...301d75 )

by Russell

created 2016-06-21 20:58 UTC

PostgresJSONBackend::matchOnPath() D

↳ Parent: PostgresJSONBackend

Complexity

Conditions	10
Paths	6

Size

Total Lines	36
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	36
rs	4.8196
cc	10
eloc	21
nc	6
nop	0

How to fix Complexity

<?php

/**
 * DB backend for use with a Postgres RDBMS like JSON querying syntax.
 * 
 * @package silverstripe-jsontext
 * @subpackage models
 * @author Russell Michell <[email protected]>
 * @see {@link JSONBackend}
 * @see https://github.com/Peekmo/JsonPath/blob/master/tests/JsonStoreTest.php
 * @see http://goessner.net/articles/JsonPath/
 */

namespace JSONText\Backends;

use JSONText\Exceptions\JSONTextException;
use JSONText\Fields\JSONText;

class PostgresJSONBackend extends JSONBackend
{
    /**
     * @inheritdoc
     */
    public function matchOnInt()

    {
        if (!is_int($this->operand)) {
            $msg = 'Non-integer passed to: ' . __FUNCTION__;
            throw new JSONTextException($msg);
        }
        
        $expr = '$.[' . $this->operand . ']';
        $fetch = $this->jsonText->getJSONStore()->get($expr);
        $vals = array_values($fetch);
        
        if (isset($vals[0])) {
            return [$this->operand => $vals[0]];
        }

        return [];
    }

    /**
     * @inheritdoc
     */
    public function matchOnStr()

    {
        if (!is_string($this->operand)) {
            $msg = 'Non-string passed to: ' . __FUNCTION__;
            throw new JSONTextException($msg);
        }
        
        $expr = '$..' . $this->operand;
        $fetch = $this->jsonText->getJSONStore()->get($expr);
        $vals = array_values($fetch);

        if (isset($vals[0])) {
            return [$this->operand => $vals[0]];
        }

        return [];
    }

    /**
     * @inheritdoc
     */
    public function matchOnPath()
    {
        if (!is_string($this->operand) || !$this->jsonText->isJson($this->operand)) {
            $msg = 'Invalid JSON passed as operand on RHS.';
            throw new JSONTextException($msg);
        }
        
        $operandAsArray = $this->jsonText->toArray($this->operand);
        
        // Empty is OK..could've been accidental...
        if (!count($operandAsArray)) {
            return [];
        }

        $keys = array_keys($operandAsArray);
        $vals = array_values($operandAsArray);
        if (count($keys) >1 || count($vals) >1) {
            $msg = 'Sorry. I can\'t handle complex operands.';
            throw new JSONTextException($msg);
        }

        $source = $this->jsonText->getStoreAsArray();
        $sourceAsIterator = new \RecursiveIteratorIterator(
            new \RecursiveArrayIterator($source),
            \RecursiveIteratorIterator::SELF_FIRST
        );
        
        $data = [];
        foreach ($sourceAsIterator as $sourceKey => $sourceVal) {
            if ($keys[0] === $sourceKey && is_array($sourceVal) && !empty($sourceVal[$vals[0]])) {
                $data[] = $sourceVal[$vals[0]];
            }
        }

        return $data;
    }
    
}


1		<?php
2
3		/**
4		* DB backend for use with a Postgres RDBMS like JSON querying syntax.
5		*
6		* @package silverstripe-jsontext
7		* @subpackage models
8		* @author Russell Michell <[email protected]>
9		* @see {@link JSONBackend}
10		* @see https://github.com/Peekmo/JsonPath/blob/master/tests/JsonStoreTest.php
11		* @see http://goessner.net/articles/JsonPath/
12		*/
13
14		namespace JSONText\Backends;
15
16		use JSONText\Exceptions\JSONTextException;
17		use JSONText\Fields\JSONText;
18
19		class PostgresJSONBackend extends JSONBackend
20		{
21		/**
22		* @inheritdoc
23		*/
24	View Code Duplication	public function matchOnInt()
		0 ignored issues – show Duplication introduced 2016-06-21 21:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		if (!is_int($this->operand)) {
27		$msg = 'Non-integer passed to: ' . __FUNCTION__;
28		throw new JSONTextException($msg);
29		}
30
31		$expr = '$.[' . $this->operand . ']';
32		$fetch = $this->jsonText->getJSONStore()->get($expr);
33		$vals = array_values($fetch);
34
35		if (isset($vals[0])) {
36		return [$this->operand => $vals[0]];
37		}
38
39		return [];
40		}
41
42		/**
43		* @inheritdoc
44		*/
45	View Code Duplication	public function matchOnStr()
		0 ignored issues – show Duplication introduced 2016-06-21 21:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		if (!is_string($this->operand)) {
48		$msg = 'Non-string passed to: ' . __FUNCTION__;
49		throw new JSONTextException($msg);
50		}
51
52		$expr = '$..' . $this->operand;
53		$fetch = $this->jsonText->getJSONStore()->get($expr);
54		$vals = array_values($fetch);
55
56		if (isset($vals[0])) {
57		return [$this->operand => $vals[0]];
58		}
59
60		return [];
61		}
62
63		/**
64		* @inheritdoc
65		*/
66		public function matchOnPath()
67		{
68		if (!is_string($this->operand) \|\| !$this->jsonText->isJson($this->operand)) {
69		$msg = 'Invalid JSON passed as operand on RHS.';
70		throw new JSONTextException($msg);
71		}
72
73		$operandAsArray = $this->jsonText->toArray($this->operand);
74
75		// Empty is OK..could've been accidental...
76		if (!count($operandAsArray)) {
77		return [];
78		}
79
80		$keys = array_keys($operandAsArray);
81		$vals = array_values($operandAsArray);
82		if (count($keys) >1 \|\| count($vals) >1) {
83		$msg = 'Sorry. I can\'t handle complex operands.';
84		throw new JSONTextException($msg);
85		}
86
87		$source = $this->jsonText->getStoreAsArray();
88		$sourceAsIterator = new \RecursiveIteratorIterator(
89		new \RecursiveArrayIterator($source),
90		\RecursiveIteratorIterator::SELF_FIRST
91		);
92
93		$data = [];
94		foreach ($sourceAsIterator as $sourceKey => $sourceVal) {
95		if ($keys[0] === $sourceKey && is_array($sourceVal) && !empty($sourceVal[$vals[0]])) {
96		$data[] = $sourceVal[$vals[0]];
97		}
98		}
99
100		return $data;
101		}
102
103		}
104

phptek / silverstripe-jsontext

Push — master ( 9d18b4...301d75 )

PostgresJSONBackend::matchOnPath() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like