JSONTextQueryTest::testQueryWithMatchOnPath() - Code Metrics - Inspection of "Updated docs." - phptek/silverstripe-jsontext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9d18b4...301d75 )

by Russell

created 2016-06-21 20:58 UTC

JSONTextQueryTest::testQueryWithMatchOnPath() B

↳ Parent: JSONTextQueryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	139
Code Lines	77

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	139
rs	8.2857
cc	1
eloc	77
nc	1
nop	0

How to fix Long Method

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <[email protected]>
 * @todo Add tests where source data is a JSON array, not just a JSON object
 * @todo Split tests into discreet types
 * @todo $this->clearFixtures(); in setUp()
 * @todo Use same source data instead of repeating for each test
 * @todo See the PHPUnit @dataProvider annotaton ala
 * 
 *
 */

/**
 * @dataProvider additionProvider
 */
/*public function testAdd($a, $b, $expected)

{
    $this->assertEquals($expected, $a + $b);
}

public function additionProvider()
{
    return [
        [0, 0, 0],
        [0, 1, 1],
        [1, 0, 1],
        [1, 1, 3]
    ];
}*/

use JSONText\Fields;
use JSONText\Exceptions;

class JSONTextQueryTest extends SapphireTest
namespace YourVendor;

class YourClass { }
{
    /**
     * @var array
     */
    protected $fixtures = [
        'array'     => 'tests/fixtures/json/array.json',
        'object'    => 'tests/fixtures/json/object.json',
        'invalid'   => 'tests/fixtures/json/invalid.json'
    ];

    /**
     * JSONTextTest constructor.
     * 
     * Modify fixtures property to be able to run on PHP <5.6 without use of constant in class property which 5.6+ allows
     */
    public function __construct()
    {
        foreach($this->fixtures as $name => $path) {

            $this->fixtures[$name] = MODULE_DIR . '/' . $path;
        }
    }

    /**
     * Tests query() by means of the integer Postgres Int match operator: '->'
     * 
     * @todo Use same source data instead of repeating..
     */
    public function testQueryWithMatchOnInt()
    {
        // Data Source: Array
        // Return Type: ARRAY
        // Operator: "->" (Int)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue($this->getFixture('array'));
        $this->assertEquals([2 => 'trabant'], $field->query('->', 2));

        
        // Data Source: Array
        // Return Type: JSON
        // Operator: "->" (Int)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('json');
        $field->setValue($this->getFixture('array'));
        $this->assertEquals('{"2":"trabant"}', $field->query('->', 2));

        $this->assertEquals('{"5":101}', $field->query('->', 5));

        
        // Data Source: Array
        // Return Type: SILVERSTRIPE
        // Operator: "->" (Int)
        // SS Type: Float
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->query('->', 3));

        $this->assertInstanceOf('Float', $field->query('->', 3)[3]);

        $this->assertEquals(44.6, $field->query('->', 3)[3]->getValue());


        // Data Source: Array
        // Return Type: SILVERSTRIPE
        // Operator: "->" (Int)
        // SS Type: Boolean
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->query('->', 1));

        $this->assertInstanceOf('Boolean', $field->query('->', 1)[1]);

        $this->assertEquals(1, $field->query('->', 1)[1]->getValue());


        // Data Source: Array
        // Return Type: SILVERSTRIPE
        // Operator: "->" (Int)
        // SS Type: Int
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->query('->', 5));

        $this->assertInstanceOf('Int', $field->query('->', 5)[5]);

        $this->assertEquals(101, $field->query('->', 5)[5]->getValue());


        // Data Source: Array
        // Return Type: SILVERSTRIPE
        // Operator: "->" (Int)
        // SS Type: Varchar
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->query('->', 4));

        $this->assertInstanceOf('Varchar', $field->query('->', 4)[4]);

        $this->assertEquals('buick', $field->query('->', 4)[4]->getValue());


        // Test: Empty #1
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertInternalType('array', $field->query('->', 3));

        $this->assertCount(0, $field->query('->', 3));


        // Test: Empty #2
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('["morris"]');
        $this->assertEquals([], $field->query('->', 17));


        // Test: Invalid #1
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('["trabant"]');
        $this->assertEquals([], $field->query('->', 1));


        // Test: Invalid #2
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('{');
        $this->setExpectedException('\JSONText\Exceptions\JSONTextException');

        $field->query('->', 3);
    }

    /**
     * Tests query() by means of the integer Postgres String match operator: '->>'
     */
    public function testQueryWithMatchOnStr()
    {
        // Data Source: Object
        // Return Type: ARRAY
        // Operator: "->>" (String)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals(['Subaru' => 'Impreza'], $field->query('->>', 'Subaru'));

        $this->assertEquals(

            ['japanese' => ['fast' => ['Subaru' => 'Impreza'], 'slow' => ['Honda' => 'Civic']]],
            $field->query('->>', 'japanese')
        );

        // Data Source: Object
        // Return Type: JSON
        // Operator: "->>" (String)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('json');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals('{"Subaru":"Impreza"}', $field->query('->>', 'Subaru'));

        $this->assertEquals(

            '{"japanese":{"fast":{"Subaru":"Impreza"},"slow":{"Honda":"Civic"}}}',
            $field->query('->>', 'japanese')
        );

        // Data Source: Object
        // Return Type: SilverStripe
        // Operator: "->>" (String)
        // SS Type: Varchar
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('->>', 'Subaru'));

        $this->assertInstanceOf('Varchar', $field->query('->>', 'Subaru')['Subaru']);

        $this->assertEquals('Impreza', $field->query('->>', 'Subaru')['Subaru']->getValue());


        // Data Source: Object
        // Return Type: SilverStripe
        // Operator: "->>" (String)
        // SS Type: Boolean
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('->>', 'beer tastes good'));

        $this->assertInstanceOf('Boolean', $field->query('->>', 'beer tastes good')['beer tastes good']);

        $this->assertEquals(1, $field->query('->>', 'beer tastes good')['beer tastes good']->getValue());


        // Data Source: Object
        // Return Type: SilverStripe
        // Operator: "->>" (String)
        // SS Type: Float
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('->>', 'how sure are you'));

        $this->assertInstanceOf('Float', $field->query('->>', 'how sure are you')['how sure are you']);

        $this->assertEquals(99.99, $field->query('->>', 'how sure are you')['how sure are you']->getValue());


        // Data Source: Object
        // Return Type: SilverStripe
        // Operator: "->>" (String)
        // SS Type: Int
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('->>', 'how high'));

        $this->assertInstanceOf('Int', $field->query('->>', 'how high')['how high']);

        $this->assertEquals(6, $field->query('->>', 'how high')['how high']->getValue());


        // Data Source: Object
        // Return Type: SilverStripe
        // Operator: "->>" (String)
        // SS Type: N/A Nested sub-array example, expect an array
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('->>', 'planes')['planes']);

        $this->assertInternalType('array', $field->query('->>', 'planes')['planes']['russian']);

        $this->assertCount(2, $field->query('->>', 'planes')['planes']['russian']);

        $this->assertInstanceOf('Varchar', $field->query('->>', 'planes')['planes']['russian'][0]);

        $this->assertInstanceOf('Varchar', $field->query('->>', 'planes')['planes']['russian'][1]);


        // Test: Empty #1
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertInternalType('array', $field->query('->>', 'planes'));

        $this->assertCount(0, $field->query('->', 3));


        // Test: Empty #2
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('["morris"]');
        $this->assertEquals([], $field->query('->', 17));


        // Test: Invalid #1
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('["trabant"]');
        $this->assertEquals([], $field->query('->', 1));


        // Test: Invalid #2
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('{');
        $this->setExpectedException('\JSONText\Exceptions\JSONTextException');

        $field->query('->', 3);
    }

    /**
     * Tests query() by means of the Postgres path-match operator: '#>'
     */
    public function testQueryWithMatchOnPath()
    {
        // Data Source: Object
        // Return Type: ARRAY
        // Operator: "#>" (Path)

        // Expect: Array due to duplicate keys in different parts of the source data
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals(

            [['Subaru' => 'Impreza'],['Kawasaki' => 'KR1S250']],
            $field->query('#>', '{"japanese":"fast"}')
        );

        // Data Source: Object
        // Return Type: JSON
        // Operator: "#>" (Path)

        // Expect: Array due to duplicate keys in different parts of the source data
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('json');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals(

            '[{"Subaru":"Impreza"},{"Kawasaki":"KR1S250"}]',
            $field->query('#>', '{"japanese":"fast"}')
        );

        // Data Source: Object
        // Return Type: SILVERSTRIPE
        // Operator: "#>" (Path)

        // Expect: Array due to duplicate keys in different parts of the source data
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('#>', '{"japanese":"fast"}'));

        $this->assertCount(2, $field->query('#>', '{"japanese":"fast"}'));

        
        $one = $field->query('#>', '{"japanese":"fast"}')[0];
        $two = $field->query('#>', '{"japanese":"fast"}')[1];
        
        $this->assertInternalType('array', $one);

        $this->assertInternalType('array', $two);

        $this->assertInstanceOf('Varchar', array_values($one)[0]);

        $this->assertInstanceOf('Varchar', array_values($two)[0]);

        $this->assertEquals('Impreza', array_values($one)[0]->getValue());

        $this->assertEquals('KR1S250', array_values($two)[0]->getValue());


        // Data Source: Object
        // Return Type: ARRAY
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals(['airbus'], $field->query('#>', '{"planes":"french"}'));


        // Data Source: Object
        // Return Type: JSON
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('json');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals('["airbus"]', $field->query('#>', '{"planes":"french"}'));


        // Data Source: Object
        // Return Type: SILVERSTRIPE
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion (Varchar)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertInternalType('array', $field->query('#>', '{"planes":"french"}'));

        $this->assertInstanceOf('Varchar', $field->query('#>', '{"planes":"french"}')[0]);

        $this->assertEquals('airbus', $field->query('#>', '{"planes":"french"}')[0]->getValue());


        // Data Source: Object
        // Return Type: SILVERSTRIPE
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion (Float)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        
        $res = $field->query('#>', '{"floats":"0"}');
        
        $this->assertInternalType('array', $res);

        $this->assertInternalType('array', $res[0]); // Why? Because value of "floats" key is a JSON array

        $this->assertInstanceOf('Float', array_values($res[0])[0]);

        $this->assertEquals(99.99, array_values($res[0])[0]->getValue());


        // Data Source: Object
        // Return Type: SILVERSTRIPE
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion (Int)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));

        $res = $field->query('#>', '{"ints":"0"}');

        $this->assertInternalType('array', $res);

        $this->assertInternalType('array', $res[0]); // Why? Because value of "floats" key is a JSON array

        $this->assertInstanceOf('Int', array_values($res[0])[1]);

        $this->assertEquals(6, array_values($res[0])[1]->getValue());


        // Data Source: Object
        // Return Type: SILVERSTRIPE
        // Operator: "#>" (Path)

        // Expect: Direct scalar comparison assertion (Boolean)
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));

        $res = $field->query('#>', '{"booleans":"0"}');

        $this->assertInternalType('array', $res);

        $this->assertInternalType('array', $res[0]); // Why? Because value of "booleans" key is a JSON array

        $this->assertInstanceOf('Boolean', array_values($res[0])[0]);

        $this->assertEquals(1, array_values($res[0])[0]->getValue());


        // #1 Empty source data
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertEquals([], $field->query('#>', '{"japanese":"fast"}'));


        // #2 JSON path not found
        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('object'));
        $this->assertNull($field->query('#>', '{"ints":"1"}')); // The "ints" key only has a single array as a value


        // #3 Invalid operand on RHS
        $this->setExpectedException('\JSONText\Exceptions\JSONTextException');

        $field = JSONText\Fields\JSONText::create('MyJSON');
        $field->setReturnType('array');
        $field->setValue($this->getFixture('object'));
        $this->assertEquals(['Kawasaki' => 'KR1S250'], $field->query('#>', '{"japanese":"fast"'));

    }
    
    /**
     * Get the contents of a fixture
     * 
     * @param string $fixture
     * @return string
     */
    private function getFixture($fixture)
    {
        $files = $this->fixtures;
        return file_get_contents($files[$fixture]);
    }

}


1			<?php
2
3			/**
4			* @package silverstripe-jsontext
5			* @subpackage fields
6			* @author Russell Michell <[email protected]>
7			* @todo Add tests where source data is a JSON array, not just a JSON object
8			* @todo Split tests into discreet types
9			* @todo $this->clearFixtures(); in setUp()
10			* @todo Use same source data instead of repeating for each test
11			* @todo See the PHPUnit @dataProvider annotaton ala
12			*
13			*
14			*/
15
16			/**
17			* @dataProvider additionProvider
18			*/
19			/*public function testAdd($a, $b, $expected)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-06-21 21:00 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
20			{
21			$this->assertEquals($expected, $a + $b);
22			}
23
24			public function additionProvider()
25			{
26			return [
27			[0, 0, 0],
28			[0, 1, 1],
29			[1, 0, 1],
30			[1, 1, 3]
31			];
32			}*/
33
34			use JSONText\Fields;
35			use JSONText\Exceptions;
36
37			class JSONTextQueryTest extends SapphireTest
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-21 21:00 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
38			{

phptek / silverstripe-jsontext

Push — master ( 9d18b4...301d75 )

JSONTextQueryTest::testQueryWithMatchOnPath() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like