JSONText\Backends\JSONBackend

Complexity

Total Complexity

4

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	5
Bugs	1	Features	3

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
	matchOnInt()	0	1	?
	matchOnStr()	0	1	?
	matchOnPath()	0	1	?
A	matchOnExpr()	0	16	3

<?php

/**
 * DB backend for use with the {@link JSONText} DB field. Allows us to use DB-specific JSON query syntax within
 * the module.
 * 
 * @package silverstripe-jsontext
 * @subpackage models
 * @author Russell Michell <russ@theruss.com>
 * @see https://github.com/Peekmo/JsonPath/blob/master/tests/JsonStoreTest.php
 * @see http://goessner.net/articles/JsonPath/
 */

namespace JSONText\Backends;

use JSONText\Exceptions\JSONTextException;
use JSONText\Fields\JSONText;

abstract class JSONBackend
{
    
    /**
     * @var string
     */
    protected $operand;

    /**
     * @var JSONText
     */
    protected $jsonText;

    /**
     * JSONBackend constructor.
     *
     * @param string $operand
     * @param JSONText $jsonText
     */
    public function __construct($operand, $jsonText)
    {
        $this->operand = $operand;
        $this->jsonText = $jsonText;
    }
    
    /**
     * Match on keys by INT. If >1 matches are found, an indexed array of all matches is returned.
     *
     * @return array
     * @throws JSONTextException
     */
    abstract public function matchOnInt();

    /**
     * Match on keys by STRING. If >1 matches are found, an indexed array of all matches is returned.
     *
     * @return array
     * @throws JSONTextException
     */
    abstract function matchOnStr();

It is generally recommended to explicitly declare the visibility for methods.

    /**
     * Match on RDBMS-specific path operator. If >1 matches are found, an indexed array of all matches is returned.
     *
     * @return array
     * @throws \JSONText\Exceptions\JSONTextException
     */
    abstract public function matchOnPath();

    /**
     * Match on JSONPath expression. If >1 matches are found, an indexed array of all matches is returned.
     *
     * @return array
     * @throws JSONTextException
     */
    public function matchOnExpr()
    {
        if (!is_string($this->operand)) {
            $msg = 'Non-string passed to: ' . __FUNCTION__;
            throw new JSONTextException($msg);
        }

        // Re-use existing field passed via constructor
        $expr = $this->operand;
        $fetch = $this->jsonText->getJSONStore()->get($expr);
        if (!$fetch) {

The expression $fetch of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        return $fetch;
    }
    
}