PostgresJSONBackend::matchOnPath() - Code Metrics - Inspection of "Merge pull request #12 from jakxnz/master" - phptek/silverstripe-jsontext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 190091...7bc446 )

by Russell

created 2018-04-29 09:19 UTC

PostgresJSONBackend::matchOnPath() D

↳ Parent: PostgresJSONBackend

Complexity

Conditions	10
Paths	6

Size

Total Lines	36
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	36
rs	4.8196
c	0
b	0
f	0
cc	10
eloc	21
nc	6
nop	0

How to fix Complexity

<?php

/**
 * JSONText database backend that encapsulates a Postgres-like syntax for JSON querying.
 * 
 * @package silverstripe-jsontext
 * @subpackage models
 * @author Russell Michell <[email protected]>
 * @see https://www.postgresql.org/docs/9.6/static/functions-json.html
 */

namespace PhpTek\JSONText\Backend;

use PhpTek\JSONText\Exception\JSONTextInvalidArgsException;

class PostgresJSONBackend extends JSONBackend
{
    /**
     * An array of acceptable operators for this backend.
     * 
     * @var array
     * @config
     */
    private static $allowed_operators = [

        'matchOnInt'    => '->',
        'matchOnStr'    => '->>',
        'matchOnPath'   => '#>'
    ];
    
    /**
     * @inheritdoc
     */
    public function matchOnInt()

    {
        if (!\is_int($this->operand)) {
            $msg = 'Non-integer passed to: ' . __FUNCTION__ . '()';
            throw new JSONTextInvalidArgsException($msg);
        }
        
        $expr = '$.[' . $this->operand . ']';
        $fetch = $this->jsonText->getJSONStore()->get($expr);
        $vals = \array_values($fetch);
        
        if (isset($vals[0])) {
            return [$this->operand => $vals[0]];
        }

        return [];
    }

    /**
     * @inheritdoc
     */
    public function matchOnStr()

    {
        if (!\is_string($this->operand)) {
            $msg = 'Non-string passed to: ' . __FUNCTION__ . '()';
            throw new JSONTextInvalidArgsException($msg);
        }
        
        $expr = '$..' . $this->operand;
        $fetch = $this->jsonText->getJSONStore()->get($expr);
        $vals = \array_values($fetch);

        if (isset($vals[0])) {
            return [$this->operand => $vals[0]];
        }

        return [];
    }

    /**
     * @inheritdoc
     */
    public function matchOnPath()
    {
        if (!\is_string($this->operand) || !$this->jsonText->isValidJson($this->operand)) {
            $msg = 'Invalid JSON passed as operand on RHS.';
            throw new JSONTextInvalidArgsException($msg);
        }
        
        $operandAsArray = $this->jsonText->toArray($this->operand);
        
        if (!\count($operandAsArray)) {
            return [];
        }

        $keys = \array_keys($operandAsArray);
        $vals = \array_values($operandAsArray);
        
        if (\count($keys) > 1 || \count($vals) > 1) {
            $msg = 'Sorry. I can\'t handle complex operands.';
            throw new JSONTextInvalidArgsException($msg);
        }

        $source = $this->jsonText->getStoreAsArray();
        $sourceAsIterator = new \RecursiveIteratorIterator(
            new \RecursiveArrayIterator($source),
            \RecursiveIteratorIterator::SELF_FIRST
        );
        
        $data = [];
        foreach ($sourceAsIterator as $sourceKey => $sourceVal) {
            if ($keys[0] === $sourceKey && is_array($sourceVal) && !empty($sourceVal[$vals[0]])) {
                $data[] = $sourceVal[$vals[0]];
            }
        }

        return $data;
    }
    
}


1		<?php
2
3		/**
4		* JSONText database backend that encapsulates a Postgres-like syntax for JSON querying.
5		*
6		* @package silverstripe-jsontext
7		* @subpackage models
8		* @author Russell Michell <[email protected]>
9		* @see https://www.postgresql.org/docs/9.6/static/functions-json.html
10		*/
11
12		namespace PhpTek\JSONText\Backend;
13
14		use PhpTek\JSONText\Exception\JSONTextInvalidArgsException;
15
16		class PostgresJSONBackend extends JSONBackend
17		{
18		/**
19		* An array of acceptable operators for this backend.
20		*
21		* @var array
22		* @config
23		*/
24		private static $allowed_operators = [
		0 ignored issues – show Unused Code introduced 2016-06-30 09:44 UTC by Report Bug Copy Issue Report The property `$allowed_operators` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
25		'matchOnInt' => '->',
26		'matchOnStr' => '->>',
27		'matchOnPath' => '#>'
28		];
29
30		/**
31		* @inheritdoc
32		*/
33	View Code Duplication	public function matchOnInt()
		0 ignored issues – show Duplication introduced 2018-04-10 00:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		if (!\is_int($this->operand)) {
36		$msg = 'Non-integer passed to: ' . __FUNCTION__ . '()';
37		throw new JSONTextInvalidArgsException($msg);
38		}
39
40		$expr = '$.[' . $this->operand . ']';
41		$fetch = $this->jsonText->getJSONStore()->get($expr);
42		$vals = \array_values($fetch);
43
44		if (isset($vals[0])) {
45		return [$this->operand => $vals[0]];
46		}
47
48		return [];
49		}
50
51		/**
52		* @inheritdoc
53		*/
54	View Code Duplication	public function matchOnStr()
		0 ignored issues – show Duplication introduced 2018-04-10 00:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		{
56		if (!\is_string($this->operand)) {
57		$msg = 'Non-string passed to: ' . __FUNCTION__ . '()';
58		throw new JSONTextInvalidArgsException($msg);
59		}
60
61		$expr = '$..' . $this->operand;
62		$fetch = $this->jsonText->getJSONStore()->get($expr);
63		$vals = \array_values($fetch);
64
65		if (isset($vals[0])) {
66		return [$this->operand => $vals[0]];
67		}
68
69		return [];
70		}
71
72		/**
73		* @inheritdoc
74		*/
75		public function matchOnPath()
76		{
77		if (!\is_string($this->operand) \|\| !$this->jsonText->isValidJson($this->operand)) {
78		$msg = 'Invalid JSON passed as operand on RHS.';
79		throw new JSONTextInvalidArgsException($msg);
80		}
81
82		$operandAsArray = $this->jsonText->toArray($this->operand);
83
84		if (!\count($operandAsArray)) {
85		return [];
86		}
87
88		$keys = \array_keys($operandAsArray);
89		$vals = \array_values($operandAsArray);
90
91		if (\count($keys) > 1 \|\| \count($vals) > 1) {
92		$msg = 'Sorry. I can\'t handle complex operands.';
93		throw new JSONTextInvalidArgsException($msg);
94		}
95
96		$source = $this->jsonText->getStoreAsArray();
97		$sourceAsIterator = new \RecursiveIteratorIterator(
98		new \RecursiveArrayIterator($source),
99		\RecursiveIteratorIterator::SELF_FIRST
100		);
101
102		$data = [];
103		foreach ($sourceAsIterator as $sourceKey => $sourceVal) {
104		if ($keys[0] === $sourceKey && is_array($sourceVal) && !empty($sourceVal[$vals[0]])) {
105		$data[] = $sourceVal[$vals[0]];
106		}
107		}
108
109		return $data;
110		}
111
112		}
113

phptek / silverstripe-jsontext

Push — master ( 190091...7bc446 )

PostgresJSONBackend::matchOnPath() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like