JSONTextExtensionTest

Complexity

Total Complexity

1

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	testExceptionThrownOnBeforeWrite()	0	16	1

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <russ@theruss.com>
 */

class JSONTextExtensionTest extends FunctionalTest

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var string
     */
    protected static $fixture_file = 'jsontext/tests/fixtures/yml/JSONTextExtension.yml';
    
    /**
     * Ensure our TestOnly DO's are usable as fixtures in the test DB
     * 
     * @var array
     */
	protected $extraDataObjects = [
		'JSONTextTestPage',
	];
    
    /**
     * Is an exception thrown when no POSTed vars are available for
     * non DB-backed fields declared on a SiteTree class?
     */
    public function testExceptionThrownOnBeforeWrite()
    {
        $member = $this->objFromFixture('Member', 'admin');
        $this->session()->inst_set('loggedInAs', $member->ID);
        $fixture = $this->objFromFixture('JSONTextTestPage', 'jsontext-text');

$fixture is not used, you could remove the assignment.

        
        $this->setExpectedException('\JSONText\Exceptions\JSONTextException', "FooField doesn't exist in POST data.");

The method setExpectedException() does not seem to exist on object<JSONTextExtensionTest>.

        
        $response = $this->post('admin/pages/edit/EditForm', [

$response is not used, you could remove the assignment.

            'Title' => 'Dummy',
            'URLSegment' => 'dummy',
			'action_save' => 1,
			'ID' => 44,
            'ParentID' => 1,
		]);
    }
}

class JSONTextTestPage extends Page implements TestOnly

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = [

The property $db is not used and could be removed.

        'MyJSON' => 'JSONText'
    ];
    
    private static $json_field_map = [

The property $json_field_map is not used and could be removed.

        'MyJSON' => ['FooField']
    ];
    
}