JSONTextIntegrationTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	87
Duplicated Lines	56.32 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	testSetValueOnNestedArray()	25	25	1
A	testSetValueOnUnNestedArray()	24	24	1

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <russ@theruss.com>
 */

use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\TestOnly;
use PhpTek\JSONText\Dev\Fixture\MyAwesomeJSONModel;

class JSONTextIntegrationTest extends SapphireTest
{
    /**
     * @var string
     */
    protected static $fixture_file;

    /**
     * Modifies fixtures property to be able to run on PHP <5.6 without use of constant in class property which 5.6+ allows
     */
    public function __construct()
    {
        $dir = realpath(__DIR__);
        
        self::$fixture_file = $dir . '/fixtures/yml/MyAwesomeJSONModel.yml';
        
        parent::__construct();
    }
    
    /**
     * Allows us the ability to scaffold DB records for {@link TestOnly} implementations.
     * @var array
     */
    protected static $extra_dataobjects = [
        MyAwesomeJSONModel::class
    ];

    /**
     * Tests JSONText::setValue() by means of a simple JSONPath expression operating on a nested JSON array
     * on a saved DataObject record.
     */
    public function testSetValueOnNestedArray()

This method seems to be duplicated in your project.

    {
        $model = $this->objFromFixture(MyAwesomeJSONModel::class, 'json-as-object');
        $expression = '$.cars.american.[0]';
        $field = $model->dbObject('MyJSON');

        // Primary assertion (JSON as return type is the default)
        $this->assertEquals('["buick"]', $field->query($expression));
        
        // How about now?
        $field->setValue('ford', null, $expression);
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals('["ford"]', $field->query($expression));

        // Secondary assertion
        $field
            ->setValue('chrysler', null, $expression)
            ->setReturnType('array');

        // With chaining
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals(['chrysler'], $field->query($expression));
    }

    /**
     * Tests JSONText::setValue() by means of a simple JSONPath expression operating on a simple, un-nested JSON array
     * on a saved DataObject record.
     */
    public function testSetValueOnUnNestedArray()

This method seems to be duplicated in your project.

    {
        $model = $this->objFromFixture(MyAwesomeJSONModel::class, 'json-as-array');
        $expression = '$.[0]';
        $field = $model->dbObject('MyJSON');

        // Primary assertion (JSON as return type is the default)
        $this->assertEquals('["buick"]', $field->query($expression));

        // Secondary assertion
        $field->setValue('ford', null, $expression);
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals('["ford"]', $field->query($expression));
        
        // With chaining
        $field
            ->setValue('chrysler', null, $expression)
            ->setReturnType('array');
        
        $model->setField('MyJSON', $field->getValue());
        $model->write();
        $this->assertEquals(['chrysler'], $field->query($expression));
    }

}