JSONTextBasicTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	162
Duplicated Lines	45.68 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	8	8	2
A	setUp()	0	6	1
A	testGetValueAsJSONStore()	0	7	1
A	testFirst()	33	33	1
A	testLast()	33	33	1
A	testNth()	0	33	1
A	getFixture()	0	5	1

<?php

/**
 * @package silverstripe-jsontext
 * @subpackage fields
 * @author Russell Michell <russ@theruss.com>
 * @todo Add 'object' fixture to each
 */

use PhpTek\JSONText\ORM\FieldType\JSONText;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\FieldType\DBVarchar;

class JSONTextBasicTest extends SapphireTest
{
    /**
     * @var array
     */
    protected $fixtures = [
        'array'     => 'fixtures/json/array.json',
        'object'    => 'fixtures/json/object.json'
    ];

    /**
     * @var \JSONText\ORM\FieldType\JSONText
     */
    protected $sut;

    /**
     * JSONTextTest constructor.
     *
     * Modifies fixtures property to be able to run on PHP <5.6 without use of constant in class property which 5.6+ allows
     */
    public function __construct()

This method seems to be duplicated in your project.

    {
        foreach($this->fixtures as $name => $path) {
            $this->fixtures[$name] = realpath(__DIR__) . '/' . $path;
        }
        
        parent::__construct();
    }

    /**
     * Setup the System Under Test for this test suite.
     */
    public function setUp()
    {
        parent::setUp();

        $this->sut = JSONText::create('MyJSON');

It seems like \PhpTek\JSONText\ORM\FieldType\JSONText::create('MyJSON') of type object<PhpTek\JSONText\ORM\FieldType\JSONText> is incompatible with the declared type object<JSONText\ORM\FieldType\JSONText> of property $sut.

    }

    public function testGetValueAsJSONStore()
    {
        $field = $this->sut;

        $field->setValue('');
        $this->assertEquals([], $field->getStoreAsArray());
    }

    public function testFirst()

This method seems to be duplicated in your project.

    {
        $field = $this->sut;

        // Test: Source data is simple JSON array
        // Return type: Array
        $field->setReturnType('array');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->first());
        $this->assertCount(1, $field->first());
        $this->assertEquals([0 => 'great wall'], $field->first());

        // Test: Source data is simple JSON array
        // Return type: JSON
        $field->setReturnType('json');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('string', $field->first());
        $this->assertEquals('["great wall"]', $field->first());

        // Test: Source data is simple JSON array
        // Return type: SilverStripe
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->first());
        $this->assertInstanceOf('\SilverStripe\ORM\FieldType\DBVarchar', $field->first()[0]);
        $this->assertEquals('great wall', $field->first()[0]->getValue());

        // Test: Empty
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertInternalType('array', $field->first());
        $this->assertCount(0, $field->first());
    }

    public function testLast()

This method seems to be duplicated in your project.

    {
        $field = $this->sut;

        // Test: Source data is simple JSON array
        // Return type: Array
        $field->setReturnType('array');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->last());
        $this->assertCount(1, $field->last());
        $this->assertEquals([6 => 33.3333], $field->last());

        // Test: Source data is simple JSON array
        // Return type: JSON
        $field->setReturnType('json');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('string', $field->last());
        $this->assertEquals('{"6":33.3333}', $field->last());

        // Test: Source data is simple JSON array
        // Return type: SilverStripe
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->last());
        $this->assertInstanceOf('\SilverStripe\ORM\FieldType\DBFloat', $field->last()[6]);
        $this->assertEquals(33.3333, $field->last()[6]->getValue());

        // Test: Empty
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertInternalType('array', $field->last());
        $this->assertCount(0, $field->last());
    }

    public function testNth()
    {
        $field = $this->sut;

        // Test: Source data is simple JSON array
        // Return type: Array
        $field->setReturnType('array');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->nth(1));
        $this->assertCount(1, $field->nth(1));
        $this->assertEquals([1 => true], $field->nth(1));

        // Test: Source data is simple JSON array
        // Return type: JSON
        $field->setReturnType('json');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('string', $field->nth(1));
        $this->assertEquals('{"1":true}', $field->nth(1));

        // Test: Source data is simple JSON array
        // Return type: SilverStripe
        $field->setReturnType('silverstripe');
        $field->setValue($this->getFixture('array'));
        $this->assertInternalType('array', $field->nth(1));
        $this->assertInstanceOf('\SilverStripe\ORM\FieldType\DBBoolean', $field->nth(1)[1]);
        $this->assertEquals(true, $field->nth(1)[1]->getValue());

        // Test: Empty
        $field->setReturnType('array');
        $field->setValue('');
        $this->assertInternalType('array', $field->nth(1));
        $this->assertCount(0, $field->nth(1));
    }

    /**
     * Get the contents of a fixture
     *
     * @param string $fixture
     * @return string
     */
    private function getFixture($fixture)
    {
        $files = $this->fixtures;
        return file_get_contents($files[$fixture]);
    }

}