Inspection of "Merges changes from 1.3.X into master" - phptal/PHPTAL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#51)

by Ben

created 2016-03-21 13:32 UTC

Status

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/Node.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/Comment.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/Element.php 1 patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@  discard block
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 
 /**
@@ -466,10 +466,10 @@  discard block
 block discarded – undo
             $nsattr = PHPTAL_Dom_Defs::getInstance()->getNamespaceAttribute($domattr->getNamespaceURI(), $domattr->getLocalName());
             if (array_key_exists($nsattr->getPriority(), $temp)) {
                 throw new PHPTAL_TemplateException(sprintf("Attribute conflict in < %s > '%s' cannot appear with '%s'",
-                               $this->qualifiedName,
-                               $key,
-                               $temp[$nsattr->getPriority()][0]->getNamespace()->getPrefix() . ':' . $temp[$nsattr->getPriority()][0]->getLocalName()
-                               ), $this->getSourceFile(), $this->getSourceLine());
+                                $this->qualifiedName,
+                                $key,
+                                $temp[$nsattr->getPriority()][0]->getNamespace()->getPrefix() . ':' . $temp[$nsattr->getPriority()][0]->getLocalName()
+                                ), $this->getSourceFile(), $this->getSourceLine());
             }
             $temp[$nsattr->getPriority()] = array($nsattr, $domattr);
         }

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/DocumentType.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/DocumentBuilder.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/XmlDeclaration.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/Text.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * You're probably not using PHPTAL class properly

Please login to merge, or discard this patch.

classes/PHPTAL/Dom/SaxXmlParser.php 1 patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@  discard block
 block discarded – undo
 <?php
 /**
- * PHPTAL templating engine
- *
- * PHP Version 5
- *
- * @category HTML
- * @package  PHPTAL
- * @author   Laurent Bedubourg <[email protected]>
- * @author   Kornel Lesiński <[email protected]>
- * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
- * @version  SVN: $Id$
- * @link     http://phptal.org/
- */
+     * PHPTAL templating engine
+     *
+     * PHP Version 5
+     *
+     * @category HTML
+     * @package  PHPTAL
+     * @author   Laurent Bedubourg <[email protected]>
+     * @author   Kornel Lesiński <[email protected]>
+     * @license  http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
+     * @version  SVN: $Id$
+     * @link     http://phptal.org/
+     */
 
 /**
  * Simple sax like xml parser for PHPTAL
@@ -60,23 +60,23 @@  discard block
 block discarded – undo
 
 
     static $state_names = array(
-      self::ST_ROOT => 'root node',
-      self::ST_TEXT => 'text',
-      self::ST_LT   => 'start of tag',
-      self::ST_TAG_NAME => 'tag name',
-      self::ST_TAG_CLOSE => 'closing tag',
-      self::ST_TAG_SINGLE => 'self-closing tag',
-      self::ST_TAG_ATTRIBUTES => 'tag',
-      self::ST_TAG_BETWEEN_ATTRIBUTE => 'tag attributes',
-      self::ST_CDATA => 'CDATA',
-      self::ST_COMMENT => 'comment',
-      self::ST_DOCTYPE => 'doctype',
-      self::ST_XMLDEC => 'XML declaration',
-      self::ST_PREPROC => 'preprocessor directive',
-      self::ST_ATTR_KEY => 'attribute name',
-      self::ST_ATTR_EQ => 'attribute value',
-      self::ST_ATTR_QUOTE => 'quoted attribute value',
-      self::ST_ATTR_VALUE => 'unquoted attribute value',
+        self::ST_ROOT => 'root node',
+        self::ST_TEXT => 'text',
+        self::ST_LT   => 'start of tag',
+        self::ST_TAG_NAME => 'tag name',
+        self::ST_TAG_CLOSE => 'closing tag',
+        self::ST_TAG_SINGLE => 'self-closing tag',
+        self::ST_TAG_ATTRIBUTES => 'tag',
+        self::ST_TAG_BETWEEN_ATTRIBUTE => 'tag attributes',
+        self::ST_CDATA => 'CDATA',
+        self::ST_COMMENT => 'comment',
+        self::ST_DOCTYPE => 'doctype',
+        self::ST_XMLDEC => 'XML declaration',
+        self::ST_PREPROC => 'preprocessor directive',
+        self::ST_ATTR_KEY => 'attribute name',
+        self::ST_ATTR_EQ => 'attribute value',
+        self::ST_ATTR_QUOTE => 'quoted attribute value',
+        self::ST_ATTR_VALUE => 'unquoted attribute value',
     );
 
     private $input_encoding;
@@ -381,15 +381,15 @@  discard block
 block discarded – undo
 
             // http://www.w3.org/International/questions/qa-forms-utf-8
             $match = '[\x09\x0A\x0D\x20-\x7F]'        // ASCII
-               . '|[\xC2-\xDF][\x80-\xBF]'            // non-overlong 2-byte
-               . '|\xE0[\xA0-\xBF][\x80-\xBF]'        // excluding overlongs
-               . '|[\xE1-\xEC\xEE\xEE][\x80-\xBF]{2}' // straight 3-byte (exclude FFFE and FFFF)
-               . '|\xEF[\x80-\xBE][\x80-\xBF]'        // straight 3-byte
-               . '|\xEF\xBF[\x80-\xBD]'               // straight 3-byte
-               . '|\xED[\x80-\x9F][\x80-\xBF]'        // excluding surrogates
-               . '|\xF0[\x90-\xBF][\x80-\xBF]{2}'     // planes 1-3
-               . '|[\xF1-\xF3][\x80-\xBF]{3}'         // planes 4-15
-               . '|\xF4[\x80-\x8F][\x80-\xBF]{2}';    // plane 16
+                . '|[\xC2-\xDF][\x80-\xBF]'            // non-overlong 2-byte
+                . '|\xE0[\xA0-\xBF][\x80-\xBF]'        // excluding overlongs
+                . '|[\xE1-\xEC\xEE\xEE][\x80-\xBF]{2}' // straight 3-byte (exclude FFFE and FFFF)
+                . '|\xEF[\x80-\xBE][\x80-\xBF]'        // straight 3-byte
+                . '|\xEF\xBF[\x80-\xBD]'               // straight 3-byte
+                . '|\xED[\x80-\x9F][\x80-\xBF]'        // excluding surrogates
+                . '|\xF0[\x90-\xBF][\x80-\xBF]{2}'     // planes 1-3
+                . '|[\xF1-\xF3][\x80-\xBF]{3}'         // planes 4-15
+                . '|\xF4[\x80-\x8F][\x80-\xBF]{2}';    // plane 16
 
             if (!preg_match('/^(?:(?>'.$match.'))+$/s',$str)) {
                 $res = preg_split('/((?>'.$match.')+)/s',$str,null,PREG_SPLIT_DELIM_CAPTURE);

Please login to merge, or discard this patch.

		@@ -1,17 +1,17 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * PHPTAL templating engine
4		- *
5		- * PHP Version 5
6		- *
7		- * @category HTML
8		- * @package PHPTAL
9		- * @author Laurent Bedubourg <[email protected]>
10		- * @author Kornel Lesiński <[email protected]>
11		- * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
12		- * @version SVN: $Id$
13		- * @link http://phptal.org/
14		- */
	3	+ * PHPTAL templating engine
	4	+ *
	5	+ * PHP Version 5
	6	+ *
	7	+ * @category HTML
	8	+ * @package PHPTAL
	9	+ * @author Laurent Bedubourg <[email protected]>
	10	+ * @author Kornel Lesiński <[email protected]>
	11	+ * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
	12	+ * @version SVN: $Id$
	13	+ * @link http://phptal.org/
	14	+ */
15	15
16	16	/**
17	17	* You're probably not using PHPTAL class properly

		@@ -1,17 +1,17 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * PHPTAL templating engine
4		- *
5		- * PHP Version 5
6		- *
7		- * @category HTML
8		- * @package PHPTAL
9		- * @author Laurent Bedubourg <[email protected]>
10		- * @author Kornel Lesiński <[email protected]>
11		- * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
12		- * @version SVN: $Id$
13		- * @link http://phptal.org/
14		- */
	3	+ * PHPTAL templating engine
	4	+ *
	5	+ * PHP Version 5
	6	+ *
	7	+ * @category HTML
	8	+ * @package PHPTAL
	9	+ * @author Laurent Bedubourg <[email protected]>
	10	+ * @author Kornel Lesiński <[email protected]>
	11	+ * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
	12	+ * @version SVN: $Id$
	13	+ * @link http://phptal.org/
	14	+ */
15	15
16	16
17	17	/**
		@@ -466,10 +466,10 @@ discard block
		block discarded – undo
466	466	$nsattr = PHPTAL_Dom_Defs::getInstance()->getNamespaceAttribute($domattr->getNamespaceURI(), $domattr->getLocalName());
467	467	if (array_key_exists($nsattr->getPriority(), $temp)) {
468	468	throw new PHPTAL_TemplateException(sprintf("Attribute conflict in < %s > '%s' cannot appear with '%s'",
469		- $this->qualifiedName,
470		- $key,
471		- $temp[$nsattr->getPriority()][0]->getNamespace()->getPrefix() . ':' . $temp[$nsattr->getPriority()][0]->getLocalName()
472		- ), $this->getSourceFile(), $this->getSourceLine());
	469	+ $this->qualifiedName,
	470	+ $key,
	471	+ $temp[$nsattr->getPriority()][0]->getNamespace()->getPrefix() . ':' . $temp[$nsattr->getPriority()][0]->getLocalName()
	472	+ ), $this->getSourceFile(), $this->getSourceLine());
473	473	}
474	474	$temp[$nsattr->getPriority()] = array($nsattr, $domattr);
475	475	}

phptal / PHPTAL

Pull Request — master (#51)

Status

Category

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch