Inspection of "Refactored tests for new architecture." - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#103)

unknown

created 2017-06-13 20:11 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -20,7 +20,7 @@
 block discarded – undo
             ->getMockForAbstractClass();
 
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Article/tests/Factory/View/Helper/EventHelperFactoryTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -10,12 +10,12 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')
             ->will(static::returnValue($eventService));
         $factory = new \Article\Factory\View\Helper\EventHelperFactory();
-        static::assertInstanceOf(\Article\View\Helper\EventHelper::class, $factory($container, 'test') );
+        static::assertInstanceOf(\Article\View\Helper\EventHelper::class, $factory($container, 'test'));
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Article/tests/Factory/View/Helper/PostHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Controller/UserControllerTest.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -11,7 +11,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
             ->getMock();
         $sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getStorage'])
+            ->setMethods([ 'getStorage' ])
             ->getMock();
         $sessionManager->expects(static::any())
             ->method('getStorage')
@@ -47,14 +47,14 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
             ->will(static::returnValue('test'));
         $adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getUser'])
+            ->setMethods([ 'getUser' ])
             ->getMock();
         $adminUserService->expects(static::once())
             ->method('getUser')
@@ -84,14 +84,14 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
             ->will(static::returnValue('test'));
         $adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['getUser'])
+            ->setMethods([ 'getUser' ])
             ->getMock();
         $adminUserService->expects(static::once())
             ->method('getUser')
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $userController = new \Admin\Controller\UserController(
             $template,
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin/users'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $userController = new \Admin\Controller\UserController(
             $template,
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $userController = new \Admin\Controller\UserController(
             $template,
@@ -205,11 +205,11 @@  discard block
 block discarded – undo
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
-            ->willThrowException(new \Core\Exception\FilterException(['test error']));
+            ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $userController = new \Admin\Controller\UserController(
             $template,
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
             ->willThrowException(new \Exception('test error'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $userController = new \Admin\Controller\UserController(
             $template,
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
             ->getMockForAbstractClass();
         $adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
-            ->setMethods(['delete'])
+            ->setMethods([ 'delete' ])
             ->disableOriginalConstructor()
             ->getMock();
         $adminUserService->expects(static::once())

Please login to merge, or discard this patch.

packages/Admin/tests/Controller/AuthControllerTest.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -15,13 +15,13 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'login');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $sessionManager = $this->getMockBuilder('Zend\Session\SessionManager')
-            ->setMethods(['getStorage', 'writeClose'])
+            ->setMethods([ 'getStorage', 'writeClose' ])
             ->getMock();
         $sessionManager->expects(static::at(0))
             ->method('getStorage')
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
         /** @var \Zend\Diactoros\Response\EmptyResponse $response */
         $response = $auth($request, $response);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testIfUserNotLoggedInLoginActionShouldTakeHimToLoginHtmlPage()
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::at(0))
             ->method('render')
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
             ->getMockForAbstractClass();
         $sessionManager = $this->getMockBuilder('Zend\Session\SessionManager')
-            ->setMethods(['getStorage', 'writeClose'])
+            ->setMethods([ 'getStorage', 'writeClose' ])
             ->getMock();
         $sessionManager->expects(static::at(0))
             ->method('getStorage')
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'logout');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -96,14 +96,14 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertNull($sessionManager->getStorage()->user);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWithCorrectCredentialsShouldSetUserInSessionStorage()
     {
         $adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('loginUser')
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -135,14 +135,14 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertTrue($sessionManager->getStorage()->user->isLoggedIn);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWithWrongCredentialsShouldNotSetUserInSessionStorage()
     {
         $adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
             ->getMockForAbstractClass();
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertNull($sessionManager->getStorage()->user);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWitAlreadyLoggedInUserShouldRedirectToAdminPage()
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -196,14 +196,14 @@  discard block
 block discarded – undo
         /** @var \Zend\Diactoros\Response\HtmlResponse $response */
         $response = $auth($request, $response);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleShouldThrowExceptionAndDisplayMessage()
     {
         $adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('loginUser')
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
             ->method('render')
             ->will(static::returnCallback(
                 function($tpl, $error) {
-                    return $error['error'];
+                    return $error[ 'error' ];
                 }
             ));
         $request = new \Zend\Diactoros\ServerRequest();

Please login to merge, or discard this patch.

packages/Admin/tests/View/Helper/AdminUserHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -32,13 +32,13 @@
 block discarded – undo
     {
         $session = new \Zend\Session\SessionManager();
         $adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
-            ->setMethods(['getAll'])
+            ->setMethods([ 'getAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('getAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $adminUserHelper = new \Admin\View\Helper\AdminUserHelper($session, $adminUserService);
-        static::assertSame([], $adminUserHelper->all());
+        static::assertSame([ ], $adminUserHelper->all());
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Admin/tests/View/Helper/WebAdminUserHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testGetRandomShouldReturnArray()
     {
         $adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
-            ->setMethods(['getForWeb'])
+            ->setMethods([ 'getForWeb' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('getForWeb')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $adminUserHelper = new \Admin\View\Helper\WebAdminUserHelper($adminUserService);
-        static::assertSame([], $adminUserHelper->getRandom());
+        static::assertSame([ ], $adminUserHelper->getRandom());
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/Action/IndexFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -9,7 +9,7 @@
 block discarded – undo
         $template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder('Interop\Container\ContainerInterface')
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::once())
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/Controller/AuthFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -15,7 +15,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder('Interop\Container\ContainerInterface')
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

		@@ -20,7 +20,7 @@
		block discarded – undo
20	20	->getMockForAbstractClass();
21	21
22	22	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
23		- ->setMethods(['get'])
	23	+ ->setMethods([ 'get' ])
24	24	->getMockForAbstractClass();
25	25	$container->expects(static::at(0))
26	26	->method('get')

		@@ -10,12 +10,12 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::at(0))
16	16	->method('get')
17	17	->will(static::returnValue($eventService));
18	18	$factory = new \Article\Factory\View\Helper\EventHelperFactory();
19		- static::assertInstanceOf(\Article\View\Helper\EventHelper::class, $factory($container, 'test') );
	19	+ static::assertInstanceOf(\Article\View\Helper\EventHelper::class, $factory($container, 'test'));
20	20	}
21	21	}
22	22	\ No newline at end of file

		@@ -10,7 +10,7 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::at(0))
16	16	->method('get')

		@@ -11,7 +11,7 @@ discard block
		block discarded – undo
11	11	$sessionStorage = new \Zend\Session\Storage\ArrayStorage();
12	12	$sessionStorage->user = $user;
13	13	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
14		- ->setMethods(['render'])
	14	+ ->setMethods([ 'render' ])
15	15	->getMockForAbstractClass();
16	16	$template->expects(static::once())
17	17	->method('render')
		@@ -21,7 +21,7 @@ discard block
		block discarded – undo
21	21	->getMock();
22	22	$sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
23	23	->disableOriginalConstructor()
24		- ->setMethods(['getStorage'])
	24	+ ->setMethods([ 'getStorage' ])
25	25	->getMock();
26	26	$sessionManager->expects(static::any())
27	27	->method('getStorage')
		@@ -47,14 +47,14 @@ discard block
		block discarded – undo
47	47	$sessionStorage = new \Zend\Session\Storage\ArrayStorage();
48	48	$sessionStorage->user = $user;
49	49	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
50		- ->setMethods(['render'])
	50	+ ->setMethods([ 'render' ])
51	51	->getMockForAbstractClass();
52	52	$template->expects(static::once())
53	53	->method('render')
54	54	->will(static::returnValue('test'));
55	55	$adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
56	56	->disableOriginalConstructor()
57		- ->setMethods(['getUser'])
	57	+ ->setMethods([ 'getUser' ])
58	58	->getMock();
59	59	$adminUserService->expects(static::once())
60	60	->method('getUser')
		@@ -84,14 +84,14 @@ discard block
		block discarded – undo
84	84	$sessionStorage = new \Zend\Session\Storage\ArrayStorage();
85	85	$sessionStorage->user = $user;
86	86	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
87		- ->setMethods(['render'])
	87	+ ->setMethods([ 'render' ])
88	88	->getMockForAbstractClass();
89	89	$template->expects(static::once())
90	90	->method('render')
91	91	->will(static::returnValue('test'));
92	92	$adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
93	93	->disableOriginalConstructor()
94		- ->setMethods(['getUser'])
	94	+ ->setMethods([ 'getUser' ])
95	95	->getMock();
96	96	$adminUserService->expects(static::once())
97	97	->method('getUser')
		@@ -104,7 +104,7 @@ discard block
		block discarded – undo
104	104	$request = new \Zend\Diactoros\ServerRequest();
105	105	$request = $request->withAttribute('action', 'edit');
106	106	$request = $request->withAttribute('id', 1);
107		- $request = $request->withParsedBody(['user' => 'test']);
	107	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
108	108	$response = new \Zend\Diactoros\Response();
109	109	$userController = new \Admin\Controller\UserController(
110	110	$template,
		@@ -136,7 +136,7 @@ discard block
		block discarded – undo
136	136	->will(static::returnValue('http://unfinished.dev/admin/users'));
137	137	$request = new \Zend\Diactoros\ServerRequest();
138	138	$request = $request->withAttribute('action', 'save');
139		- $request = $request->withParsedBody(['user' => 'test']);
	139	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
140	140	$response = new \Zend\Diactoros\Response();
141	141	$userController = new \Admin\Controller\UserController(
142	142	$template,
		@@ -171,7 +171,7 @@ discard block
		block discarded – undo
171	171	$request = new \Zend\Diactoros\ServerRequest();
172	172	$request = $request->withAttribute('action', 'save');
173	173	$request = $request->withAttribute('id', 2);
174		- $request = $request->withParsedBody(['user' => 'test']);
	174	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
175	175	$response = new \Zend\Diactoros\Response();
176	176	$userController = new \Admin\Controller\UserController(
177	177	$template,
		@@ -205,11 +205,11 @@ discard block
		block discarded – undo
205	205	->getMockForAbstractClass();
206	206	$router->expects(static::at(0))
207	207	->method('generateUri')
208		- ->willThrowException(new \Core\Exception\FilterException(['test error']));
	208	+ ->willThrowException(new \Core\Exception\FilterException([ 'test error' ]));
209	209	$request = new \Zend\Diactoros\ServerRequest();
210	210	$request = $request->withAttribute('action', 'save');
211	211	$request = $request->withAttribute('id', 2);
212		- $request = $request->withParsedBody(['user' => 'test']);
	212	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
213	213	$response = new \Zend\Diactoros\Response();
214	214	$userController = new \Admin\Controller\UserController(
215	215	$template,
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	->willThrowException(new \Exception('test error'));
249	249	$request = new \Zend\Diactoros\ServerRequest();
250	250	$request = $request->withAttribute('action', 'save');
251		- $request = $request->withParsedBody(['user' => 'test']);
	251	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
252	252	$response = new \Zend\Diactoros\Response();
253	253	$userController = new \Admin\Controller\UserController(
254	254	$template,
		@@ -302,7 +302,7 @@ discard block
		block discarded – undo
302	302	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
303	303	->getMockForAbstractClass();
304	304	$adminUserService = $this->getMockBuilder(\Core\Service\AdminUserService::class)
305		- ->setMethods(['delete'])
	305	+ ->setMethods([ 'delete' ])
306	306	->disableOriginalConstructor()
307	307	->getMock();
308	308	$adminUserService->expects(static::once())

		@@ -15,13 +15,13 @@ discard block
		block discarded – undo
15	15	$request = $request->withAttribute('action', 'login');
16	16	$response = new \Zend\Diactoros\Response\EmptyResponse();
17	17	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
18		- ->setMethods(['generateUri'])
	18	+ ->setMethods([ 'generateUri' ])
19	19	->getMockForAbstractClass();
20	20	$router->expects(static::at(0))
21	21	->method('generateUri')
22	22	->will(static::returnValue('http://unfinished.dev/admin'));
23	23	$sessionManager = $this->getMockBuilder('Zend\Session\SessionManager')
24		- ->setMethods(['getStorage', 'writeClose'])
	24	+ ->setMethods([ 'getStorage', 'writeClose' ])
25	25	->getMock();
26	26	$sessionManager->expects(static::at(0))
27	27	->method('getStorage')
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	/** @var \Zend\Diactoros\Response\EmptyResponse $response */
35	35	$response = $auth($request, $response);
36	36	static::assertSame(302, $response->getStatusCode());
37		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	37	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
38	38	}
39	39
40	40	public function testIfUserNotLoggedInLoginActionShouldTakeHimToLoginHtmlPage()
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	->disableOriginalConstructor()
44	44	->getMockForAbstractClass();
45	45	$template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
46		- ->setMethods(['render'])
	46	+ ->setMethods([ 'render' ])
47	47	->getMockForAbstractClass();
48	48	$template->expects(static::at(0))
49	49	->method('render')
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
55	55	->getMockForAbstractClass();
56	56	$sessionManager = $this->getMockBuilder('Zend\Session\SessionManager')
57		- ->setMethods(['getStorage', 'writeClose'])
	57	+ ->setMethods([ 'getStorage', 'writeClose' ])
58	58	->getMock();
59	59	$sessionManager->expects(static::at(0))
60	60	->method('getStorage')
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	$request = $request->withAttribute('action', 'logout');
82	82	$response = new \Zend\Diactoros\Response\EmptyResponse();
83	83	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
84		- ->setMethods(['generateUri'])
	84	+ ->setMethods([ 'generateUri' ])
85	85	->getMockForAbstractClass();
86	86	$router->expects(static::at(0))
87	87	->method('generateUri')
		@@ -96,14 +96,14 @@ discard block
		block discarded – undo
96	96	$response = $auth($request, $response);
97	97	static::assertNull($sessionManager->getStorage()->user);
98	98	static::assertSame(302, $response->getStatusCode());
99		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	99	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
100	100	}
101	101
102	102	public function testUserLoginHandleWithCorrectCredentialsShouldSetUserInSessionStorage()
103	103	{
104	104	$adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
105	105	->disableOriginalConstructor()
106		- ->setMethods(['loginUser'])
	106	+ ->setMethods([ 'loginUser' ])
107	107	->getMockForAbstractClass();
108	108	$adminUserService->expects(static::once())
109	109	->method('loginUser')
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	$request = $request->withAttribute('action', 'loginHandle');
123	123	$response = new \Zend\Diactoros\Response\EmptyResponse();
124	124	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
125		- ->setMethods(['generateUri'])
	125	+ ->setMethods([ 'generateUri' ])
126	126	->getMockForAbstractClass();
127	127	$router->expects(static::at(0))
128	128	->method('generateUri')
		@@ -135,14 +135,14 @@ discard block
		block discarded – undo
135	135	$response = $auth($request, $response);
136	136	static::assertTrue($sessionManager->getStorage()->user->isLoggedIn);
137	137	static::assertSame(302, $response->getStatusCode());
138		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	138	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
139	139	}
140	140
141	141	public function testUserLoginHandleWithWrongCredentialsShouldNotSetUserInSessionStorage()
142	142	{
143	143	$adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
144	144	->disableOriginalConstructor()
145		- ->setMethods(['loginUser'])
	145	+ ->setMethods([ 'loginUser' ])
146	146	->getMockForAbstractClass();
147	147	$template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
148	148	->getMockForAbstractClass();
		@@ -154,7 +154,7 @@ discard block
		block discarded – undo
154	154	$request = $request->withAttribute('action', 'loginHandle');
155	155	$response = new \Zend\Diactoros\Response\EmptyResponse();
156	156	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
157		- ->setMethods(['generateUri'])
	157	+ ->setMethods([ 'generateUri' ])
158	158	->getMockForAbstractClass();
159	159	$router->expects(static::at(0))
160	160	->method('generateUri')
		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	$response = $auth($request, $response);
169	169	static::assertNull($sessionManager->getStorage()->user);
170	170	static::assertSame(302, $response->getStatusCode());
171		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	171	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
172	172	}
173	173
174	174	public function testUserLoginHandleWitAlreadyLoggedInUserShouldRedirectToAdminPage()
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	$request = $request->withAttribute('action', 'loginHandle');
183	183	$response = new \Zend\Diactoros\Response\EmptyResponse();
184	184	$router = $this->getMockBuilder('Zend\Expressive\Router\RouterInterface')
185		- ->setMethods(['generateUri'])
	185	+ ->setMethods([ 'generateUri' ])
186	186	->getMockForAbstractClass();
187	187	$router->expects(static::at(0))
188	188	->method('generateUri')
		@@ -196,14 +196,14 @@ discard block
		block discarded – undo
196	196	/** @var \Zend\Diactoros\Response\HtmlResponse $response */
197	197	$response = $auth($request, $response);
198	198	static::assertSame(302, $response->getStatusCode());
199		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	199	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
200	200	}
201	201
202	202	public function testUserLoginHandleShouldThrowExceptionAndDisplayMessage()
203	203	{
204	204	$adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
205	205	->disableOriginalConstructor()
206		- ->setMethods(['loginUser'])
	206	+ ->setMethods([ 'loginUser' ])
207	207	->getMockForAbstractClass();
208	208	$adminUserService->expects(static::once())
209	209	->method('loginUser')
		@@ -214,7 +214,7 @@ discard block
		block discarded – undo
214	214	->method('render')
215	215	->will(static::returnCallback(
216	216	function($tpl, $error) {
217		- return $error['error'];
	217	+ return $error[ 'error' ];
218	218	}
219	219	));
220	220	$request = new \Zend\Diactoros\ServerRequest();

		@@ -32,13 +32,13 @@
		block discarded – undo
32	32	{
33	33	$session = new \Zend\Session\SessionManager();
34	34	$adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
35		- ->setMethods(['getAll'])
	35	+ ->setMethods([ 'getAll' ])
36	36	->disableOriginalConstructor()
37	37	->getMockForAbstractClass();
38	38	$adminUserService->expects(static::once())
39	39	->method('getAll')
40		- ->willReturn([]);
	40	+ ->willReturn([ ]);
41	41	$adminUserHelper = new \Admin\View\Helper\AdminUserHelper($session, $adminUserService);
42		- static::assertSame([], $adminUserHelper->all());
	42	+ static::assertSame([ ], $adminUserHelper->all());
43	43	}
44	44	}
45	45	\ No newline at end of file

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testGetRandomShouldReturnArray()
17	17	{
18	18	$adminUserService = $this->getMockBuilder('Core\Service\AdminUserService')
19		- ->setMethods(['getForWeb'])
	19	+ ->setMethods([ 'getForWeb' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$adminUserService->expects(static::once())
23	23	->method('getForWeb')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$adminUserHelper = new \Admin\View\Helper\WebAdminUserHelper($adminUserService);
26		- static::assertSame([], $adminUserHelper->getRandom());
	26	+ static::assertSame([ ], $adminUserHelper->getRandom());
27	27	}
28	28	}
29	29	\ No newline at end of file

		@@ -9,7 +9,7 @@
		block discarded – undo
9	9	$template = $this->getMockBuilder('Zend\Expressive\Template\TemplateRendererInterface')
10	10	->getMockForAbstractClass();
11	11	$container = $this->getMockBuilder('Interop\Container\ContainerInterface')
12		- ->setMethods(['get'])
	12	+ ->setMethods([ 'get' ])
13	13	->getMockForAbstractClass();
14	14	$container->expects(static::once())
15	15	->method('get')

		@@ -15,7 +15,7 @@
		block discarded – undo
15	15	->disableOriginalConstructor()
16	16	->getMockForAbstractClass();
17	17	$container = $this->getMockBuilder('Interop\Container\ContainerInterface')
18		- ->setMethods(['get'])
	18	+ ->setMethods([ 'get' ])
19	19	->getMockForAbstractClass();
20	20	$container->expects(static::at(0))
21	21	->method('get')

phpsrbija / unfinished

Pull Request — master (#103)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch