Inspection of "Merge pull request #116 from phpsrbija/category-ty..." - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 88b7e8...d57605 )

by Aleksandar

created 2017-06-29 11:14 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Category/tests/View/Helper/CategoryHelperTest.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -16,26 +16,26 @@
 block discarded – undo
     public function testForSelectShouldReturnArray()
     {
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
-            ->setMethods(['getAll'])
+            ->setMethods([ 'getAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $categoryService->expects(static::once())
             ->method('getAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $categoryHelper = new \Category\View\Helper\CategoryHelper($categoryService);
-        static::assertSame([], $categoryHelper->forSelect());
+        static::assertSame([ ], $categoryHelper->forSelect());
     }
 
     public function testForHomepageShouldReturnArray()
     {
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
-            ->setMethods(['getCategoriesWithPosts'])
+            ->setMethods([ 'getCategoriesWithPosts' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $categoryService->expects(static::once())
             ->method('getCategoriesWithPosts')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $categoryHelper = new \Category\View\Helper\CategoryHelper($categoryService);
-        static::assertSame([], $categoryHelper->forHomepage());
+        static::assertSame([ ], $categoryHelper->forHomepage());
     }
 }

Please login to merge, or discard this patch.

packages/Category/tests/Factory/Controller/IndexFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Web/Action/EventAction.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Web\Action;
 

Please login to merge, or discard this patch.

packages/Menu/tests/Controller/IndexControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
     public function testEditMethodShouldReturnHtmlResponseAndGetIdFromRequest()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,
@@ -117,13 +117,13 @@  discard block
 block discarded – undo
             ->getMock();
         $menuService->expects(static::once())
             ->method('updateMenuItem')
-            ->willThrowException(new \Std\FilterException(['test error']));
+            ->willThrowException(new \Std\FilterException([ 'test error' ]));
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
             ->getMockForAbstractClass();
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'updateOrder');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['menu' => 'test']);
+        $request = $request->withParsedBody([ 'menu' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Menu\Controller\IndexController(
             $template,

Please login to merge, or discard this patch.

packages/Category/tests/Controllers/IndexControllerTest.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
     public function testEditMethodShouldReturnHtmlResponseAndGetIdFromRequest()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -117,13 +117,13 @@  discard block
 block discarded – undo
             ->getMock();
         $categoryService->expects(static::once())
             ->method('updateCategory')
-            ->willThrowException(new \Std\FilterException(['test error']));
+            ->willThrowException(new \Std\FilterException([ 'test error' ]));
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
             ->getMockForAbstractClass();
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/View/Helper/AdminUserHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/View/Helper/WebAdminUserHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/Controller/UserFactoryTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -12,11 +12,11 @@
 block discarded – undo
             ->getMockForAbstractClass();
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $session = new \Zend\Session\SessionManager();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

		@@ -10,7 +10,7 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::at(0))
16	16	->method('get')

		@@ -16,26 +16,26 @@
		block discarded – undo
16	16	public function testForSelectShouldReturnArray()
17	17	{
18	18	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
19		- ->setMethods(['getAll'])
	19	+ ->setMethods([ 'getAll' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$categoryService->expects(static::once())
23	23	->method('getAll')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$categoryHelper = new \Category\View\Helper\CategoryHelper($categoryService);
26		- static::assertSame([], $categoryHelper->forSelect());
	26	+ static::assertSame([ ], $categoryHelper->forSelect());
27	27	}
28	28
29	29	public function testForHomepageShouldReturnArray()
30	30	{
31	31	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
32		- ->setMethods(['getCategoriesWithPosts'])
	32	+ ->setMethods([ 'getCategoriesWithPosts' ])
33	33	->disableOriginalConstructor()
34	34	->getMockForAbstractClass();
35	35	$categoryService->expects(static::once())
36	36	->method('getCategoriesWithPosts')
37		- ->willReturn([]);
	37	+ ->willReturn([ ]);
38	38	$categoryHelper = new \Category\View\Helper\CategoryHelper($categoryService);
39		- static::assertSame([], $categoryHelper->forHomepage());
	39	+ static::assertSame([ ], $categoryHelper->forHomepage());
40	40	}
41	41	}

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php
2	2
3		-declare(strict_types=1);
	3	+declare(strict_types = 1);
4	4
5	5	namespace Web\Action;
6	6

		@@ -7,7 +7,7 @@ discard block
		block discarded – undo
7	7	public function testIndexMethodShouldReturnHtmlResponse()
8	8	{
9	9	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
10		- ->setMethods(['render'])
	10	+ ->setMethods([ 'render' ])
11	11	->getMockForAbstractClass();
12	12	$template->expects(static::once())
13	13	->method('render')
		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31	public function testEditMethodShouldReturnHtmlResponseAndGetIdFromRequest()
32	32	{
33	33	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
34		- ->setMethods(['render'])
	34	+ ->setMethods([ 'render' ])
35	35	->getMockForAbstractClass();
36	36	$template->expects(static::once())
37	37	->method('render')
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$request = new \Zend\Diactoros\ServerRequest();
45	45	$request = $request->withAttribute('action', 'edit');
46	46	$request = $request->withAttribute('id', 1);
47		- $request = $request->withParsedBody(['menu' => 'test']);
	47	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
48	48	$response = new \Zend\Diactoros\Response();
49	49	$indexController = new \Menu\Controller\IndexController(
50	50	$template,
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	->will(static::returnValue('http://unfinished.dev/admin'));
69	69	$request = new \Zend\Diactoros\ServerRequest();
70	70	$request = $request->withAttribute('action', 'save');
71		- $request = $request->withParsedBody(['menu' => 'test']);
	71	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
72	72	$response = new \Zend\Diactoros\Response();
73	73	$indexController = new \Menu\Controller\IndexController(
74	74	$template,
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94	$request = new \Zend\Diactoros\ServerRequest();
95	95	$request = $request->withAttribute('action', 'save');
96	96	$request = $request->withAttribute('id', 1);
97		- $request = $request->withParsedBody(['menu' => 'test']);
	97	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
98	98	$response = new \Zend\Diactoros\Response();
99	99	$indexController = new \Menu\Controller\IndexController(
100	100	$template,
		@@ -117,13 +117,13 @@ discard block
		block discarded – undo
117	117	->getMock();
118	118	$menuService->expects(static::once())
119	119	->method('updateMenuItem')
120		- ->willThrowException(new \Std\FilterException(['test error']));
	120	+ ->willThrowException(new \Std\FilterException([ 'test error' ]));
121	121	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
122	122	->getMockForAbstractClass();
123	123	$request = new \Zend\Diactoros\ServerRequest();
124	124	$request = $request->withAttribute('action', 'save');
125	125	$request = $request->withAttribute('id', 2);
126		- $request = $request->withParsedBody(['menu' => 'test']);
	126	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
127	127	$response = new \Zend\Diactoros\Response();
128	128	$indexController = new \Menu\Controller\IndexController(
129	129	$template,
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	$request = new \Zend\Diactoros\ServerRequest();
156	156	$request = $request->withAttribute('action', 'save');
157	157	$request = $request->withAttribute('id', 2);
158		- $request = $request->withParsedBody(['menu' => 'test']);
	158	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
159	159	$response = new \Zend\Diactoros\Response();
160	160	$indexController = new \Menu\Controller\IndexController(
161	161	$template,
		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	$request = new \Zend\Diactoros\ServerRequest();
235	235	$request = $request->withAttribute('action', 'updateOrder');
236	236	$request = $request->withAttribute('id', 2);
237		- $request = $request->withParsedBody(['menu' => 'test']);
	237	+ $request = $request->withParsedBody([ 'menu' => 'test' ]);
238	238	$response = new \Zend\Diactoros\Response();
239	239	$indexController = new \Menu\Controller\IndexController(
240	240	$template,

		@@ -12,11 +12,11 @@
		block discarded – undo
12	12	->getMockForAbstractClass();
13	13	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
14	14	->disableOriginalConstructor()
15		- ->setMethods(['loginUser'])
	15	+ ->setMethods([ 'loginUser' ])
16	16	->getMockForAbstractClass();
17	17	$session = new \Zend\Session\SessionManager();
18	18	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
19		- ->setMethods(['get'])
	19	+ ->setMethods([ 'get' ])
20	20	->getMockForAbstractClass();
21	21	$container->expects(static::at(0))
22	22	->method('get')

phpsrbija / unfinished

Push — master ( 88b7e8...d57605 )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch