Inspection of "Merge pull request #107 from djavolak/testCbf" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 262a1a...ffe0da )

unknown

created 2017-06-20 14:37 UTC

Status

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,21 +16,21 @@
 block discarded – undo
     /**
 * 
      *
- * @var Template 
+     * @var Template 
 */
     private $template;
 
     /**
 * 
      *
- * @var Router 
+     * @var Router 
 */
     private $router;
 
     /**
 * 
      *
- * @var MenuService 
+     * @var MenuService 
 */
     private $menuService;
 

Please login to merge, or discard this patch.

packages/Menu/src/View/Helper/MenuUrlHelper.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -11,14 +11,14 @@
 block discarded – undo
     /**
 * 
      *
- * @var UrlHelper 
+     * @var UrlHelper 
 */
     private $url;
 
     /**
 * 
      *
- * @var PostService 
+     * @var PostService 
 */
     private $postService;
 

Please login to merge, or discard this patch.

packages/Article/src/Controller/DiscussionController.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -18,35 +18,35 @@
 block discarded – undo
     /**
 * 
      *
- * @var Template 
+     * @var Template 
 */
     private $template;
 
     /**
 * 
      *
- * @var Router 
+     * @var Router 
 */
     private $router;
 
     /**
 * 
      *
- * @var DiscussionService 
+     * @var DiscussionService 
 */
     private $discussionService;
 
     /**
 * 
      *
- * @var SessionManager 
+     * @var SessionManager 
 */
     private $session;
 
     /**
 * 
      *
- * @var CategoryService 
+     * @var CategoryService 
 */
     private $categoryService;
     

Please login to merge, or discard this patch.

packages/Article/src/Service/VideoService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -22,49 +22,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticleVideosMapper 
+     * @var ArticleVideosMapper 
 */
     private $articleVideosMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var VideoFilter 
+     * @var VideoFilter 
 */
     private $videosFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

packages/Article/src/Service/PostService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -23,49 +23,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticlePostsMapper 
+     * @var ArticlePostsMapper 
 */
     private $articlePostsMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var PostFilter 
+     * @var PostFilter 
 */
     private $postFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

packages/Article/tests/Controller/DiscussionControllerTest.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -149,7 +149,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $discussionController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $discussionController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $discussionController($request, $response);
         static::assertSame(200, $returnedResponse->getStatusCode());
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $discussionController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());

Please login to merge, or discard this patch.

packages/Article/tests/Controller/EventControllerTest.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -149,7 +149,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $eventController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $eventController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $eventController($request, $response);
         static::assertSame(200, $returnedResponse->getStatusCode());
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $eventController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());

Please login to merge, or discard this patch.

packages/Article/tests/Controller/PostControllerTest.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -149,7 +149,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $postController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $postController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $postController($request, $response);
         static::assertSame(200, $returnedResponse->getStatusCode());
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $postController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());

Please login to merge, or discard this patch.

packages/Article/tests/Controller/VideoControllerTest.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -149,7 +149,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $videoController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $videoController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $videoController($request, $response);
         static::assertSame(200, $returnedResponse->getStatusCode());
@@ -330,7 +330,7 @@  discard block
 block discarded – undo
         /**
 * 
          *
- * @var \Zend\Diactoros\Response $returnedResponse 
+         * @var \Zend\Diactoros\Response $returnedResponse 
 */
         $returnedResponse = $videoController($request, $response);
         static::assertSame(302, $returnedResponse->getStatusCode());

Please login to merge, or discard this patch.

		@@ -22,49 +22,49 @@
		block discarded – undo
22	22	/**
23	23	*
24	24	*
25		- * @var ArticleMapper
	25	+ * @var ArticleMapper
26	26	*/
27	27	private $articleMapper;
28	28
29	29	/**
30	30	*
31	31	*
32		- * @var ArticleVideosMapper
	32	+ * @var ArticleVideosMapper
33	33	*/
34	34	private $articleVideosMapper;
35	35
36	36	/**
37	37	*
38	38	*
39		- * @var ArticleFilter
	39	+ * @var ArticleFilter
40	40	*/
41	41	private $articleFilter;
42	42
43	43	/**
44	44	*
45	45	*
46		- * @var VideoFilter
	46	+ * @var VideoFilter
47	47	*/
48	48	private $videosFilter;
49	49
50	50	/**
51	51	*
52	52	*
53		- * @var CategoryMapper
	53	+ * @var CategoryMapper
54	54	*/
55	55	private $categoryMapper;
56	56
57	57	/**
58	58	*
59	59	*
60		- * @var Upload
	60	+ * @var Upload
61	61	*/
62	62	private $upload;
63	63
64	64	/**
65	65	*
66	66	*
67		- * @var AdminUsersMapper
	67	+ * @var AdminUsersMapper
68	68	*/
69	69	private $adminUsersMapper;
70	70

		@@ -23,49 +23,49 @@
		block discarded – undo
23	23	/**
24	24	*
25	25	*
26		- * @var ArticleMapper
	26	+ * @var ArticleMapper
27	27	*/
28	28	private $articleMapper;
29	29
30	30	/**
31	31	*
32	32	*
33		- * @var ArticlePostsMapper
	33	+ * @var ArticlePostsMapper
34	34	*/
35	35	private $articlePostsMapper;
36	36
37	37	/**
38	38	*
39	39	*
40		- * @var ArticleFilter
	40	+ * @var ArticleFilter
41	41	*/
42	42	private $articleFilter;
43	43
44	44	/**
45	45	*
46	46	*
47		- * @var PostFilter
	47	+ * @var PostFilter
48	48	*/
49	49	private $postFilter;
50	50
51	51	/**
52	52	*
53	53	*
54		- * @var CategoryMapper
	54	+ * @var CategoryMapper
55	55	*/
56	56	private $categoryMapper;
57	57
58	58	/**
59	59	*
60	60	*
61		- * @var Upload
	61	+ * @var Upload
62	62	*/
63	63	private $upload;
64	64
65	65	/**
66	66	*
67	67	*
68		- * @var AdminUsersMapper
	68	+ * @var AdminUsersMapper
69	69	*/
70	70	private $adminUsersMapper;
71	71

		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	/**
150	150	*
151	151	*
152		- * @var \Zend\Diactoros\Response $returnedResponse
	152	+ * @var \Zend\Diactoros\Response $returnedResponse
153	153	*/
154	154	$returnedResponse = $discussionController($request, $response);
155	155	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -194,7 +194,7 @@ discard block
		block discarded – undo
194	194	/**
195	195	*
196	196	*
197		- * @var \Zend\Diactoros\Response $returnedResponse
	197	+ * @var \Zend\Diactoros\Response $returnedResponse
198	198	*/
199	199	$returnedResponse = $discussionController($request, $response);
200	200	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -242,7 +242,7 @@ discard block
		block discarded – undo
242	242	/**
243	243	*
244	244	*
245		- * @var \Zend\Diactoros\Response $returnedResponse
	245	+ * @var \Zend\Diactoros\Response $returnedResponse
246	246	*/
247	247	$returnedResponse = $discussionController($request, $response);
248	248	static::assertSame(200, $returnedResponse->getStatusCode());
		@@ -330,7 +330,7 @@ discard block
		block discarded – undo
330	330	/**
331	331	*
332	332	*
333		- * @var \Zend\Diactoros\Response $returnedResponse
	333	+ * @var \Zend\Diactoros\Response $returnedResponse
334	334	*/
335	335	$returnedResponse = $discussionController($request, $response);
336	336	static::assertSame(302, $returnedResponse->getStatusCode());

		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	/**
150	150	*
151	151	*
152		- * @var \Zend\Diactoros\Response $returnedResponse
	152	+ * @var \Zend\Diactoros\Response $returnedResponse
153	153	*/
154	154	$returnedResponse = $eventController($request, $response);
155	155	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -194,7 +194,7 @@ discard block
		block discarded – undo
194	194	/**
195	195	*
196	196	*
197		- * @var \Zend\Diactoros\Response $returnedResponse
	197	+ * @var \Zend\Diactoros\Response $returnedResponse
198	198	*/
199	199	$returnedResponse = $eventController($request, $response);
200	200	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -242,7 +242,7 @@ discard block
		block discarded – undo
242	242	/**
243	243	*
244	244	*
245		- * @var \Zend\Diactoros\Response $returnedResponse
	245	+ * @var \Zend\Diactoros\Response $returnedResponse
246	246	*/
247	247	$returnedResponse = $eventController($request, $response);
248	248	static::assertSame(200, $returnedResponse->getStatusCode());
		@@ -330,7 +330,7 @@ discard block
		block discarded – undo
330	330	/**
331	331	*
332	332	*
333		- * @var \Zend\Diactoros\Response $returnedResponse
	333	+ * @var \Zend\Diactoros\Response $returnedResponse
334	334	*/
335	335	$returnedResponse = $eventController($request, $response);
336	336	static::assertSame(302, $returnedResponse->getStatusCode());

		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	/**
150	150	*
151	151	*
152		- * @var \Zend\Diactoros\Response $returnedResponse
	152	+ * @var \Zend\Diactoros\Response $returnedResponse
153	153	*/
154	154	$returnedResponse = $postController($request, $response);
155	155	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -194,7 +194,7 @@ discard block
		block discarded – undo
194	194	/**
195	195	*
196	196	*
197		- * @var \Zend\Diactoros\Response $returnedResponse
	197	+ * @var \Zend\Diactoros\Response $returnedResponse
198	198	*/
199	199	$returnedResponse = $postController($request, $response);
200	200	static::assertSame(302, $returnedResponse->getStatusCode());
		@@ -242,7 +242,7 @@ discard block
		block discarded – undo
242	242	/**
243	243	*
244	244	*
245		- * @var \Zend\Diactoros\Response $returnedResponse
	245	+ * @var \Zend\Diactoros\Response $returnedResponse
246	246	*/
247	247	$returnedResponse = $postController($request, $response);
248	248	static::assertSame(200, $returnedResponse->getStatusCode());
		@@ -330,7 +330,7 @@ discard block
		block discarded – undo
330	330	/**
331	331	*
332	332	*
333		- * @var \Zend\Diactoros\Response $returnedResponse
	333	+ * @var \Zend\Diactoros\Response $returnedResponse
334	334	*/
335	335	$returnedResponse = $postController($request, $response);
336	336	static::assertSame(302, $returnedResponse->getStatusCode());

		@@ -16,21 +16,21 @@
		block discarded – undo
16	16	/**
17	17	*
18	18	*
19		- * @var Template
	19	+ * @var Template
20	20	*/
21	21	private $template;
22	22
23	23	/**
24	24	*
25	25	*
26		- * @var Router
	26	+ * @var Router
27	27	*/
28	28	private $router;
29	29
30	30	/**
31	31	*
32	32	*
33		- * @var MenuService
	33	+ * @var MenuService
34	34	*/
35	35	private $menuService;
36	36

		@@ -11,14 +11,14 @@
		block discarded – undo
11	11	/**
12	12	*
13	13	*
14		- * @var UrlHelper
	14	+ * @var UrlHelper
15	15	*/
16	16	private $url;
17	17
18	18	/**
19	19	*
20	20	*
21		- * @var PostService
	21	+ * @var PostService
22	22	*/
23	23	private $postService;
24	24

		@@ -18,35 +18,35 @@
		block discarded – undo
18	18	/**
19	19	*
20	20	*
21		- * @var Template
	21	+ * @var Template
22	22	*/
23	23	private $template;
24	24
25	25	/**
26	26	*
27	27	*
28		- * @var Router
	28	+ * @var Router
29	29	*/
30	30	private $router;
31	31
32	32	/**
33	33	*
34	34	*
35		- * @var DiscussionService
	35	+ * @var DiscussionService
36	36	*/
37	37	private $discussionService;
38	38
39	39	/**
40	40	*
41	41	*
42		- * @var SessionManager
	42	+ * @var SessionManager
43	43	*/
44	44	private $session;
45	45
46	46	/**
47	47	*
48	48	*
49		- * @var CategoryService
	49	+ * @var CategoryService
50	50	*/
51	51	private $categoryService;
52	52

phpsrbija / unfinished

Push — master ( 262a1a...ffe0da )

Status

Category

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch