Inspection of "Merge pull request #107 from djavolak/testCbf" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 262a1a...ffe0da )

unknown

created 2017-06-20 14:37 UTC

Status

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@  discard block
 block discarded – undo
 <?php
 
-	header ( 'Content-type: text/plain');
-	echo "
+    header ( 'Content-type: text/plain');
+    echo "
 		Now see here, you will see the output of the param most 
 		interesting to PHP. \$_POST.
 		
@@ -13,4 +13,4 @@  discard block
 block discarded – undo
 		
 		print_r(\$_POST);
 	";	
-	print_r($_POST);
\ No newline at end of file
+    print_r($_POST);
\ No newline at end of file

Please login to merge, or discard this patch.

vendors/jQuery-Smart-Wizard/more_examples/smartwizard2-validation.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -155,9 +155,9 @@
 block discarded – undo
 <table align="center" border="0" cellpadding="0" cellspacing="0">
 <tr><td>
 <?
-   if(isset($_REQUEST['issubmit'])){
-      echo "<strong>form is sumbitted</strong>";
-   }
+    if(isset($_REQUEST['issubmit'])){
+        echo "<strong>form is sumbitted</strong>";
+    }
 
 ?>
  

Please login to merge, or discard this patch.

admin_assets/vendors/jQuery-Smart-Wizard/more_examples/services/service.php 1 patch

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -1,26 +1,26 @@  discard block
 block discarded – undo
 <?
-  $action = $_REQUEST["action"];
-  switch($action){
-      case "1":
+    $action = $_REQUEST["action"];
+    switch($action){
+        case "1":
           getContent();
         break;                     
-      default:
+        default:
         break;
-  }
+    }
 
- function getContent(){
-   //sleep(1); 
-   $step_number = $_REQUEST["step_number"]; 
-   $html = '<h2 class="StepTitle">Step '.$step_number.' Content</h2>';
-   if($step_number == 1){
-      $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
+    function getContent(){
+    //sleep(1); 
+    $step_number = $_REQUEST["step_number"]; 
+    $html = '<h2 class="StepTitle">Step '.$step_number.' Content</h2>';
+    if($step_number == 1){
+        $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
             sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, 
             quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
             Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
             </p>';
-   }elseif($step_number == 2){
-      $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
+    }elseif($step_number == 2){
+        $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
             sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, 
             quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
@@ -32,8 +32,8 @@  discard block
 block discarded – undo
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
             Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
             </p>';
-   }elseif($step_number == 3){
-      $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
+    }elseif($step_number == 3){
+        $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
             sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, 
             quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
@@ -51,15 +51,15 @@  discard block
 block discarded – undo
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
             Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
             </p>';
-   }else{
-      $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
+    }else{
+        $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit, 
             sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, 
             quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. 
             Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. 
             Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
             </p>';
-   }
-   echo $html;
- }
+    }
+    echo $html;
+    }
 
 ?>
\ No newline at end of file

Please login to merge, or discard this patch.

packages/Page/src/Service/PageService.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -83,7 +83,7 @@
 block discarded – undo
             + ['main_img' => $this->upload->uploadImage($data, 'main_img')];
         $data['page_id'] = Uuid::uuid1()->toString();
         $data['page_uuid']
-                         = (new MysqlUuid($data['page_id']))->toFormat(new Binary);
+                            = (new MysqlUuid($data['page_id']))->toFormat(new Binary);
 
         if ($data['is_homepage']) {
             $this->pageMapper->update(['is_homepage' => false]);

Please login to merge, or discard this patch.

packages/Menu/src/Controller/IndexController.php 1 patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,21 +16,21 @@
 block discarded – undo
     /**
 * 
      *
- * @var Template 
+     * @var Template 
 */
     private $template;
 
     /**
 * 
      *
- * @var Router 
+     * @var Router 
 */
     private $router;
 
     /**
 * 
      *
- * @var MenuService 
+     * @var MenuService 
 */
     private $menuService;
 

Please login to merge, or discard this patch.

packages/Menu/src/View/Helper/MenuUrlHelper.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -11,14 +11,14 @@
 block discarded – undo
     /**
 * 
      *
- * @var UrlHelper 
+     * @var UrlHelper 
 */
     private $url;
 
     /**
 * 
      *
- * @var PostService 
+     * @var PostService 
 */
     private $postService;
 

Please login to merge, or discard this patch.

packages/Article/src/Controller/DiscussionController.php 1 patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -18,35 +18,35 @@
 block discarded – undo
     /**
 * 
      *
- * @var Template 
+     * @var Template 
 */
     private $template;
 
     /**
 * 
      *
- * @var Router 
+     * @var Router 
 */
     private $router;
 
     /**
 * 
      *
- * @var DiscussionService 
+     * @var DiscussionService 
 */
     private $discussionService;
 
     /**
 * 
      *
- * @var SessionManager 
+     * @var SessionManager 
 */
     private $session;
 
     /**
 * 
      *
- * @var CategoryService 
+     * @var CategoryService 
 */
     private $categoryService;
     

Please login to merge, or discard this patch.

packages/Article/src/Service/VideoService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -22,49 +22,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticleVideosMapper 
+     * @var ArticleVideosMapper 
 */
     private $articleVideosMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var VideoFilter 
+     * @var VideoFilter 
 */
     private $videosFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

packages/Article/src/Service/PostService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -23,49 +23,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticlePostsMapper 
+     * @var ArticlePostsMapper 
 */
     private $articlePostsMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var PostFilter 
+     * @var PostFilter 
 */
     private $postFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

		@@ -155,9 +155,9 @@
		block discarded – undo
155	155	<table align="center" border="0" cellpadding="0" cellspacing="0">
156	156	<tr><td>
157	157	<?
158		- if(isset($_REQUEST['issubmit'])){
159		- echo "<strong>form is sumbitted</strong>";
160		- }
	158	+ if(isset($_REQUEST['issubmit'])){
	159	+ echo "<strong>form is sumbitted</strong>";
	160	+ }
161	161
162	162	?>
163	163

		@@ -83,7 +83,7 @@
		block discarded – undo
83	83	+ ['main_img' => $this->upload->uploadImage($data, 'main_img')];
84	84	$data['page_id'] = Uuid::uuid1()->toString();
85	85	$data['page_uuid']
86		- = (new MysqlUuid($data['page_id']))->toFormat(new Binary);
	86	+ = (new MysqlUuid($data['page_id']))->toFormat(new Binary);
87	87
88	88	if ($data['is_homepage']) {
89	89	$this->pageMapper->update(['is_homepage' => false]);

		@@ -22,49 +22,49 @@
		block discarded – undo
22	22	/**
23	23	*
24	24	*
25		- * @var ArticleMapper
	25	+ * @var ArticleMapper
26	26	*/
27	27	private $articleMapper;
28	28
29	29	/**
30	30	*
31	31	*
32		- * @var ArticleVideosMapper
	32	+ * @var ArticleVideosMapper
33	33	*/
34	34	private $articleVideosMapper;
35	35
36	36	/**
37	37	*
38	38	*
39		- * @var ArticleFilter
	39	+ * @var ArticleFilter
40	40	*/
41	41	private $articleFilter;
42	42
43	43	/**
44	44	*
45	45	*
46		- * @var VideoFilter
	46	+ * @var VideoFilter
47	47	*/
48	48	private $videosFilter;
49	49
50	50	/**
51	51	*
52	52	*
53		- * @var CategoryMapper
	53	+ * @var CategoryMapper
54	54	*/
55	55	private $categoryMapper;
56	56
57	57	/**
58	58	*
59	59	*
60		- * @var Upload
	60	+ * @var Upload
61	61	*/
62	62	private $upload;
63	63
64	64	/**
65	65	*
66	66	*
67		- * @var AdminUsersMapper
	67	+ * @var AdminUsersMapper
68	68	*/
69	69	private $adminUsersMapper;
70	70

		@@ -23,49 +23,49 @@
		block discarded – undo
23	23	/**
24	24	*
25	25	*
26		- * @var ArticleMapper
	26	+ * @var ArticleMapper
27	27	*/
28	28	private $articleMapper;
29	29
30	30	/**
31	31	*
32	32	*
33		- * @var ArticlePostsMapper
	33	+ * @var ArticlePostsMapper
34	34	*/
35	35	private $articlePostsMapper;
36	36
37	37	/**
38	38	*
39	39	*
40		- * @var ArticleFilter
	40	+ * @var ArticleFilter
41	41	*/
42	42	private $articleFilter;
43	43
44	44	/**
45	45	*
46	46	*
47		- * @var PostFilter
	47	+ * @var PostFilter
48	48	*/
49	49	private $postFilter;
50	50
51	51	/**
52	52	*
53	53	*
54		- * @var CategoryMapper
	54	+ * @var CategoryMapper
55	55	*/
56	56	private $categoryMapper;
57	57
58	58	/**
59	59	*
60	60	*
61		- * @var Upload
	61	+ * @var Upload
62	62	*/
63	63	private $upload;
64	64
65	65	/**
66	66	*
67	67	*
68		- * @var AdminUsersMapper
	68	+ * @var AdminUsersMapper
69	69	*/
70	70	private $adminUsersMapper;
71	71

		@@ -1,7 +1,7 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		- header ( 'Content-type: text/plain');
4		- echo "
	3	+ header ( 'Content-type: text/plain');
	4	+ echo "
5	5	Now see here, you will see the output of the param most
6	6	interesting to PHP. \$_POST.
7	7
		@@ -13,4 +13,4 @@ discard block
		block discarded – undo
13	13
14	14	print_r(\$_POST);
15	15	";
16		- print_r($_POST);
17	16	\ No newline at end of file
	17	+ print_r($_POST);
18	18	\ No newline at end of file

		@@ -1,26 +1,26 @@ discard block
		block discarded – undo
1	1	<?
2		- $action = $_REQUEST["action"];
3		- switch($action){
4		- case "1":
	2	+ $action = $_REQUEST["action"];
	3	+ switch($action){
	4	+ case "1":
5	5	getContent();
6	6	break;
7		- default:
	7	+ default:
8	8	break;
9		- }
	9	+ }
10	10
11		- function getContent(){
12		- //sleep(1);
13		- $step_number = $_REQUEST["step_number"];
14		- $html = '<h2 class="StepTitle">Step '.$step_number.' Content</h2>';
15		- if($step_number == 1){
16		- $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
	11	+ function getContent(){
	12	+ //sleep(1);
	13	+ $step_number = $_REQUEST["step_number"];
	14	+ $html = '<h2 class="StepTitle">Step '.$step_number.' Content</h2>';
	15	+ if($step_number == 1){
	16	+ $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
17	17	sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
18	18	quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
19	19	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
20	20	Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
21	21	</p>';
22		- }elseif($step_number == 2){
23		- $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
	22	+ }elseif($step_number == 2){
	23	+ $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
24	24	sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
25	25	quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
26	26	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
33	33	Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
34	34	</p>';
35		- }elseif($step_number == 3){
36		- $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
	35	+ }elseif($step_number == 3){
	36	+ $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
37	37	sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
38	38	quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
39	39	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
		@@ -51,15 +51,15 @@ discard block
		block discarded – undo
51	51	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
52	52	Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
53	53	</p>';
54		- }else{
55		- $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
	54	+ }else{
	55	+ $html .='<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit,
56	56	sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam,
57	57	quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
58	58	Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
59	59	Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
60	60	</p>';
61		- }
62		- echo $html;
63		- }
	61	+ }
	62	+ echo $html;
	63	+ }
64	64
65	65	?>
66	66	\ No newline at end of file

		@@ -16,21 +16,21 @@
		block discarded – undo
16	16	/**
17	17	*
18	18	*
19		- * @var Template
	19	+ * @var Template
20	20	*/
21	21	private $template;
22	22
23	23	/**
24	24	*
25	25	*
26		- * @var Router
	26	+ * @var Router
27	27	*/
28	28	private $router;
29	29
30	30	/**
31	31	*
32	32	*
33		- * @var MenuService
	33	+ * @var MenuService
34	34	*/
35	35	private $menuService;
36	36

		@@ -11,14 +11,14 @@
		block discarded – undo
11	11	/**
12	12	*
13	13	*
14		- * @var UrlHelper
	14	+ * @var UrlHelper
15	15	*/
16	16	private $url;
17	17
18	18	/**
19	19	*
20	20	*
21		- * @var PostService
	21	+ * @var PostService
22	22	*/
23	23	private $postService;
24	24

		@@ -18,35 +18,35 @@
		block discarded – undo
18	18	/**
19	19	*
20	20	*
21		- * @var Template
	21	+ * @var Template
22	22	*/
23	23	private $template;
24	24
25	25	/**
26	26	*
27	27	*
28		- * @var Router
	28	+ * @var Router
29	29	*/
30	30	private $router;
31	31
32	32	/**
33	33	*
34	34	*
35		- * @var DiscussionService
	35	+ * @var DiscussionService
36	36	*/
37	37	private $discussionService;
38	38
39	39	/**
40	40	*
41	41	*
42		- * @var SessionManager
	42	+ * @var SessionManager
43	43	*/
44	44	private $session;
45	45
46	46	/**
47	47	*
48	48	*
49		- * @var CategoryService
	49	+ * @var CategoryService
50	50	*/
51	51	private $categoryService;
52	52

phpsrbija / unfinished

Push — master ( 262a1a...ffe0da )

Status

Category

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch