Inspection of "Merge pull request #107 from djavolak/testCbf" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 262a1a...ffe0da )

unknown

created 2017-06-20 14:37 UTC

Status

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -18,35 +18,35 @@
 block discarded – undo
     /**
 * 
      *
- * @var Template 
+     * @var Template 
 */
     private $template;
 
     /**
 * 
      *
- * @var Router 
+     * @var Router 
 */
     private $router;
 
     /**
 * 
      *
- * @var DiscussionService 
+     * @var DiscussionService 
 */
     private $discussionService;
 
     /**
 * 
      *
- * @var SessionManager 
+     * @var SessionManager 
 */
     private $session;
 
     /**
 * 
      *
- * @var CategoryService 
+     * @var CategoryService 
 */
     private $categoryService;
     

Please login to merge, or discard this patch.

packages/Article/src/Controller/PostController.php 2 patches

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -68,11 +68,11 @@  discard block
 block discarded – undo
     public function index() : HtmlResponse
     {
         $params = $this->request->getQueryParams();
-        $page   = isset($params['page']) ? $params['page'] : 1;
-        $limit  = isset($params['limit']) ? $params['limit'] : 15;
+        $page   = isset($params[ 'page' ]) ? $params[ 'page' ] : 1;
+        $limit  = isset($params[ 'limit' ]) ? $params[ 'limit' ] : 15;
         $posts  = $this->postService->fetchAllArticles($page, $limit);
 
-        return new HtmlResponse($this->template->render('article::post/index', ['list' => $posts, 'layout' => 'layout/admin']));
+        return new HtmlResponse($this->template->render('article::post/index', [ 'list' => $posts, 'layout' => 'layout/admin' ]));
     }
 
     /**
@@ -80,14 +80,14 @@  discard block
 block discarded – undo
      *
      * @return \Psr\Http\Message\ResponseInterface
      */
-    public function edit($errors = []) : \Psr\Http\Message\ResponseInterface
+    public function edit($errors = [ ]) : \Psr\Http\Message\ResponseInterface
     {
         $id         = $this->request->getAttribute('id');
         $post       = $this->postService->fetchSingleArticle($id);
         $categories = $this->categoryService->getAll();
 
-        if($this->request->getParsedBody()) {
-            $post             = (object)($this->request->getParsedBody() + (array)$post);
+        if ($this->request->getParsedBody()) {
+            $post             = (object) ($this->request->getParsedBody() + (array) $post);
             $post->article_id = $id;
         }
 
@@ -112,23 +112,23 @@  discard block
 block discarded – undo
      */
     public function save() : \Psr\Http\Message\ResponseInterface
     {
-        try{
+        try {
             $id   = $this->request->getAttribute('id');
             $user = $this->session->getStorage()->user;
             $data = $this->request->getParsedBody();
             $data += (new Request())->getFiles()->toArray();
 
-            if($id) {
+            if ($id) {
                 $this->postService->updateArticle($data, $id);
             }
-            else{
+            else {
                 $this->postService->createArticle($user, $data);
             }
         }
-        catch(FilterException $fe){
+        catch (FilterException $fe) {
             return $this->edit($fe->getArrayMessages());
         }
-        catch(\Exception $e){
+        catch (\Exception $e) {
             throw $e;
         }
 
@@ -143,15 +143,15 @@  discard block
 block discarded – undo
      */
     public function delete() : \Psr\Http\Message\ResponseInterface
     {
-        try{
+        try {
             $this->postService->deleteArticle($this->request->getAttribute('id'));
         }
-        catch(\Exception $e){
+        catch (\Exception $e) {
             throw $e;
         }
 
         return $this->response->withStatus(302)->withHeader(
-            'Location', $this->router->generateUri('admin.posts', ['action' => 'index'])
+            'Location', $this->router->generateUri('admin.posts', [ 'action' => 'index' ])
         );
     }
 }

Please login to merge, or discard this patch.

Braces +4 added lines, -8 removed lines patch added patch discarded remove patch

@@ -120,15 +120,12 @@  discard block
 block discarded – undo
 
             if($id) {
                 $this->postService->updateArticle($data, $id);
-            }
-            else{
+            } else{
                 $this->postService->createArticle($user, $data);
             }
-        }
-        catch(FilterException $fe){
+        } catch(FilterException $fe){
             return $this->edit($fe->getArrayMessages());
-        }
-        catch(\Exception $e){
+        } catch(\Exception $e){
             throw $e;
         }
 
@@ -145,8 +142,7 @@  discard block
 block discarded – undo
     {
         try{
             $this->postService->deleteArticle($this->request->getAttribute('id'));
-        }
-        catch(\Exception $e){
+        } catch(\Exception $e){
             throw $e;
         }
 

Please login to merge, or discard this patch.

packages/Article/src/Service/VideoService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -22,49 +22,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticleVideosMapper 
+     * @var ArticleVideosMapper 
 */
     private $articleVideosMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var VideoFilter 
+     * @var VideoFilter 
 */
     private $videosFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

packages/Article/src/Service/PostService.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -23,49 +23,49 @@
 block discarded – undo
     /**
 * 
      *
- * @var ArticleMapper 
+     * @var ArticleMapper 
 */
     private $articleMapper;
 
     /**
 * 
      *
- * @var ArticlePostsMapper 
+     * @var ArticlePostsMapper 
 */
     private $articlePostsMapper;
 
     /**
 * 
      *
- * @var ArticleFilter 
+     * @var ArticleFilter 
 */
     private $articleFilter;
 
     /**
 * 
      *
- * @var PostFilter 
+     * @var PostFilter 
 */
     private $postFilter;
 
     /**
 * 
      *
- * @var CategoryMapper 
+     * @var CategoryMapper 
 */
     private $categoryMapper;
 
     /**
 * 
      *
- * @var Upload 
+     * @var Upload 
 */
     private $upload;
 
     /**
 * 
      *
- * @var AdminUsersMapper 
+     * @var AdminUsersMapper 
 */
     private $adminUsersMapper;
 

Please login to merge, or discard this patch.

packages/Article/src/Service/ArticleService.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -31,9 +31,9 @@  discard block
 block discarded – undo
 
     public function getCategoryIds($articleId)
     {
-        $categories = [];
-        foreach($this->articleMapper->getCategories($articleId) as $category) {
-            $categories[] = $category->category_id;
+        $categories = [ ];
+        foreach ($this->articleMapper->getCategories($articleId) as $category) {
+            $categories[ ] = $category->category_id;
         }
 
         return $categories;
@@ -41,6 +41,6 @@  discard block
 block discarded – undo
 
     public function delete($articleId)
     {
-        $this->articleMapper->delete(['article_uuid' => $articleId]);
+        $this->articleMapper->delete([ 'article_uuid' => $articleId ]);
     }
 }

Please login to merge, or discard this patch.

packages/Article/src/Filter/ArticleFilter.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'slug',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim', 'options' => ['charlist' => '/']]],
+                'filters'    => [ [ 'name' => 'StringTrim', 'options' => [ 'charlist' => '/' ] ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'published_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'status',
                 'required' => false,
-                'filters'  => [['name' => 'Boolean']],
+                'filters'  => [ [ 'name' => 'Boolean' ] ],
                 ]
             );
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'is_wysiwyg_editor',
                 'required' => false,
-                'filters'  => [['name' => 'Boolean']],
+                'filters'  => [ [ 'name' => 'Boolean' ] ],
                 ]
             );
 

Please login to merge, or discard this patch.

packages/Article/src/Filter/DiscussionFilter.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 1500]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 1500 ] ],
                 ],
                 ]
             );

Please login to merge, or discard this patch.

packages/Article/src/Filter/VideoFilter.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'sub_title',
                 'required'   => false,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 500]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 500 ] ],
                 ],
                 ]
             );
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'lead',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'video_url',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength'],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength' ],
                 ],
                 ]
             );

Please login to merge, or discard this patch.

packages/Article/src/Filter/EventFilter.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'sub_title',
                 'required' => false,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'place_name',
                 'required' => true,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'event_url',
                 'required' => false,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -67,8 +67,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'start_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'end_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'longitude',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ] ],
                 ]
             );
 
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'latitude',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ] ],
                 ]
             );
 

Please login to merge, or discard this patch.

		@@ -68,11 +68,11 @@ discard block
		block discarded – undo
68	68	public function index() : HtmlResponse
69	69	{
70	70	$params = $this->request->getQueryParams();
71		- $page = isset($params['page']) ? $params['page'] : 1;
72		- $limit = isset($params['limit']) ? $params['limit'] : 15;
	71	+ $page = isset($params[ 'page' ]) ? $params[ 'page' ] : 1;
	72	+ $limit = isset($params[ 'limit' ]) ? $params[ 'limit' ] : 15;
73	73	$posts = $this->postService->fetchAllArticles($page, $limit);
74	74
75		- return new HtmlResponse($this->template->render('article::post/index', ['list' => $posts, 'layout' => 'layout/admin']));
	75	+ return new HtmlResponse($this->template->render('article::post/index', [ 'list' => $posts, 'layout' => 'layout/admin' ]));
76	76	}
77	77
78	78	/**
		@@ -80,14 +80,14 @@ discard block
		block discarded – undo
80	80	*
81	81	* @return \Psr\Http\Message\ResponseInterface
82	82	*/
83		- public function edit($errors = []) : \Psr\Http\Message\ResponseInterface
	83	+ public function edit($errors = [ ]) : \Psr\Http\Message\ResponseInterface
84	84	{
85	85	$id = $this->request->getAttribute('id');
86	86	$post = $this->postService->fetchSingleArticle($id);
87	87	$categories = $this->categoryService->getAll();
88	88
89		- if($this->request->getParsedBody()) {
90		- $post = (object)($this->request->getParsedBody() + (array)$post);
	89	+ if ($this->request->getParsedBody()) {
	90	+ $post = (object) ($this->request->getParsedBody() + (array) $post);
91	91	$post->article_id = $id;
92	92	}
93	93
		@@ -112,23 +112,23 @@ discard block
		block discarded – undo
112	112	*/
113	113	public function save() : \Psr\Http\Message\ResponseInterface
114	114	{
115		- try{
	115	+ try {
116	116	$id = $this->request->getAttribute('id');
117	117	$user = $this->session->getStorage()->user;
118	118	$data = $this->request->getParsedBody();
119	119	$data += (new Request())->getFiles()->toArray();
120	120
121		- if($id) {
	121	+ if ($id) {
122	122	$this->postService->updateArticle($data, $id);
123	123	}
124		- else{
	124	+ else {
125	125	$this->postService->createArticle($user, $data);
126	126	}
127	127	}
128		- catch(FilterException $fe){
	128	+ catch (FilterException $fe) {
129	129	return $this->edit($fe->getArrayMessages());
130	130	}
131		- catch(\Exception $e){
	131	+ catch (\Exception $e) {
132	132	throw $e;
133	133	}
134	134
		@@ -143,15 +143,15 @@ discard block
		block discarded – undo
143	143	*/
144	144	public function delete() : \Psr\Http\Message\ResponseInterface
145	145	{
146		- try{
	146	+ try {
147	147	$this->postService->deleteArticle($this->request->getAttribute('id'));
148	148	}
149		- catch(\Exception $e){
	149	+ catch (\Exception $e) {
150	150	throw $e;
151	151	}
152	152
153	153	return $this->response->withStatus(302)->withHeader(
154		- 'Location', $this->router->generateUri('admin.posts', ['action' => 'index'])
	154	+ 'Location', $this->router->generateUri('admin.posts', [ 'action' => 'index' ])
155	155	);
156	156	}
157	157	}

		@@ -120,15 +120,12 @@ discard block
		block discarded – undo
120	120
121	121	if($id) {
122	122	$this->postService->updateArticle($data, $id);
123		- }
124		- else{
	123	+ } else{
125	124	$this->postService->createArticle($user, $data);
126	125	}
127		- }
128		- catch(FilterException $fe){
	126	+ } catch(FilterException $fe){
129	127	return $this->edit($fe->getArrayMessages());
130		- }
131		- catch(\Exception $e){
	128	+ } catch(\Exception $e){
132	129	throw $e;
133	130	}
134	131
		@@ -145,8 +142,7 @@ discard block
		block discarded – undo
145	142	{
146	143	try{
147	144	$this->postService->deleteArticle($this->request->getAttribute('id'));
148		- }
149		- catch(\Exception $e){
	145	+ } catch(\Exception $e){
150	146	throw $e;
151	147	}
152	148

		@@ -18,35 +18,35 @@
		block discarded – undo
18	18	/**
19	19	*
20	20	*
21		- * @var Template
	21	+ * @var Template
22	22	*/
23	23	private $template;
24	24
25	25	/**
26	26	*
27	27	*
28		- * @var Router
	28	+ * @var Router
29	29	*/
30	30	private $router;
31	31
32	32	/**
33	33	*
34	34	*
35		- * @var DiscussionService
	35	+ * @var DiscussionService
36	36	*/
37	37	private $discussionService;
38	38
39	39	/**
40	40	*
41	41	*
42		- * @var SessionManager
	42	+ * @var SessionManager
43	43	*/
44	44	private $session;
45	45
46	46	/**
47	47	*
48	48	*
49		- * @var CategoryService
	49	+ * @var CategoryService
50	50	*/
51	51	private $categoryService;
52	52

		@@ -22,49 +22,49 @@
		block discarded – undo
22	22	/**
23	23	*
24	24	*
25		- * @var ArticleMapper
	25	+ * @var ArticleMapper
26	26	*/
27	27	private $articleMapper;
28	28
29	29	/**
30	30	*
31	31	*
32		- * @var ArticleVideosMapper
	32	+ * @var ArticleVideosMapper
33	33	*/
34	34	private $articleVideosMapper;
35	35
36	36	/**
37	37	*
38	38	*
39		- * @var ArticleFilter
	39	+ * @var ArticleFilter
40	40	*/
41	41	private $articleFilter;
42	42
43	43	/**
44	44	*
45	45	*
46		- * @var VideoFilter
	46	+ * @var VideoFilter
47	47	*/
48	48	private $videosFilter;
49	49
50	50	/**
51	51	*
52	52	*
53		- * @var CategoryMapper
	53	+ * @var CategoryMapper
54	54	*/
55	55	private $categoryMapper;
56	56
57	57	/**
58	58	*
59	59	*
60		- * @var Upload
	60	+ * @var Upload
61	61	*/
62	62	private $upload;
63	63
64	64	/**
65	65	*
66	66	*
67		- * @var AdminUsersMapper
	67	+ * @var AdminUsersMapper
68	68	*/
69	69	private $adminUsersMapper;
70	70

		@@ -23,49 +23,49 @@
		block discarded – undo
23	23	/**
24	24	*
25	25	*
26		- * @var ArticleMapper
	26	+ * @var ArticleMapper
27	27	*/
28	28	private $articleMapper;
29	29
30	30	/**
31	31	*
32	32	*
33		- * @var ArticlePostsMapper
	33	+ * @var ArticlePostsMapper
34	34	*/
35	35	private $articlePostsMapper;
36	36
37	37	/**
38	38	*
39	39	*
40		- * @var ArticleFilter
	40	+ * @var ArticleFilter
41	41	*/
42	42	private $articleFilter;
43	43
44	44	/**
45	45	*
46	46	*
47		- * @var PostFilter
	47	+ * @var PostFilter
48	48	*/
49	49	private $postFilter;
50	50
51	51	/**
52	52	*
53	53	*
54		- * @var CategoryMapper
	54	+ * @var CategoryMapper
55	55	*/
56	56	private $categoryMapper;
57	57
58	58	/**
59	59	*
60	60	*
61		- * @var Upload
	61	+ * @var Upload
62	62	*/
63	63	private $upload;
64	64
65	65	/**
66	66	*
67	67	*
68		- * @var AdminUsersMapper
	68	+ * @var AdminUsersMapper
69	69	*/
70	70	private $adminUsersMapper;
71	71

		@@ -31,9 +31,9 @@ discard block
		block discarded – undo
31	31
32	32	public function getCategoryIds($articleId)
33	33	{
34		- $categories = [];
35		- foreach($this->articleMapper->getCategories($articleId) as $category) {
36		- $categories[] = $category->category_id;
	34	+ $categories = [ ];
	35	+ foreach ($this->articleMapper->getCategories($articleId) as $category) {
	36	+ $categories[ ] = $category->category_id;
37	37	}
38	38
39	39	return $categories;
		@@ -41,6 +41,6 @@ discard block
		block discarded – undo
41	41
42	42	public function delete($articleId)
43	43	{
44		- $this->articleMapper->delete(['article_uuid' => $articleId]);
	44	+ $this->articleMapper->delete([ 'article_uuid' => $articleId ]);
45	45	}
46	46	}

		@@ -12,17 +12,17 @@ discard block
		block discarded – undo
12	12
13	13	public function getInputFilter()
14	14	{
15		- if(!$this->inputFilter) {
	15	+ if (!$this->inputFilter) {
16	16	$inputFilter = new InputFilter();
17	17
18	18	$inputFilter->add(
19	19	[
20	20	'name' => 'slug',
21	21	'required' => true,
22		- 'filters' => [['name' => 'StringTrim', 'options' => ['charlist' => '/']]],
	22	+ 'filters' => [ [ 'name' => 'StringTrim', 'options' => [ 'charlist' => '/' ] ] ],
23	23	'validators' => [
24		- ['name' => 'NotEmpty'],
25		- ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
	24	+ [ 'name' => 'NotEmpty' ],
	25	+ [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
26	26	],
27	27	]
28	28	);
		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	[
32	32	'name' => 'published_at',
33	33	'required' => true,
34		- 'filters' => [['name' => 'StringTrim']],
35		- 'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
	34	+ 'filters' => [ [ 'name' => 'StringTrim' ] ],
	35	+ 'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
36	36	]
37	37	);
38	38
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	[
55	55	'name' => 'status',
56	56	'required' => false,
57		- 'filters' => [['name' => 'Boolean']],
	57	+ 'filters' => [ [ 'name' => 'Boolean' ] ],
58	58	]
59	59	);
60	60
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	[
63	63	'name' => 'is_wysiwyg_editor',
64	64	'required' => false,
65		- 'filters' => [['name' => 'Boolean']],
	65	+ 'filters' => [ [ 'name' => 'Boolean' ] ],
66	66	]
67	67	);
68	68

phpsrbija / unfinished

Push — master ( 262a1a...ffe0da )

Status

Category

Indentation +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +14 added lines, -14 removed lines patch added patch discarded remove patch

Braces +4 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch