ContactUsFilter::getInputFilter() - Code Metrics - Inspection of "[WIP] ContactUs package" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#143)

unknown

created 2017-08-31 08:50 UTC

ContactUsFilter::getInputFilter() A

↳ Parent: ContactUsFilter

Complexity

Conditions	1
Paths	1

Size

Total Lines	54
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	54
rs	9.6716
c	0
b	0
f	0
cc	1
eloc	38
nc	1
nop	0

How to fix Long Method

<?php

namespace ContactUs\Filter;

use Zend\InputFilter\InputFilter;
use Zend\InputFilter\InputFilterAwareInterface;
use Zend\InputFilter\InputFilterInterface;

/**
 * Class ContactUsFilter
 *
 * @package ContactUs\Filter
 * @author  Djordje Stojiljkovic <[email protected]>
 */
class ContactUsFilter implements InputFilterAwareInterface
{
    /**
     * @var \Zend\InputFilter\InputFilter $inputFilter
     */
    protected $inputFilter;

    /**
     * @return InputFilter
     */
    public function getInputFilter()
    {
        $inputFilter = new InputFilter();

        $inputFilter
            ->add([
                'name'       => 'name',
                'required'   => true,
                'filters'    => [['name' => 'StringTrim']],
                'validators' => [
                    ['name'  => 'NotEmpty'],
                    ['name'  => 'StringLength', 'options' => ['min' => 1, 'max' => 255]],
                ],
            ])
            ->add([
                'name'       => 'email',
                'required'   => true,
                'filters'    => [['name' => 'StringTrim']],
                'validators' => [
                    ['name'  => 'NotEmpty'],
                    ['name'  => 'EmailAddress'],
                    ['name'  => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
                ]
            ])
            ->add([
                'name'       => 'phone',
                'required'   => false,
                'filters'    => [['name' => 'StringTrim']],
                'validators' => [
                    // TODO: PhoneNumber match cases.
                ]
            ])
            ->add([
                'name'       => 'subject',
                'required'   => true,
                'filters'    => [['name' => 'StringTrim']],
                'validators' => [
                    ['name'  => 'NotEmpty'],
                    ['name'  => 'StringLength', 'options' => ['min' => 5]]
                ]
            ])
            ->add([
                'name'       => 'body',
                'required'   => true,
                'filters'    => [['name' => 'StringTrim']],
                'validators' => [
                    ['name'  => 'NotEmpty'],
                    ['name'  => 'StringLength', 'options' => ['min' => 5]]
                ]
            ])
        ;

        return $inputFilter;
    }

    /**
     * @param  InputFilterInterface $inputFilter
     *
     * @return void
     *
     * @throws \Exception
     */
    public function setInputFilter(InputFilterInterface $inputFilter)
    {
        $ex = new \Exception('Not used');
        throw $ex;
    }
}

1			<?php
2
3			namespace ContactUs\Filter;
4
5			use Zend\InputFilter\InputFilter;
6			use Zend\InputFilter\InputFilterAwareInterface;
7			use Zend\InputFilter\InputFilterInterface;
8
9			/**
10			* Class ContactUsFilter
11			*
12			* @package ContactUs\Filter
13			* @author Djordje Stojiljkovic <[email protected]>
14			*/
15			class ContactUsFilter implements InputFilterAwareInterface
16			{
17			/**
18			* @var \Zend\InputFilter\InputFilter $inputFilter
19			*/
20			protected $inputFilter;
21
22			/**
23			* @return InputFilter
24			*/
25			public function getInputFilter()
26			{
27			$inputFilter = new InputFilter();
28
29			$inputFilter
30			->add([
31			'name' => 'name',
32			'required' => true,
33			'filters' => [['name' => 'StringTrim']],
34			'validators' => [
35			['name' => 'NotEmpty'],
36			['name' => 'StringLength', 'options' => ['min' => 1, 'max' => 255]],
37			],
38			])
39			->add([
40			'name' => 'email',
41			'required' => true,
42			'filters' => [['name' => 'StringTrim']],
43			'validators' => [
44			['name' => 'NotEmpty'],
45			['name' => 'EmailAddress'],
46			['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
47			]
48			])
49			->add([
50			'name' => 'phone',
51			'required' => false,
52			'filters' => [['name' => 'StringTrim']],
53			'validators' => [
54			// TODO: PhoneNumber match cases.
55			]
56			])
57			->add([
58			'name' => 'subject',
59			'required' => true,
60			'filters' => [['name' => 'StringTrim']],
61			'validators' => [
62			['name' => 'NotEmpty'],
63			['name' => 'StringLength', 'options' => ['min' => 5]]
64			]
65			])
66			->add([
67			'name' => 'body',
68			'required' => true,
69			'filters' => [['name' => 'StringTrim']],
70			'validators' => [
71			['name' => 'NotEmpty'],
72			['name' => 'StringLength', 'options' => ['min' => 5]]
73			]
74			])
75			;
76
77			return $inputFilter;
78			}
79
80			/**
81			* @param InputFilterInterface $inputFilter
82			*
83			* @return void
84			*
85			* @throws \Exception
86			*/
87			public function setInputFilter(InputFilterInterface $inputFilter)
88			{
89			$ex = new \Exception('Not used');
90			throw $ex;
91			}
92			}

phpsrbija / unfinished

Pull Request — master (#143)

ContactUsFilter::getInputFilter() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like