phpsrbija /
unfinished
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class IndexControllerFactoryTest extends \PHPUnit_Framework_TestCase |
||
| 8 | { |
||
| 9 | public function testInvokingShouldReturnExpectedInstance() |
||
| 10 | { |
||
| 11 | $templateMock = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class) |
||
| 12 | ->disableOriginalConstructor() |
||
| 13 | ->getMockForAbstractClass(); |
||
| 14 | $routerMock = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class) |
||
| 15 | ->disableOriginalConstructor() |
||
| 16 | ->getMockForAbstractClass(); |
||
| 17 | $menuServiceMock = $this->getMockBuilder(\Menu\Service\MenuService::class) |
||
| 18 | ->disableOriginalConstructor() |
||
| 19 | ->getMockForAbstractClass(); |
||
| 20 | $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class) |
||
| 21 | ->setMethods(['get']) |
||
| 22 | ->getMockForAbstractClass(); |
||
| 23 | $container->expects(static::at(0)) |
||
| 24 | ->method('get') |
||
| 25 | ->will(static::returnValue($templateMock)); |
||
| 26 | $container->expects(static::at(1)) |
||
| 27 | ->method('get') |
||
| 28 | ->will(static::returnValue($routerMock)); |
||
| 29 | $container->expects(static::at(2)) |
||
| 30 | ->method('get') |
||
| 31 | ->will(static::returnValue($menuServiceMock)); |
||
| 32 | $factory = new \Menu\Factory\Controller\IndexControllerFactory(); |
||
| 33 | static::assertInstanceOf(\Menu\Controller\IndexController::class, $factory($container)); |
||
| 34 | } |
||
| 35 | } |
||
| 36 |
