Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class DiscussionFilterTest extends \PHPUnit_Framework_TestCase |
||
| 8 | { |
||
| 9 | public function testGetInputFilterShouldReturnExpectedInstance() |
||
| 10 | { |
||
| 11 | $discussionFilter = new \Article\Filter\DiscussionFilter(); |
||
| 12 | static::assertInstanceOf(\Zend\InputFilter\InputFilter::class, $discussionFilter->getInputFilter()); |
||
| 13 | } |
||
| 14 | |||
| 15 | /** |
||
| 16 | * @expectedException \Exception |
||
| 17 | * @expectedExceptionMessage Not used |
||
| 18 | */ |
||
| 19 | public function testSetInputShouldThrowException() |
||
| 20 | { |
||
| 21 | $inputInterface = $this->getMockBuilder(\Zend\InputFilter\InputFilterInterface::class) |
||
| 22 | ->getMockForAbstractClass(); |
||
| 23 | $discussionFilter = new \Article\Filter\DiscussionFilter(); |
||
| 24 | $discussionFilter->setInputFilter($inputInterface); |
||
| 25 | } |
||
| 26 | } |
||
| 27 |