View GitHub Repository unfinished

Schedule Inspection
Subscribe
Completed
Pull Request — master (#114)
by
unknown
30:05
created
Status
Category
Toggle Patches
packages/Page/src/Controller/PageController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -47,8 +47,8 @@  discard block
 
 block discarded – undo
47 47 
     public function index(): HtmlResponse
48 48 
     {
49 49 
         $params     = $this->request->getQueryParams();
50 
-        $page       = isset($params['page']) ? $params['page'] : 1;
51 
-        $limit      = isset($params['limit']) ? $params['limit'] : 15;
50 
+        $page       = isset($params[ 'page' ]) ? $params[ 'page' ] : 1;
51 
+        $limit      = isset($params[ 'limit' ]) ? $params[ 'limit' ] : 15;
52 52 
         $pagination = $this->pageService->getPagination($page, $limit);
53 53
54 54 
         return new HtmlResponse(
 
@@ -61,14 +61,14 @@  discard block
 
 block discarded – undo
61 61 
         );
62 62 
     }
63 63
64 
-    public function edit($errors = []): HtmlResponse
64 
+    public function edit($errors = [ ]): HtmlResponse
65 65 
     {
66 66 
         $id   = $this->request->getAttribute('id');
67 67 
         $page = $this->pageService->getPage($id);
68 68
69 
-        if($this->request->getParsedBody()) {
69 
+        if ($this->request->getParsedBody()) {
70 70 
             $page = new \Page\Entity\Page();
71 
-            $page->exchangeArray($this->request->getParsedBody() + (array)$page);
71 
+            $page->exchangeArray($this->request->getParsedBody() + (array) $page);
72 72 
         }
73 73
74 74 
         return new HtmlResponse(
 
@@ -98,7 +98,7 @@  discard block
 
 block discarded – undo
98 98 
             return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin.pages'));
99 99 
         } catch (FilterException $fe) {
100 100 
             return $this->edit($fe->getArrayMessages());
101 
-        } catch(\Exception $e) {
101 
+        } catch (\Exception $e) {
102 102 
             throw $e;
103 103 
         }
104 104 
     }
Please login to merge, or discard this patch.
packages/Page/tests/Controller/PageControllerTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch 
@@ -7,7 +7,7 @@  discard block
 
 block discarded – undo
7 7 
     public function testIndexMethodShouldReturnHtmlResponse()
8 8 
     {
9 9 
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
10 
-            ->setMethods(['render'])
10 
+            ->setMethods([ 'render' ])
11 11 
             ->getMockForAbstractClass();
12 12 
         $template->expects(static::once())
13 13 
             ->method('render')
 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31 
     public function testEditMethodShouldReturnHtmlResponse()
32 32 
     {
33 33 
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
34 
-            ->setMethods(['render'])
34 
+            ->setMethods([ 'render' ])
35 35 
             ->getMockForAbstractClass();
36 36 
         $template->expects(static::once())
37 37 
             ->method('render')
 
@@ -44,7 +44,7 @@  discard block
 
 block discarded – undo
44 44 
         $request = new \Zend\Diactoros\ServerRequest();
45 45 
         $request = $request->withAttribute('action', 'edit');
46 46 
         $request = $request->withAttribute('id', 1);
47 
-        $request = $request->withParsedBody(['page' => 'test']);
47 
+        $request = $request->withParsedBody([ 'page' => 'test' ]);
48 48 
         $response = new \Zend\Diactoros\Response();
49 49 
         $pageController = new \Page\Controller\PageController(
50 50 
             $template,
 
@@ -68,7 +68,7 @@  discard block
 
 block discarded – undo
68 68 
             ->will(static::returnValue('http://unfinished.dev/admin'));
69 69 
         $request = new \Zend\Diactoros\ServerRequest();
70 70 
         $request = $request->withAttribute('action', 'save');
71 
-        $request = $request->withParsedBody(['user' => 'test']);
71 
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
72 72 
         $response = new \Zend\Diactoros\Response();
73 73 
         $pageController = new \Page\Controller\PageController(
74 74 
             $template,
 
@@ -94,7 +94,7 @@  discard block
 
 block discarded – undo
94 94 
         $request = new \Zend\Diactoros\ServerRequest();
95 95 
         $request = $request->withAttribute('action', 'save');
96 96 
         $request = $request->withAttribute('id', 2);
97 
-        $request = $request->withParsedBody(['user' => 'test']);
97 
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
98 98 
         $response = new \Zend\Diactoros\Response();
99 99 
         $pageController = new \Page\Controller\PageController(
100 100 
             $template,
 
@@ -117,13 +117,13 @@  discard block
 
 block discarded – undo
117 117 
             ->getMock();
118 118 
         $pageService->expects(static::once())
119 119 
             ->method('updatePage')
120 
-            ->willThrowException(new \Std\FilterException(['test error']));
120 
+            ->willThrowException(new \Std\FilterException([ 'test error' ]));
121 121 
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
122 122 
             ->getMockForAbstractClass();
123 123 
         $request = new \Zend\Diactoros\ServerRequest();
124 124 
         $request = $request->withAttribute('action', 'save');
125 125 
         $request = $request->withAttribute('id', 2);
126 
-        $request = $request->withParsedBody(['user' => 'test']);
126 
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
127 127 
         $response = new \Zend\Diactoros\Response();
128 128 
         $pageController = new \Page\Controller\PageController(
129 129 
             $template,
 
@@ -163,7 +163,7 @@  discard block
 
 block discarded – undo
163 163 
         $request = new \Zend\Diactoros\ServerRequest();
164 164 
         $request = $request->withAttribute('action', 'save');
165 165 
         $request = $request->withAttribute('id', 2);
166 
-        $request = $request->withParsedBody(['user' => 'test']);
166 
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
167 167 
         $response = new \Zend\Diactoros\Response();
168 168 
         $pageController = new \Page\Controller\PageController(
169 169 
             $template,
Please login to merge, or discard this patch.
packages/Page/tests/Controller/PageFactoryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@
 
 block discarded – undo
10 10 
             ->disableOriginalConstructor()
11 11 
             ->getMockForAbstractClass();
12 12 
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13 
-            ->setMethods(['get'])
13 
+            ->setMethods([ 'get' ])
14 14 
             ->getMockForAbstractClass();
15 15 
         $container->expects(static::at(0))
16 16 
             ->method('get')
Please login to merge, or discard this patch.
packages/Page/tests/Service/PageServiceFactoryTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -13,7 +13,7 @@  discard block
 
 block discarded – undo
13 13 
             ->disableOriginalConstructor()
14 14 
             ->getMockForAbstractClass();
15 15 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
16 
-            ->setMethods(['getPaginationSelect', 'getAdapter'])
16 
+            ->setMethods([ 'getPaginationSelect', 'getAdapter' ])
17 17 
             ->disableOriginalConstructor()
18 18 
             ->getMockForAbstractClass();
19 19 
         $pageMapper->expects(static::once())
 
@@ -27,11 +27,11 @@  discard block
 
 block discarded – undo
27 27 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
28 28 
             ->getMockForAbstractClass();
29 29 
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
30 
-            ->setMethods(['get'])
30 
+            ->setMethods([ 'get' ])
31 31 
             ->getMockForAbstractClass();
32 32 
         $container->expects(static::at(0))
33 33 
             ->method('get')
34 
-            ->will(static::returnValue(['upload' => ['public_path' => 'test', 'non_public_path' => 'test']]));
34 
+            ->will(static::returnValue([ 'upload' => [ 'public_path' => 'test', 'non_public_path' => 'test' ] ]));
35 35 
         $container->expects(static::at(1))
36 36 
             ->method('get')
37 37 
             ->will(static::returnValue($pageMapper));
Please login to merge, or discard this patch.
packages/Page/tests/Service/PageServiceTest.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29 
             ->disableOriginalConstructor()
30 30 
             ->getMock();
31 31 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
32 
-            ->setMethods(['select', 'current'])
32 
+            ->setMethods([ 'select', 'current' ])
33 33 
             ->disableOriginalConstructor()
34 34 
             ->getMock();
35 35 
         $pageMapper->expects(static::once())
 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
             ->disableOriginalConstructor()
56 56 
             ->getMock();
57 57 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
58 
-            ->setMethods(['getActivePage', 'current'])
58 
+            ->setMethods([ 'getActivePage', 'current' ])
59 59 
             ->disableOriginalConstructor()
60 60 
             ->getMock();
61 61 
         $pageMapper->expects(static::once())
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
             ->disableOriginalConstructor()
82 82 
             ->getMock();
83 83 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
84 
-            ->setMethods(['select', 'current'])
84 
+            ->setMethods([ 'select', 'current' ])
85 85 
             ->disableOriginalConstructor()
86 86 
             ->getMock();
87 87 
         $pageMapper->expects(static::once())
 
@@ -107,7 +107,7 @@  discard block
 
 block discarded – undo
107 107 
             'is_homepage' => 1
108 108 
         ];
109 109 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
110 
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
110 
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
111 111 
             ->disableOriginalConstructor()
112 112 
             ->getMock();
113 113 
         $pageFilter->expects(static::once())
 
@@ -123,7 +123,7 @@  discard block
 
 block discarded – undo
123 123 
             ->method('setData')
124 124 
             ->willReturnSelf();
125 125 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
126 
-            ->setMethods(['update', 'insert'])
126 
+            ->setMethods([ 'update', 'insert' ])
127 127 
             ->disableOriginalConstructor()
128 128 
             ->getMock();
129 129 
         $pageMapper->expects(static::once())
 
@@ -151,7 +151,7 @@  discard block
 
 block discarded – undo
151 151 
         ];
152 152
153 153 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
154 
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getMessages'])
154 
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getMessages' ])
155 155 
             ->disableOriginalConstructor()
156 156 
             ->getMock();
157 157 
         $pageFilter->expects(static::once())
 
@@ -162,12 +162,12 @@  discard block
 
 block discarded – undo
162 162 
             ->willReturn(false);
163 163 
         $pageFilter->expects(static::once())
164 164 
             ->method('getMessages')
165 
-            ->willReturn(['test error']);
165 
+            ->willReturn([ 'test error' ]);
166 166 
         $pageFilter->expects(static::once())
167 167 
             ->method('setData')
168 168 
             ->willReturnSelf();
169 169 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
170 
-            ->setMethods(['update', 'insert'])
170 
+            ->setMethods([ 'update', 'insert' ])
171 171 
             ->disableOriginalConstructor()
172 172 
             ->getMock();
173 173 
         $paginator = $this->getMockBuilder(\Zend\Paginator\Paginator::class)
 
@@ -191,11 +191,11 @@  discard block
 
 block discarded – undo
191 191 
             'is_homepage' => 1
192 192 
         ];
193 193 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
194 
-            ->setMethods(['select'])
194 
+            ->setMethods([ 'select' ])
195 195 
             ->disableOriginalConstructor()
196 196 
             ->getMock();
197 197 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
198 
-            ->setMethods(['select', 'current'])
198 
+            ->setMethods([ 'select', 'current' ])
199 199 
             ->disableOriginalConstructor()
200 200 
             ->getMock();
201 201 
         $pageMapper->expects(static::once())
 
@@ -225,7 +225,7 @@  discard block
 
 block discarded – undo
225 225 
             'is_homepage' => 1
226 226 
         ];
227 227 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
228 
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getMessages'])
228 
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getMessages' ])
229 229 
             ->disableOriginalConstructor()
230 230 
             ->getMock();
231 231 
         $pageFilter->expects(static::once())
 
@@ -239,9 +239,9 @@  discard block
 
 block discarded – undo
239 239 
             ->willReturn(false);
240 240 
         $pageFilter->expects(static::once())
241 241 
             ->method('getMessages')
242 
-            ->willReturn(['test error']);
242 
+            ->willReturn([ 'test error' ]);
243 243 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
244 
-            ->setMethods(['select', 'current'])
244 
+            ->setMethods([ 'select', 'current' ])
245 245 
             ->disableOriginalConstructor()
246 246 
             ->getMock();
247 247 
         $pageMapper->expects(static::once())
 
@@ -267,7 +267,7 @@  discard block
 
 block discarded – undo
267 267 
             'is_homepage' => 1
268 268 
         ];
269 269 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
270 
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues', 'select'])
270 
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues', 'select' ])
271 271 
             ->disableOriginalConstructor()
272 272 
             ->getMock();
273 273 
         $pageFilter->expects(static::once())
 
@@ -283,7 +283,7 @@  discard block
 
 block discarded – undo
283 283 
             ->method('setData')
284 284 
             ->willReturnSelf();
285 285 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
286 
-            ->setMethods(['update', 'select', 'current'])
286 
+            ->setMethods([ 'update', 'select', 'current' ])
287 287 
             ->disableOriginalConstructor()
288 288 
             ->getMock();
289 289 
         $pageMapper->expects(static::exactly(2))
 
@@ -313,7 +313,7 @@  discard block
 
 block discarded – undo
313 313 
             'main_img' => 'test_path'
314 314 
         ];
315 315 
         $pageFilter = $this->getMockBuilder(\Page\Filter\PageFilter::class)
316 
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues', 'select'])
316 
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues', 'select' ])
317 317 
             ->disableOriginalConstructor()
318 318 
             ->getMock();
319 319 
         $pageFilter->expects(static::once())
 
@@ -329,7 +329,7 @@  discard block
 
 block discarded – undo
329 329 
             ->method('setData')
330 330 
             ->willReturnSelf();
331 331 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
332 
-            ->setMethods(['update', 'select', 'current'])
332 
+            ->setMethods([ 'update', 'select', 'current' ])
333 333 
             ->disableOriginalConstructor()
334 334 
             ->getMock();
335 335 
         $pageMapper->expects(static::exactly(2))
 
@@ -358,7 +358,7 @@  discard block
 
 block discarded – undo
358 358 
             ->disableOriginalConstructor()
359 359 
             ->getMock();
360 360 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
361 
-            ->setMethods(['select', 'current', 'delete'])
361 
+            ->setMethods([ 'select', 'current', 'delete' ])
362 362 
             ->disableOriginalConstructor()
363 363 
             ->getMock();
364 364 
         $pageMapper->expects(static::once())
 
@@ -391,7 +391,7 @@  discard block
 
 block discarded – undo
391 391 
             ->disableOriginalConstructor()
392 392 
             ->getMock();
393 393 
         $pageMapper = $this->getMockBuilder(\Page\Mapper\PageMapper::class)
394 
-            ->setMethods(['select', 'current'])
394 
+            ->setMethods([ 'select', 'current' ])
395 395 
             ->disableOriginalConstructor()
396 396 
             ->getMock();
397 397 
         $pageMapper->expects(static::once())
Please login to merge, or discard this patch.
packages/Newsletter/tests/Service/NewsletterServiceTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -21,7 +21,7 @@  discard block
 
 block discarded – undo
21 21 
     public function testRegisterNewShouldReturnTrue()
22 22 
     {
23 23 
         $newsletterMapper = $this->getMockBuilder(\Newsletter\Mapper\NewsletterMapper::class)
24 
-            ->setMethods(['insert', 'select', 'current'])
24 
+            ->setMethods([ 'insert', 'select', 'current' ])
25 25 
             ->disableOriginalConstructor()
26 26 
             ->getMock();
27 27 
         $newsletterMapper->expects(static::once())
 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
     public function testRegisterNewWithExistingEmailShouldDoNothingAndReturnNull()
42 42 
     {
43 43 
         $newsletterMapper = $this->getMockBuilder(\Newsletter\Mapper\NewsletterMapper::class)
44 
-            ->setMethods(['select', 'current'])
44 
+            ->setMethods([ 'select', 'current' ])
45 45 
             ->disableOriginalConstructor()
46 46 
             ->getMock();
47 47 
         $newsletterMapper->expects(static::once())
Please login to merge, or discard this patch.
packages/Newsletter/tests/Service/NewsletterServiceFactoryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@
 
 block discarded – undo
10 10 
             ->disableOriginalConstructor()
11 11 
             ->getMockForAbstractClass();
12 12 
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13 
-            ->setMethods(['get'])
13 
+            ->setMethods([ 'get' ])
14 14 
             ->getMockForAbstractClass();
15 15 
         $container->expects(static::at(0))
16 16 
             ->method('get')
Please login to merge, or discard this patch.
packages/Newsletter/tests/Mapper/PageMapperFactoryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -10,7 +10,7 @@
 
 block discarded – undo
10 10 
             ->disableOriginalConstructor()
11 11 
             ->getMockForAbstractClass();
12 12 
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13 
-            ->setMethods(['get'])
13 
+            ->setMethods([ 'get' ])
14 14 
             ->getMockForAbstractClass();
15 15 
         $container->expects(static::at(0))
16 16 
             ->method('get')
Please login to merge, or discard this patch.
packages/Newsletter/tests/Web/Action/HelperPostActionTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -8,7 +8,7 @@  discard block
 
 block discarded – undo
8 8 
     {
9 9 
         $newsletterService = $this->getMockBuilder(\Newsletter\Service\NewsletterService::class)
10 10 
             ->disableOriginalConstructor()
11 
-            ->setMethods(['registerNew'])
11 
+            ->setMethods([ 'registerNew' ])
12 12 
             ->getMockForAbstractClass();
13 13 
         $newsletterService->expects(static::once())
14 14 
             ->method('registerNew')
 
@@ -24,14 +24,14 @@  discard block
 
 block discarded – undo
24 24 
     public function testHandlePostActionShouldReturnJsonResponseWithSuccess()
25 25 
     {
26 26 
         $newsletterService = $this->getMockBuilder(\Newsletter\Service\NewsletterService::class)
27 
-            ->setMethods(['registerNew'])
27 
+            ->setMethods([ 'registerNew' ])
28 28 
             ->disableOriginalConstructor()
29 29 
             ->getMockForAbstractClass();
30 30 
         $request = $this->getMockBuilder(\Psr\Http\Message\ServerRequestInterface::class)
31 31 
             ->getMockForAbstractClass();
32 32 
         $request->expects(static::once())
33 33 
             ->method('getParsedBody')
34 
-            ->willReturn(['email' => '[email protected]']);
34 
+            ->willReturn([ 'email' => '[email protected]' ]);
35 35 
         $response = $this->getMockBuilder(\Psr\Http\Message\ResponseInterface::class)
36 36 
             ->getMockForAbstractClass();
37 37 
         $newsletterAction = new \Newsletter\Web\Action\HandlePostAction($newsletterService);
Please login to merge, or discard this patch.