Inspection of "Update README.md" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c02965...f19773 )

by Aleksandar

created 2017-06-28 08:33 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'slug',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim', 'options' => ['charlist' => '/']]],
+                'filters'    => [ [ 'name' => 'StringTrim', 'options' => [ 'charlist' => '/' ] ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'published_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'status',
                 'required' => false,
-                'filters'  => [['name' => 'Boolean']],
+                'filters'  => [ [ 'name' => 'Boolean' ] ],
                 ]
             );
 
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'is_wysiwyg_editor',
                 'required' => false,
-                'filters'  => [['name' => 'Boolean']],
+                'filters'  => [ [ 'name' => 'Boolean' ] ],
                 ]
             );
 

Please login to merge, or discard this patch.

packages/Article/src/Filter/DiscussionFilter.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 1500]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 1500 ] ],
                 ],
                 ]
             );

Please login to merge, or discard this patch.

packages/Article/src/Filter/VideoFilter.php 1 patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'sub_title',
                 'required'   => false,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 500]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 500 ] ],
                 ],
                 ]
             );
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'lead',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -67,10 +67,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'video_url',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength'],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength' ],
                 ],
                 ]
             );

Please login to merge, or discard this patch.

packages/Article/src/Filter/EventFilter.php 1 patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'sub_title',
                 'required' => false,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'place_name',
                 'required' => true,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'event_url',
                 'required' => false,
-                'filters'  => [['name' => 'StringTrim']]
+                'filters'  => [ [ 'name' => 'StringTrim' ] ]
                 ]
             );
 
@@ -55,10 +55,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2 ] ],
                 ],
                 ]
             );
@@ -67,8 +67,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'start_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'end_at',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
                 ]
             );
 
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'longitude',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ] ],
                 ]
             );
 
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'latitude',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
-                'validators' => [['name' => 'NotEmpty']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
+                'validators' => [ [ 'name' => 'NotEmpty' ] ],
                 ]
             );
 

Please login to merge, or discard this patch.

packages/Article/src/Filter/PostFilter.php 1 patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -12,17 +12,17 @@  discard block
 block discarded – undo
 
     public function getInputFilter()
     {
-        if(!$this->inputFilter) {
+        if (!$this->inputFilter) {
             $inputFilter = new InputFilter();
 
             $inputFilter->add(
                 [
                 'name'       => 'title',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
                 ],
                 ]
             );
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'body',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100000]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100000 ] ],
                 ],
                 ]
             );
@@ -43,10 +43,10 @@  discard block
 block discarded – undo
                 [
                 'name'       => 'lead',
                 'required'   => true,
-                'filters'    => [['name' => 'StringTrim']],
+                'filters'    => [ [ 'name' => 'StringTrim' ] ],
                 'validators' => [
-                    ['name' => 'NotEmpty'],
-                    ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 50000]],
+                    [ 'name' => 'NotEmpty' ],
+                    [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 50000 ] ],
                 ],
                 ]
             );
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
                 [
                 'name'     => 'has_layout',
                 'required' => false,
-                'filters'  => [['name' => 'Boolean']],
+                'filters'  => [ [ 'name' => 'Boolean' ] ],
                 ]
             );
 

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/PostHelperTest.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -16,26 +16,26 @@
 block discarded – undo
     public function testForSelectShouldReturnArray()
     {
         $postService = $this->getMockBuilder('Article\Service\PostService')
-            ->setMethods(['getForSelect'])
+            ->setMethods([ 'getForSelect' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $postService->expects(static::once())
             ->method('getForSelect')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $postHelper = new \Article\View\Helper\PostHelper($postService);
-        static::assertSame([], $postHelper->forSelect());
+        static::assertSame([ ], $postHelper->forSelect());
     }
 
     public function testForWebShouldReturnArray()
     {
         $postService = $this->getMockBuilder('Article\Service\PostService')
-            ->setMethods(['getLatestWeb'])
+            ->setMethods([ 'getLatestWeb' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $postService->expects(static::once())
             ->method('getLatestWeb')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $postHelper = new \Article\View\Helper\PostHelper($postService);
-        static::assertSame([], $postHelper->forWeb());
+        static::assertSame([ ], $postHelper->forWeb());
     }
 }

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/VideoHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testGetLatestShouldReturnArray()
     {
         $videoService = $this->getMockBuilder('Article\Service\VideoService')
-            ->setMethods(['fetchLatest'])
+            ->setMethods([ 'fetchLatest' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $videoService->expects(static::once())
             ->method('fetchLatest')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $videoHelper = new \Article\View\Helper\VideoHelper($videoService);
-        static::assertSame([], $videoHelper->getLatest());
+        static::assertSame([ ], $videoHelper->getLatest());
     }
 }

Please login to merge, or discard this patch.

packages/Article/tests/View/Helper/EventHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testAllShouldReturnArray()
     {
         $eventService = $this->getMockBuilder('Article\Service\EventService')
-            ->setMethods(['fetchLatest'])
+            ->setMethods([ 'fetchLatest' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $eventService->expects(static::once())
             ->method('fetchLatest')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $eventHelper = new \Article\View\Helper\EventHelper($eventService);
-        static::assertSame([], $eventHelper->getLatest());
+        static::assertSame([ ], $eventHelper->getLatest());
     }
 }

Please login to merge, or discard this patch.

packages/Article/tests/Factory/View/Helper/EventHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

		@@ -12,17 +12,17 @@ discard block
		block discarded – undo
12	12
13	13	public function getInputFilter()
14	14	{
15		- if(!$this->inputFilter) {
	15	+ if (!$this->inputFilter) {
16	16	$inputFilter = new InputFilter();
17	17
18	18	$inputFilter->add(
19	19	[
20	20	'name' => 'slug',
21	21	'required' => true,
22		- 'filters' => [['name' => 'StringTrim', 'options' => ['charlist' => '/']]],
	22	+ 'filters' => [ [ 'name' => 'StringTrim', 'options' => [ 'charlist' => '/' ] ] ],
23	23	'validators' => [
24		- ['name' => 'NotEmpty'],
25		- ['name' => 'StringLength', 'options' => ['min' => 2, 'max' => 100]],
	24	+ [ 'name' => 'NotEmpty' ],
	25	+ [ 'name' => 'StringLength', 'options' => [ 'min' => 2, 'max' => 100 ] ],
26	26	],
27	27	]
28	28	);
		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	[
32	32	'name' => 'published_at',
33	33	'required' => true,
34		- 'filters' => [['name' => 'StringTrim']],
35		- 'validators' => [['name' => 'NotEmpty'], ['name' => 'Date', 'options' => ['format' => 'Y-m-d H:i:s']]]
	34	+ 'filters' => [ [ 'name' => 'StringTrim' ] ],
	35	+ 'validators' => [ [ 'name' => 'NotEmpty' ], [ 'name' => 'Date', 'options' => [ 'format' => 'Y-m-d H:i:s' ] ] ]
36	36	]
37	37	);
38	38
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	[
55	55	'name' => 'status',
56	56	'required' => false,
57		- 'filters' => [['name' => 'Boolean']],
	57	+ 'filters' => [ [ 'name' => 'Boolean' ] ],
58	58	]
59	59	);
60	60
		@@ -62,7 +62,7 @@ discard block
		block discarded – undo
62	62	[
63	63	'name' => 'is_wysiwyg_editor',
64	64	'required' => false,
65		- 'filters' => [['name' => 'Boolean']],
	65	+ 'filters' => [ [ 'name' => 'Boolean' ] ],
66	66	]
67	67	);
68	68

		@@ -16,26 +16,26 @@
		block discarded – undo
16	16	public function testForSelectShouldReturnArray()
17	17	{
18	18	$postService = $this->getMockBuilder('Article\Service\PostService')
19		- ->setMethods(['getForSelect'])
	19	+ ->setMethods([ 'getForSelect' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$postService->expects(static::once())
23	23	->method('getForSelect')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$postHelper = new \Article\View\Helper\PostHelper($postService);
26		- static::assertSame([], $postHelper->forSelect());
	26	+ static::assertSame([ ], $postHelper->forSelect());
27	27	}
28	28
29	29	public function testForWebShouldReturnArray()
30	30	{
31	31	$postService = $this->getMockBuilder('Article\Service\PostService')
32		- ->setMethods(['getLatestWeb'])
	32	+ ->setMethods([ 'getLatestWeb' ])
33	33	->disableOriginalConstructor()
34	34	->getMockForAbstractClass();
35	35	$postService->expects(static::once())
36	36	->method('getLatestWeb')
37		- ->willReturn([]);
	37	+ ->willReturn([ ]);
38	38	$postHelper = new \Article\View\Helper\PostHelper($postService);
39		- static::assertSame([], $postHelper->forWeb());
	39	+ static::assertSame([ ], $postHelper->forWeb());
40	40	}
41	41	}

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testGetLatestShouldReturnArray()
17	17	{
18	18	$videoService = $this->getMockBuilder('Article\Service\VideoService')
19		- ->setMethods(['fetchLatest'])
	19	+ ->setMethods([ 'fetchLatest' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$videoService->expects(static::once())
23	23	->method('fetchLatest')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$videoHelper = new \Article\View\Helper\VideoHelper($videoService);
26		- static::assertSame([], $videoHelper->getLatest());
	26	+ static::assertSame([ ], $videoHelper->getLatest());
27	27	}
28	28	}

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testAllShouldReturnArray()
17	17	{
18	18	$eventService = $this->getMockBuilder('Article\Service\EventService')
19		- ->setMethods(['fetchLatest'])
	19	+ ->setMethods([ 'fetchLatest' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$eventService->expects(static::once())
23	23	->method('fetchLatest')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$eventHelper = new \Article\View\Helper\EventHelper($eventService);
26		- static::assertSame([], $eventHelper->getLatest());
	26	+ static::assertSame([ ], $eventHelper->getLatest());
27	27	}
28	28	}

		@@ -10,7 +10,7 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::at(0))
16	16	->method('get')

phpsrbija / unfinished

Push — master ( c02965...f19773 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +16 added lines, -16 removed lines patch added patch discarded remove patch

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch