Inspection of "Page package; tested all but mapper." - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#114)

unknown

created 2017-06-26 20:12 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::once())
             ->method('get')

Please login to merge, or discard this patch.

packages/Page/tests/View/Helper/PageHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Page/tests/View/Helper/PageHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testForSelectShouldReturnArray()
     {
         $pageService = $this->getMockBuilder(\Page\Service\PageService::class)
-            ->setMethods(['getForSelect'])
+            ->setMethods([ 'getForSelect' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $pageService->expects(static::once())
             ->method('getForSelect')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $pageHelper = new \Page\View\Helper\PageHelper($pageService);
-        static::assertSame([], $pageHelper->forSelect());
+        static::assertSame([ ], $pageHelper->forSelect());
     }
 }

Please login to merge, or discard this patch.

packages/Page/tests/Mapper/PageMapperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Page/tests/Mapper/PageMapperTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -46,7 +46,7 @@
 block discarded – undo
             ->method('createStatement')
             ->willReturn($statementMock);
         $adapterMock = $this->getMockBuilder(\Zend\Db\Adapter\Adapter::class)
-            ->setConstructorArgs([$driverMock])
+            ->setConstructorArgs([ $driverMock ])
             ->getMockForAbstractClass();
         $resultSetMock = $this->getMockBuilder(\Zend\Db\ResultSet\HydratingResultSet::class)
             ->getMockForAbstractClass();

Please login to merge, or discard this patch.

packages/Menu/tests/Service/MenuServiceTest.php 1 patch

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

@@ -12,7 +12,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['selectAll', 'toArray'])
+            ->setMethods([ 'selectAll', 'toArray' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
             ->willReturnSelf();
         $menuMapper->expects(static::once())
             ->method('toArray')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -38,12 +38,12 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
             ->method('get')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
     public function testAddMenuItemWithPageIdShouldReturnTrue()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -72,9 +72,9 @@  discard block
 block discarded – undo
             ->willReturn(true);
         $menuFilter->expects(static::once())
             ->method('getValues')
-            ->willReturn(['page_id' => 1, 'category_id' => false, 'href' => false]);
+            ->willReturn([ 'page_id' => 1, 'category_id' => false, 'href' => false ]);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['insertMenuItem', 'get'])
+            ->setMethods([ 'insertMenuItem', 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $pageService = $this->getMockBuilder(\Page\Service\PageService::class)
-            ->setMethods(['getPage'])
+            ->setMethods([ 'getPage' ])
             ->disableOriginalConstructor()
             ->getMock();
         $pageService->expects(static::once())
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
             ->willReturn(new \Page\Entity\Page());
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
+        static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
     }
 
     public function testAddMenuItemWithCategoryIdShouldReturnTrue()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -112,27 +112,27 @@  discard block
 block discarded – undo
             ->willReturn(true);
         $menuFilter->expects(static::once())
             ->method('getValues')
-            ->willReturn(['page_id' => false, 'category_id' => 1, 'href' => false]);
+            ->willReturn([ 'page_id' => false, 'category_id' => 1, 'href' => false ]);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['insertMenuItem', 'get'])
+            ->setMethods([ 'insertMenuItem', 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
             ->method('insertMenuItem')
             ->willReturn(true);
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
-            ->setMethods(['getCategory'])
+            ->setMethods([ 'getCategory' ])
             ->disableOriginalConstructor()
             ->getMock();
         $categoryService->expects(static::once())
             ->method('getCategory')
-            ->willReturn(new ArrayObject(['category_uuid' => 'test']));
+            ->willReturn(new ArrayObject([ 'category_uuid' => 'test' ]));
         $pageService = $this->getMockBuilder(\Page\Service\PageService::class)
             ->disableOriginalConstructor()
             ->getMock();
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
+        static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
     }
 
     /**
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
     public function testAddMenuItemWithCategoryIdShouldThrowFilterException()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getMessages'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getMessages' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -156,9 +156,9 @@  discard block
 block discarded – undo
             ->willReturn(false);
         $menuFilter->expects(static::once())
             ->method('getMessages')
-            ->willReturn(['test error']);
+            ->willReturn([ 'test error' ]);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
             ->getMock();
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
+        static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
     }
 
     /**
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
     public function testAddMenuItemWithCategoryIdShouldThrowException()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
             ->method('isValid')
             ->willReturn(true);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
@@ -203,13 +203,13 @@  discard block
 block discarded – undo
             ->getMock();
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => 1, 'href' => 1]));
+        static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => 1, 'href' => 1 ]));
     }
 
     public function testAddMenuItemWithHrefShouldReturnTrue()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -223,9 +223,9 @@  discard block
 block discarded – undo
             ->willReturn(true);
         $menuFilter->expects(static::once())
             ->method('getValues')
-            ->willReturn(['page_id' => false, 'category_id' => false, 'href' => 'test']);
+            ->willReturn([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['insertMenuItem', 'get'])
+            ->setMethods([ 'insertMenuItem', 'get' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -239,13 +239,13 @@  discard block
 block discarded – undo
             ->getMock();
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->addMenuItem(['page_id' => false, 'category_id' => false, 'href' => 'test']));
+        static::assertSame(true, $menuService->addMenuItem([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]));
     }
 
     public function testUpdateMenuItemShouldReturnTrue()
     {
         $menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
-            ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
+            ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuFilter->expects(static::once())
@@ -259,9 +259,9 @@  discard block
 block discarded – undo
             ->willReturn(true);
         $menuFilter->expects(static::once())
             ->method('getValues')
-            ->willReturn(['page_id' => false, 'category_id' => false, 'href' => 'test']);
+            ->willReturn([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]);
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['updateMenuItem'])
+            ->setMethods([ 'updateMenuItem' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
             ->getMock();
         $menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
 
-        static::assertSame(true, $menuService->updateMenuItem(['page_id' => false, 'category_id' => false, 'href' => 'test'], 1));
+        static::assertSame(true, $menuService->updateMenuItem([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ], 1));
     }
 
     public function testDeleteShouldReturnTrue()
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['select', 'delete'])
+            ->setMethods([ 'select', 'delete' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
     public function testDeleteShouldThrowException()
     {
         $resultSet = $this->getMockBuilder(\Zend\Db\ResultSet\ResultSet::class)
-            ->setMethods(['count'])
+            ->setMethods([ 'count' ])
             ->getMockForAbstractClass();
         $resultSet->expects(static::once())
             ->method('count')
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['select'])
+            ->setMethods([ 'select' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
-            ->setMethods(['forSelect'])
+            ->setMethods([ 'forSelect' ])
             ->disableOriginalConstructor()
             ->getMock();
         $menuMapper->expects(static::once())

Please login to merge, or discard this patch.

packages/Menu/tests/View/Helper/MenuItemsTest.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -16,52 +16,52 @@
 block discarded – undo
     public function testForMenuShouldReturnArray()
     {
         $menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
-            ->setMethods(['getNestedAll'])
+            ->setMethods([ 'getNestedAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $menuService->expects(static::once())
             ->method('getNestedAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $menuHelper = new \Menu\View\Helper\MenuItems($menuService);
-        static::assertSame([], $menuHelper->forMenu());
+        static::assertSame([ ], $menuHelper->forMenu());
     }
 
     public function testGetHeaderMenuShouldReturnArray()
     {
         $menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
-            ->setMethods(['getNestedAll'])
+            ->setMethods([ 'getNestedAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $menuService->expects(static::once())
             ->method('getNestedAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $menuHelper = new \Menu\View\Helper\MenuItems($menuService);
-        static::assertSame([], $menuHelper->getHeaderMenu());
+        static::assertSame([ ], $menuHelper->getHeaderMenu());
     }
 
     public function testGetFooterShouldReturnArray()
     {
         $menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
-            ->setMethods(['getNestedAll'])
+            ->setMethods([ 'getNestedAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $menuService->expects(static::once())
             ->method('getNestedAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $menuHelper = new \Menu\View\Helper\MenuItems($menuService);
-        static::assertSame([], $menuHelper->getFooterMenu());
+        static::assertSame([ ], $menuHelper->getFooterMenu());
     }
 
     public function testGetSideMenuShouldReturnArray()
     {
         $menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
-            ->setMethods(['getNestedAll'])
+            ->setMethods([ 'getNestedAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $menuService->expects(static::once())
             ->method('getNestedAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $menuHelper = new \Menu\View\Helper\MenuItems($menuService);
-        static::assertSame([], $menuHelper->getSideMenu());
+        static::assertSame([ ], $menuHelper->getSideMenu());
     }
 }

Please login to merge, or discard this patch.

packages/Menu/tests/View/Helper/MenuUrlHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Menu/tests/View/Helper/MenuItemsFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

		@@ -10,7 +10,7 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::once())
16	16	->method('get')

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testForSelectShouldReturnArray()
17	17	{
18	18	$pageService = $this->getMockBuilder(\Page\Service\PageService::class)
19		- ->setMethods(['getForSelect'])
	19	+ ->setMethods([ 'getForSelect' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$pageService->expects(static::once())
23	23	->method('getForSelect')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$pageHelper = new \Page\View\Helper\PageHelper($pageService);
26		- static::assertSame([], $pageHelper->forSelect());
	26	+ static::assertSame([ ], $pageHelper->forSelect());
27	27	}
28	28	}

		@@ -46,7 +46,7 @@
		block discarded – undo
46	46	->method('createStatement')
47	47	->willReturn($statementMock);
48	48	$adapterMock = $this->getMockBuilder(\Zend\Db\Adapter\Adapter::class)
49		- ->setConstructorArgs([$driverMock])
	49	+ ->setConstructorArgs([ $driverMock ])
50	50	->getMockForAbstractClass();
51	51	$resultSetMock = $this->getMockBuilder(\Zend\Db\ResultSet\HydratingResultSet::class)
52	52	->getMockForAbstractClass();

		@@ -12,7 +12,7 @@ discard block
		block discarded – undo
12	12	->disableOriginalConstructor()
13	13	->getMock();
14	14	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
15		- ->setMethods(['selectAll', 'toArray'])
	15	+ ->setMethods([ 'selectAll', 'toArray' ])
16	16	->disableOriginalConstructor()
17	17	->getMock();
18	18	$menuMapper->expects(static::once())
		@@ -20,7 +20,7 @@ discard block
		block discarded – undo
20	20	->willReturnSelf();
21	21	$menuMapper->expects(static::once())
22	22	->method('toArray')
23		- ->willReturn([]);
	23	+ ->willReturn([ ]);
24	24	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
25	25	->disableOriginalConstructor()
26	26	->getMock();
		@@ -38,12 +38,12 @@ discard block
		block discarded – undo
38	38	->disableOriginalConstructor()
39	39	->getMock();
40	40	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
41		- ->setMethods(['get'])
	41	+ ->setMethods([ 'get' ])
42	42	->disableOriginalConstructor()
43	43	->getMock();
44	44	$menuMapper->expects(static::once())
45	45	->method('get')
46		- ->willReturn([]);
	46	+ ->willReturn([ ]);
47	47	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
48	48	->disableOriginalConstructor()
49	49	->getMock();
		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	public function testAddMenuItemWithPageIdShouldReturnTrue()
59	59	{
60	60	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
61		- ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
	61	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
62	62	->disableOriginalConstructor()
63	63	->getMock();
64	64	$menuFilter->expects(static::once())
		@@ -72,9 +72,9 @@ discard block
		block discarded – undo
72	72	->willReturn(true);
73	73	$menuFilter->expects(static::once())
74	74	->method('getValues')
75		- ->willReturn(['page_id' => 1, 'category_id' => false, 'href' => false]);
	75	+ ->willReturn([ 'page_id' => 1, 'category_id' => false, 'href' => false ]);
76	76	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
77		- ->setMethods(['insertMenuItem', 'get'])
	77	+ ->setMethods([ 'insertMenuItem', 'get' ])
78	78	->disableOriginalConstructor()
79	79	->getMock();
80	80	$menuMapper->expects(static::once())
		@@ -84,7 +84,7 @@ discard block
		block discarded – undo
84	84	->disableOriginalConstructor()
85	85	->getMock();
86	86	$pageService = $this->getMockBuilder(\Page\Service\PageService::class)
87		- ->setMethods(['getPage'])
	87	+ ->setMethods([ 'getPage' ])
88	88	->disableOriginalConstructor()
89	89	->getMock();
90	90	$pageService->expects(static::once())
		@@ -92,13 +92,13 @@ discard block
		block discarded – undo
92	92	->willReturn(new \Page\Entity\Page());
93	93	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
94	94
95		- static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
	95	+ static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
96	96	}
97	97
98	98	public function testAddMenuItemWithCategoryIdShouldReturnTrue()
99	99	{
100	100	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
101		- ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
	101	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
102	102	->disableOriginalConstructor()
103	103	->getMock();
104	104	$menuFilter->expects(static::once())
		@@ -112,27 +112,27 @@ discard block
		block discarded – undo
112	112	->willReturn(true);
113	113	$menuFilter->expects(static::once())
114	114	->method('getValues')
115		- ->willReturn(['page_id' => false, 'category_id' => 1, 'href' => false]);
	115	+ ->willReturn([ 'page_id' => false, 'category_id' => 1, 'href' => false ]);
116	116	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
117		- ->setMethods(['insertMenuItem', 'get'])
	117	+ ->setMethods([ 'insertMenuItem', 'get' ])
118	118	->disableOriginalConstructor()
119	119	->getMock();
120	120	$menuMapper->expects(static::once())
121	121	->method('insertMenuItem')
122	122	->willReturn(true);
123	123	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
124		- ->setMethods(['getCategory'])
	124	+ ->setMethods([ 'getCategory' ])
125	125	->disableOriginalConstructor()
126	126	->getMock();
127	127	$categoryService->expects(static::once())
128	128	->method('getCategory')
129		- ->willReturn(new ArrayObject(['category_uuid' => 'test']));
	129	+ ->willReturn(new ArrayObject([ 'category_uuid' => 'test' ]));
130	130	$pageService = $this->getMockBuilder(\Page\Service\PageService::class)
131	131	->disableOriginalConstructor()
132	132	->getMock();
133	133	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
134	134
135		- static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
	135	+ static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
136	136	}
137	137
138	138	/**
		@@ -142,7 +142,7 @@ discard block
		block discarded – undo
142	142	public function testAddMenuItemWithCategoryIdShouldThrowFilterException()
143	143	{
144	144	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
145		- ->setMethods(['getInputFilter', 'setData', 'isValid', 'getMessages'])
	145	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getMessages' ])
146	146	->disableOriginalConstructor()
147	147	->getMock();
148	148	$menuFilter->expects(static::once())
		@@ -156,9 +156,9 @@ discard block
		block discarded – undo
156	156	->willReturn(false);
157	157	$menuFilter->expects(static::once())
158	158	->method('getMessages')
159		- ->willReturn(['test error']);
	159	+ ->willReturn([ 'test error' ]);
160	160	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
161		- ->setMethods(['get'])
	161	+ ->setMethods([ 'get' ])
162	162	->disableOriginalConstructor()
163	163	->getMock();
164	164	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169	->getMock();
170	170	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
171	171
172		- static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => false, 'href' => false]));
	172	+ static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => false, 'href' => false ]));
173	173	}
174	174
175	175	/**
		@@ -179,7 +179,7 @@ discard block
		block discarded – undo
179	179	public function testAddMenuItemWithCategoryIdShouldThrowException()
180	180	{
181	181	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
182		- ->setMethods(['getInputFilter', 'setData', 'isValid'])
	182	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid' ])
183	183	->disableOriginalConstructor()
184	184	->getMock();
185	185	$menuFilter->expects(static::once())
		@@ -192,7 +192,7 @@ discard block
		block discarded – undo
192	192	->method('isValid')
193	193	->willReturn(true);
194	194	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
195		- ->setMethods(['get'])
	195	+ ->setMethods([ 'get' ])
196	196	->disableOriginalConstructor()
197	197	->getMock();
198	198	$categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
		@@ -203,13 +203,13 @@ discard block
		block discarded – undo
203	203	->getMock();
204	204	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
205	205
206		- static::assertSame(true, $menuService->addMenuItem(['page_id' => 1, 'category_id' => 1, 'href' => 1]));
	206	+ static::assertSame(true, $menuService->addMenuItem([ 'page_id' => 1, 'category_id' => 1, 'href' => 1 ]));
207	207	}
208	208
209	209	public function testAddMenuItemWithHrefShouldReturnTrue()
210	210	{
211	211	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
212		- ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
	212	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
213	213	->disableOriginalConstructor()
214	214	->getMock();
215	215	$menuFilter->expects(static::once())
		@@ -223,9 +223,9 @@ discard block
		block discarded – undo
223	223	->willReturn(true);
224	224	$menuFilter->expects(static::once())
225	225	->method('getValues')
226		- ->willReturn(['page_id' => false, 'category_id' => false, 'href' => 'test']);
	226	+ ->willReturn([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]);
227	227	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
228		- ->setMethods(['insertMenuItem', 'get'])
	228	+ ->setMethods([ 'insertMenuItem', 'get' ])
229	229	->disableOriginalConstructor()
230	230	->getMock();
231	231	$menuMapper->expects(static::once())
		@@ -239,13 +239,13 @@ discard block
		block discarded – undo
239	239	->getMock();
240	240	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
241	241
242		- static::assertSame(true, $menuService->addMenuItem(['page_id' => false, 'category_id' => false, 'href' => 'test']));
	242	+ static::assertSame(true, $menuService->addMenuItem([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]));
243	243	}
244	244
245	245	public function testUpdateMenuItemShouldReturnTrue()
246	246	{
247	247	$menuFilter = $this->getMockBuilder(\Menu\Filter\MenuFilter::class)
248		- ->setMethods(['getInputFilter', 'setData', 'isValid', 'getValues'])
	248	+ ->setMethods([ 'getInputFilter', 'setData', 'isValid', 'getValues' ])
249	249	->disableOriginalConstructor()
250	250	->getMock();
251	251	$menuFilter->expects(static::once())
		@@ -259,9 +259,9 @@ discard block
		block discarded – undo
259	259	->willReturn(true);
260	260	$menuFilter->expects(static::once())
261	261	->method('getValues')
262		- ->willReturn(['page_id' => false, 'category_id' => false, 'href' => 'test']);
	262	+ ->willReturn([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ]);
263	263	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
264		- ->setMethods(['updateMenuItem'])
	264	+ ->setMethods([ 'updateMenuItem' ])
265	265	->disableOriginalConstructor()
266	266	->getMock();
267	267	$menuMapper->expects(static::once())
		@@ -275,7 +275,7 @@ discard block
		block discarded – undo
275	275	->getMock();
276	276	$menuService = new \Menu\Service\MenuService($menuMapper, $menuFilter, $categoryService, $pageService);
277	277
278		- static::assertSame(true, $menuService->updateMenuItem(['page_id' => false, 'category_id' => false, 'href' => 'test'], 1));
	278	+ static::assertSame(true, $menuService->updateMenuItem([ 'page_id' => false, 'category_id' => false, 'href' => 'test' ], 1));
279	279	}
280	280
281	281	public function testDeleteShouldReturnTrue()
		@@ -284,7 +284,7 @@ discard block
		block discarded – undo
284	284	->disableOriginalConstructor()
285	285	->getMock();
286	286	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
287		- ->setMethods(['select', 'delete'])
	287	+ ->setMethods([ 'select', 'delete' ])
288	288	->disableOriginalConstructor()
289	289	->getMock();
290	290	$menuMapper->expects(static::once())
		@@ -311,7 +311,7 @@ discard block
		block discarded – undo
311	311	public function testDeleteShouldThrowException()
312	312	{
313	313	$resultSet = $this->getMockBuilder(\Zend\Db\ResultSet\ResultSet::class)
314		- ->setMethods(['count'])
	314	+ ->setMethods([ 'count' ])
315	315	->getMockForAbstractClass();
316	316	$resultSet->expects(static::once())
317	317	->method('count')
		@@ -320,7 +320,7 @@ discard block
		block discarded – undo
320	320	->disableOriginalConstructor()
321	321	->getMock();
322	322	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
323		- ->setMethods(['select'])
	323	+ ->setMethods([ 'select' ])
324	324	->disableOriginalConstructor()
325	325	->getMock();
326	326	$menuMapper->expects(static::once())
		@@ -343,7 +343,7 @@ discard block
		block discarded – undo
343	343	->disableOriginalConstructor()
344	344	->getMock();
345	345	$menuMapper = $this->getMockBuilder(\Menu\Mapper\MenuMapper::class)
346		- ->setMethods(['forSelect'])
	346	+ ->setMethods([ 'forSelect' ])
347	347	->disableOriginalConstructor()
348	348	->getMock();
349	349	$menuMapper->expects(static::once())

		@@ -16,52 +16,52 @@
		block discarded – undo
16	16	public function testForMenuShouldReturnArray()
17	17	{
18	18	$menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
19		- ->setMethods(['getNestedAll'])
	19	+ ->setMethods([ 'getNestedAll' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$menuService->expects(static::once())
23	23	->method('getNestedAll')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$menuHelper = new \Menu\View\Helper\MenuItems($menuService);
26		- static::assertSame([], $menuHelper->forMenu());
	26	+ static::assertSame([ ], $menuHelper->forMenu());
27	27	}
28	28
29	29	public function testGetHeaderMenuShouldReturnArray()
30	30	{
31	31	$menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
32		- ->setMethods(['getNestedAll'])
	32	+ ->setMethods([ 'getNestedAll' ])
33	33	->disableOriginalConstructor()
34	34	->getMockForAbstractClass();
35	35	$menuService->expects(static::once())
36	36	->method('getNestedAll')
37		- ->willReturn([]);
	37	+ ->willReturn([ ]);
38	38	$menuHelper = new \Menu\View\Helper\MenuItems($menuService);
39		- static::assertSame([], $menuHelper->getHeaderMenu());
	39	+ static::assertSame([ ], $menuHelper->getHeaderMenu());
40	40	}
41	41
42	42	public function testGetFooterShouldReturnArray()
43	43	{
44	44	$menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
45		- ->setMethods(['getNestedAll'])
	45	+ ->setMethods([ 'getNestedAll' ])
46	46	->disableOriginalConstructor()
47	47	->getMockForAbstractClass();
48	48	$menuService->expects(static::once())
49	49	->method('getNestedAll')
50		- ->willReturn([]);
	50	+ ->willReturn([ ]);
51	51	$menuHelper = new \Menu\View\Helper\MenuItems($menuService);
52		- static::assertSame([], $menuHelper->getFooterMenu());
	52	+ static::assertSame([ ], $menuHelper->getFooterMenu());
53	53	}
54	54
55	55	public function testGetSideMenuShouldReturnArray()
56	56	{
57	57	$menuService = $this->getMockBuilder(\Menu\Service\MenuService::class)
58		- ->setMethods(['getNestedAll'])
	58	+ ->setMethods([ 'getNestedAll' ])
59	59	->disableOriginalConstructor()
60	60	->getMockForAbstractClass();
61	61	$menuService->expects(static::once())
62	62	->method('getNestedAll')
63		- ->willReturn([]);
	63	+ ->willReturn([ ]);
64	64	$menuHelper = new \Menu\View\Helper\MenuItems($menuService);
65		- static::assertSame([], $menuHelper->getSideMenu());
	65	+ static::assertSame([ ], $menuHelper->getSideMenu());
66	66	}
67	67	}

phpsrbija / unfinished

Pull Request — master (#114)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +34 added lines, -34 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch