Inspection of "Last commit before we go public :)" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f5e198...1a7910 )

by Aleksandar

created 2017-06-30 09:32 UTC

Status

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
     public function testEditMethodShouldReturnHtmlResponseAndGetIdFromRequest()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -117,13 +117,13 @@  discard block
 block discarded – undo
             ->getMock();
         $categoryService->expects(static::once())
             ->method('updateCategory')
-            ->willThrowException(new \Std\FilterException(['test error']));
+            ->willThrowException(new \Std\FilterException([ 'test error' ]));
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
             ->getMockForAbstractClass();
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['category' => 'test']);
+        $request = $request->withParsedBody([ 'category' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $indexController = new \Category\Controller\IndexController(
             $template,

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/View/Helper/AdminUserHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/View/Helper/WebAdminUserHelperFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/Controller/UserFactoryTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -12,11 +12,11 @@
 block discarded – undo
             ->getMockForAbstractClass();
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $session = new \Zend\Session\SessionManager();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/Factory/Controller/AuthFactoryTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -10,7 +10,7 @@
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
-            ->setMethods(['get'])
+            ->setMethods([ 'get' ])
             ->getMockForAbstractClass();
         $container->expects(static::at(0))
             ->method('get')

Please login to merge, or discard this patch.

packages/Admin/tests/View/Helper/AdminUserHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -34,13 +34,13 @@
 block discarded – undo
     {
         $session = new \Zend\Session\SessionManager();
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
-            ->setMethods(['getAll'])
+            ->setMethods([ 'getAll' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('getAll')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $adminUserHelper = new \Admin\View\Helper\AdminUserHelper($session, $adminUserService);
-        static::assertSame([], $adminUserHelper->all());
+        static::assertSame([ ], $adminUserHelper->all());
     }
 }

Please login to merge, or discard this patch.

packages/Admin/tests/View/Helper/WebAdminUserHelperTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -16,13 +16,13 @@
 block discarded – undo
     public function testGetRandomShouldReturnArray()
     {
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
-            ->setMethods(['getForWeb'])
+            ->setMethods([ 'getForWeb' ])
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('getForWeb')
-            ->willReturn([]);
+            ->willReturn([ ]);
         $adminUserHelper = new \Admin\View\Helper\WebAdminUserHelper($adminUserService);
-        static::assertSame([], $adminUserHelper->getRandom());
+        static::assertSame([ ], $adminUserHelper->getRandom());
     }
 }

Please login to merge, or discard this patch.

packages/Admin/tests/Controller/AuthControllerTest.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -15,13 +15,13 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'login');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
-            ->setMethods(['getStorage', 'writeClose'])
+            ->setMethods([ 'getStorage', 'writeClose' ])
             ->getMock();
         $sessionManager->expects(static::at(0))
             ->method('getStorage')
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
         /** @var \Zend\Diactoros\Response\EmptyResponse $response */
         $response = $auth($request, $response);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testIfUserNotLoggedInLoginActionShouldTakeHimToLoginHtmlPage()
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
             ->disableOriginalConstructor()
             ->getMockForAbstractClass();
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::at(0))
             ->method('render')
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
             ->getMockForAbstractClass();
         $sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
-            ->setMethods(['getStorage', 'writeClose'])
+            ->setMethods([ 'getStorage', 'writeClose' ])
             ->getMock();
         $sessionManager->expects(static::at(0))
             ->method('getStorage')
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'logout');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -96,14 +96,14 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertNull($sessionManager->getStorage()->user);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWithCorrectCredentialsShouldSetUserInSessionStorage()
     {
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('loginUser')
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -135,14 +135,14 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertTrue($sessionManager->getStorage()->user->isLoggedIn);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWithWrongCredentialsShouldNotSetUserInSessionStorage()
     {
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
             ->getMockForAbstractClass();
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
         $response = $auth($request, $response);
         static::assertNull($sessionManager->getStorage()->user);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleWitAlreadyLoggedInUserShouldRedirectToAdminPage()
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
         $request = $request->withAttribute('action', 'loginHandle');
         $response = new \Zend\Diactoros\Response\EmptyResponse();
         $router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
-            ->setMethods(['generateUri'])
+            ->setMethods([ 'generateUri' ])
             ->getMockForAbstractClass();
         $router->expects(static::at(0))
             ->method('generateUri')
@@ -196,14 +196,14 @@  discard block
 block discarded – undo
         /** @var \Zend\Diactoros\Response\HtmlResponse $response */
         $response = $auth($request, $response);
         static::assertSame(302, $response->getStatusCode());
-        static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
+        static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
     }
 
     public function testUserLoginHandleShouldThrowExceptionAndDisplayMessage()
     {
         $adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
             ->disableOriginalConstructor()
-            ->setMethods(['loginUser'])
+            ->setMethods([ 'loginUser' ])
             ->getMockForAbstractClass();
         $adminUserService->expects(static::once())
             ->method('loginUser')
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
             ->method('render')
             ->will(static::returnCallback(
                 function($tpl, $error) {
-                    return $error['error'];
+                    return $error[ 'error' ];
                 }
             ));
         $request = new \Zend\Diactoros\ServerRequest();

Please login to merge, or discard this patch.

packages/Article/tests/Controller/DiscussionControllerTest.php 1 patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch

@@ -7,7 +7,7 @@  discard block
 block discarded – undo
     public function testIndexMethodShouldReturnHtmlResponse()
     {
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
         $sessionStorage = new \Zend\Session\Storage\ArrayStorage();
         $sessionStorage->user = $user;
         $template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
-            ->setMethods(['render'])
+            ->setMethods([ 'render' ])
             ->getMockForAbstractClass();
         $template->expects(static::once())
             ->method('render')
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'edit');
         $request = $request->withAttribute('id', 1);
-        $request = $request->withParsedBody(['discussion' => 'test']);
+        $request = $request->withParsedBody([ 'discussion' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
             ->will(static::returnValue('http://unfinished.dev/admin'));
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
             ->getMock();
         $discussionService->expects(static::once())
             ->method('updateArticle')
-            ->willThrowException(new \Std\FilterException(['test error']));
+            ->willThrowException(new \Std\FilterException([ 'test error' ]));
         $categoryService = $this->getMockBuilder(\Category\Service\CategoryService::class)
             ->disableOriginalConstructor()
             ->getMock();
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
         $request = new \Zend\Diactoros\ServerRequest();
         $request = $request->withAttribute('action', 'save');
         $request = $request->withAttribute('id', 2);
-        $request = $request->withParsedBody(['user' => 'test']);
+        $request = $request->withParsedBody([ 'user' => 'test' ]);
         $response = new \Zend\Diactoros\Response();
         $discussionController = new \Article\Controller\DiscussionController(
             $template,

Please login to merge, or discard this patch.

		@@ -7,7 +7,7 @@ discard block
		block discarded – undo
7	7	public function testIndexMethodShouldReturnHtmlResponse()
8	8	{
9	9	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
10		- ->setMethods(['render'])
	10	+ ->setMethods([ 'render' ])
11	11	->getMockForAbstractClass();
12	12	$template->expects(static::once())
13	13	->method('render')
		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31	public function testEditMethodShouldReturnHtmlResponseAndGetIdFromRequest()
32	32	{
33	33	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
34		- ->setMethods(['render'])
	34	+ ->setMethods([ 'render' ])
35	35	->getMockForAbstractClass();
36	36	$template->expects(static::once())
37	37	->method('render')
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$request = new \Zend\Diactoros\ServerRequest();
45	45	$request = $request->withAttribute('action', 'edit');
46	46	$request = $request->withAttribute('id', 1);
47		- $request = $request->withParsedBody(['category' => 'test']);
	47	+ $request = $request->withParsedBody([ 'category' => 'test' ]);
48	48	$response = new \Zend\Diactoros\Response();
49	49	$indexController = new \Category\Controller\IndexController(
50	50	$template,
		@@ -68,7 +68,7 @@ discard block
		block discarded – undo
68	68	->will(static::returnValue('http://unfinished.dev/admin'));
69	69	$request = new \Zend\Diactoros\ServerRequest();
70	70	$request = $request->withAttribute('action', 'save');
71		- $request = $request->withParsedBody(['category' => 'test']);
	71	+ $request = $request->withParsedBody([ 'category' => 'test' ]);
72	72	$response = new \Zend\Diactoros\Response();
73	73	$indexController = new \Category\Controller\IndexController(
74	74	$template,
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94	$request = new \Zend\Diactoros\ServerRequest();
95	95	$request = $request->withAttribute('action', 'save');
96	96	$request = $request->withAttribute('id', 1);
97		- $request = $request->withParsedBody(['category' => 'test']);
	97	+ $request = $request->withParsedBody([ 'category' => 'test' ]);
98	98	$response = new \Zend\Diactoros\Response();
99	99	$indexController = new \Category\Controller\IndexController(
100	100	$template,
		@@ -117,13 +117,13 @@ discard block
		block discarded – undo
117	117	->getMock();
118	118	$categoryService->expects(static::once())
119	119	->method('updateCategory')
120		- ->willThrowException(new \Std\FilterException(['test error']));
	120	+ ->willThrowException(new \Std\FilterException([ 'test error' ]));
121	121	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
122	122	->getMockForAbstractClass();
123	123	$request = new \Zend\Diactoros\ServerRequest();
124	124	$request = $request->withAttribute('action', 'save');
125	125	$request = $request->withAttribute('id', 2);
126		- $request = $request->withParsedBody(['category' => 'test']);
	126	+ $request = $request->withParsedBody([ 'category' => 'test' ]);
127	127	$response = new \Zend\Diactoros\Response();
128	128	$indexController = new \Category\Controller\IndexController(
129	129	$template,
		@@ -155,7 +155,7 @@ discard block
		block discarded – undo
155	155	$request = new \Zend\Diactoros\ServerRequest();
156	156	$request = $request->withAttribute('action', 'save');
157	157	$request = $request->withAttribute('id', 2);
158		- $request = $request->withParsedBody(['user' => 'test']);
	158	+ $request = $request->withParsedBody([ 'user' => 'test' ]);
159	159	$response = new \Zend\Diactoros\Response();
160	160	$indexController = new \Category\Controller\IndexController(
161	161	$template,

		@@ -10,7 +10,7 @@
		block discarded – undo
10	10	->disableOriginalConstructor()
11	11	->getMockForAbstractClass();
12	12	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
13		- ->setMethods(['get'])
	13	+ ->setMethods([ 'get' ])
14	14	->getMockForAbstractClass();
15	15	$container->expects(static::at(0))
16	16	->method('get')

		@@ -12,11 +12,11 @@
		block discarded – undo
12	12	->getMockForAbstractClass();
13	13	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
14	14	->disableOriginalConstructor()
15		- ->setMethods(['loginUser'])
	15	+ ->setMethods([ 'loginUser' ])
16	16	->getMockForAbstractClass();
17	17	$session = new \Zend\Session\SessionManager();
18	18	$container = $this->getMockBuilder(\Interop\Container\ContainerInterface::class)
19		- ->setMethods(['get'])
	19	+ ->setMethods([ 'get' ])
20	20	->getMockForAbstractClass();
21	21	$container->expects(static::at(0))
22	22	->method('get')

		@@ -34,13 +34,13 @@
		block discarded – undo
34	34	{
35	35	$session = new \Zend\Session\SessionManager();
36	36	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
37		- ->setMethods(['getAll'])
	37	+ ->setMethods([ 'getAll' ])
38	38	->disableOriginalConstructor()
39	39	->getMockForAbstractClass();
40	40	$adminUserService->expects(static::once())
41	41	->method('getAll')
42		- ->willReturn([]);
	42	+ ->willReturn([ ]);
43	43	$adminUserHelper = new \Admin\View\Helper\AdminUserHelper($session, $adminUserService);
44		- static::assertSame([], $adminUserHelper->all());
	44	+ static::assertSame([ ], $adminUserHelper->all());
45	45	}
46	46	}

		@@ -16,13 +16,13 @@
		block discarded – undo
16	16	public function testGetRandomShouldReturnArray()
17	17	{
18	18	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
19		- ->setMethods(['getForWeb'])
	19	+ ->setMethods([ 'getForWeb' ])
20	20	->disableOriginalConstructor()
21	21	->getMockForAbstractClass();
22	22	$adminUserService->expects(static::once())
23	23	->method('getForWeb')
24		- ->willReturn([]);
	24	+ ->willReturn([ ]);
25	25	$adminUserHelper = new \Admin\View\Helper\WebAdminUserHelper($adminUserService);
26		- static::assertSame([], $adminUserHelper->getRandom());
	26	+ static::assertSame([ ], $adminUserHelper->getRandom());
27	27	}
28	28	}

		@@ -15,13 +15,13 @@ discard block
		block discarded – undo
15	15	$request = $request->withAttribute('action', 'login');
16	16	$response = new \Zend\Diactoros\Response\EmptyResponse();
17	17	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
18		- ->setMethods(['generateUri'])
	18	+ ->setMethods([ 'generateUri' ])
19	19	->getMockForAbstractClass();
20	20	$router->expects(static::at(0))
21	21	->method('generateUri')
22	22	->will(static::returnValue('http://unfinished.dev/admin'));
23	23	$sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
24		- ->setMethods(['getStorage', 'writeClose'])
	24	+ ->setMethods([ 'getStorage', 'writeClose' ])
25	25	->getMock();
26	26	$sessionManager->expects(static::at(0))
27	27	->method('getStorage')
		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	/** @var \Zend\Diactoros\Response\EmptyResponse $response */
35	35	$response = $auth($request, $response);
36	36	static::assertSame(302, $response->getStatusCode());
37		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	37	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
38	38	}
39	39
40	40	public function testIfUserNotLoggedInLoginActionShouldTakeHimToLoginHtmlPage()
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43	->disableOriginalConstructor()
44	44	->getMockForAbstractClass();
45	45	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
46		- ->setMethods(['render'])
	46	+ ->setMethods([ 'render' ])
47	47	->getMockForAbstractClass();
48	48	$template->expects(static::at(0))
49	49	->method('render')
		@@ -54,7 +54,7 @@ discard block
		block discarded – undo
54	54	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
55	55	->getMockForAbstractClass();
56	56	$sessionManager = $this->getMockBuilder(\Zend\Session\SessionManager::class)
57		- ->setMethods(['getStorage', 'writeClose'])
	57	+ ->setMethods([ 'getStorage', 'writeClose' ])
58	58	->getMock();
59	59	$sessionManager->expects(static::at(0))
60	60	->method('getStorage')
		@@ -81,7 +81,7 @@ discard block
		block discarded – undo
81	81	$request = $request->withAttribute('action', 'logout');
82	82	$response = new \Zend\Diactoros\Response\EmptyResponse();
83	83	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
84		- ->setMethods(['generateUri'])
	84	+ ->setMethods([ 'generateUri' ])
85	85	->getMockForAbstractClass();
86	86	$router->expects(static::at(0))
87	87	->method('generateUri')
		@@ -96,14 +96,14 @@ discard block
		block discarded – undo
96	96	$response = $auth($request, $response);
97	97	static::assertNull($sessionManager->getStorage()->user);
98	98	static::assertSame(302, $response->getStatusCode());
99		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	99	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
100	100	}
101	101
102	102	public function testUserLoginHandleWithCorrectCredentialsShouldSetUserInSessionStorage()
103	103	{
104	104	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
105	105	->disableOriginalConstructor()
106		- ->setMethods(['loginUser'])
	106	+ ->setMethods([ 'loginUser' ])
107	107	->getMockForAbstractClass();
108	108	$adminUserService->expects(static::once())
109	109	->method('loginUser')
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	$request = $request->withAttribute('action', 'loginHandle');
123	123	$response = new \Zend\Diactoros\Response\EmptyResponse();
124	124	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
125		- ->setMethods(['generateUri'])
	125	+ ->setMethods([ 'generateUri' ])
126	126	->getMockForAbstractClass();
127	127	$router->expects(static::at(0))
128	128	->method('generateUri')
		@@ -135,14 +135,14 @@ discard block
		block discarded – undo
135	135	$response = $auth($request, $response);
136	136	static::assertTrue($sessionManager->getStorage()->user->isLoggedIn);
137	137	static::assertSame(302, $response->getStatusCode());
138		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	138	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
139	139	}
140	140
141	141	public function testUserLoginHandleWithWrongCredentialsShouldNotSetUserInSessionStorage()
142	142	{
143	143	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
144	144	->disableOriginalConstructor()
145		- ->setMethods(['loginUser'])
	145	+ ->setMethods([ 'loginUser' ])
146	146	->getMockForAbstractClass();
147	147	$template = $this->getMockBuilder(\Zend\Expressive\Template\TemplateRendererInterface::class)
148	148	->getMockForAbstractClass();
		@@ -154,7 +154,7 @@ discard block
		block discarded – undo
154	154	$request = $request->withAttribute('action', 'loginHandle');
155	155	$response = new \Zend\Diactoros\Response\EmptyResponse();
156	156	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
157		- ->setMethods(['generateUri'])
	157	+ ->setMethods([ 'generateUri' ])
158	158	->getMockForAbstractClass();
159	159	$router->expects(static::at(0))
160	160	->method('generateUri')
		@@ -168,7 +168,7 @@ discard block
		block discarded – undo
168	168	$response = $auth($request, $response);
169	169	static::assertNull($sessionManager->getStorage()->user);
170	170	static::assertSame(302, $response->getStatusCode());
171		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	171	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
172	172	}
173	173
174	174	public function testUserLoginHandleWitAlreadyLoggedInUserShouldRedirectToAdminPage()
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182	$request = $request->withAttribute('action', 'loginHandle');
183	183	$response = new \Zend\Diactoros\Response\EmptyResponse();
184	184	$router = $this->getMockBuilder(\Zend\Expressive\Router\RouterInterface::class)
185		- ->setMethods(['generateUri'])
	185	+ ->setMethods([ 'generateUri' ])
186	186	->getMockForAbstractClass();
187	187	$router->expects(static::at(0))
188	188	->method('generateUri')
		@@ -196,14 +196,14 @@ discard block
		block discarded – undo
196	196	/** @var \Zend\Diactoros\Response\HtmlResponse $response */
197	197	$response = $auth($request, $response);
198	198	static::assertSame(302, $response->getStatusCode());
199		- static::assertSame(['http://unfinished.dev/admin'], $response->getHeader('Location'));
	199	+ static::assertSame([ 'http://unfinished.dev/admin' ], $response->getHeader('Location'));
200	200	}
201	201
202	202	public function testUserLoginHandleShouldThrowExceptionAndDisplayMessage()
203	203	{
204	204	$adminUserService = $this->getMockBuilder(\Admin\Service\AdminUserService::class)
205	205	->disableOriginalConstructor()
206		- ->setMethods(['loginUser'])
	206	+ ->setMethods([ 'loginUser' ])
207	207	->getMockForAbstractClass();
208	208	$adminUserService->expects(static::once())
209	209	->method('loginUser')
		@@ -214,7 +214,7 @@ discard block
		block discarded – undo
214	214	->method('render')
215	215	->will(static::returnCallback(
216	216	function($tpl, $error) {
217		- return $error['error'];
	217	+ return $error[ 'error' ];
218	218	}
219	219	));
220	220	$request = new \Zend\Diactoros\ServerRequest();

phpsrbija / unfinished

Push — master ( f5e198...1a7910 )

Status

Category

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +9 added lines, -9 removed lines patch added patch discarded remove patch