ArticleController::doCreate() - Code Metrics - Inspection of "complete create article action without tests" - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#39)

unknown

created 2016-12-08 23:41 UTC

ArticleController::doCreate() A

↳ Parent: ArticleController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	1
nc	1
nop	0

<?php

namespace Admin\Controller;

use Zend\Expressive\Template\TemplateRendererInterface as Template;
use Zend\Diactoros\Response\HtmlResponse;
use Admin\Model\Repository\ArticleRepositoryInterface;
use Admin\Validator\ValidatorInterface as Validator;
use Ramsey\Uuid\Uuid;
use Zend\Session\SessionManager;
use Zend\Expressive\Router\RouterInterface as Router;

class ArticleController extends AbstractController
{
    /**
     * @var Template
     */
    private $template;

    /**
     * @var \Admin\Model\Repository\ArticleRepositoryInterface
     */
    private $articleRepo;

    /**
     * @var \Zend\Validator\AbstractValidator
     */
    private $validator;

    /**
     * @var SessionManager
     */
    private $session;

    /**
     * @var ROUTER
     */
    private $router;

    /**
     * ArticleController constructor.
     *
     * @param Template $template
     * @param ArticleRepositoryInterface $articleRepo
     * @param Validator $validator
     * @param SessionManager $session
     * @param Router $routes
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(
        Template $template,
        ArticleRepositoryInterface $articleRepo,
        Validator $validator,
        SessionManager $session,
        Router $router
    ) {
        $this->template = $template;
        $this->articleRepo = $articleRepo;
        $this->validator = $validator;

        $this->session = $session;
        $this->router = $router;

    }

    public function index() : HtmlResponse
    {
        $articleCollection = $this->articleRepo->fetchAllArticles();

        $data = [
            'message'    => 'Article list',
            'articleCollection' => $articleCollection,
        ];

        return new HtmlResponse($this->template->render('admin::article/index', $data));
    }

    public function create() : \Psr\Http\Message\ResponseInterface
    {
        $data = [
            'message' => 'Create article',
            'errors' => false,
            'data' => $this->request->getParsedBody()
        ];

        if (count($data['data']) > 0) {
            $user   = $this->session->getStorage()->user;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            try {
                $article = new \Admin\Model\Entity\ArticleEntity();
                //@TODO fix this
                $dt = new \DateTime('now');
                $data['data']['created_at'] = $dt->format('Y-m-d H:i:s');

                //generate uuid
                $data['data']['article_uuid'] = hex2bin(Uuid::uuid1()->getHex());
                $data['user_uuid'] = $user->admin_user_uuid;
                $this->validator->validate($data['data']);

                $article->exchangeArray($data['data']);
                if ($this->articleRepo->createArticle($article)) {
                    return $this->response->withStatus(302)->withHeader(
                        'Location',
                        $this->router->generateUri('admin.articles', ['action' => 'index'])
                    );
                }
                //@TODO there was an error saving article, set a flesh message for user

                // handle validation errors
            } catch (\Admin\Validator\ValidatorException $e) {
                $data['errors'] = $this->validator->getMessages();

                // handle other errors
            } catch (\Exception $e) {
                var_dump($e->getMessage());

            }
        }

        return new HtmlResponse($this->template->render('admin::article/create', $data));
    }

    public function doCreate()
    {


    }
}

1			<?php
2
3			namespace Admin\Controller;
4
5			use Zend\Expressive\Template\TemplateRendererInterface as Template;
6			use Zend\Diactoros\Response\HtmlResponse;
7			use Admin\Model\Repository\ArticleRepositoryInterface;
8			use Admin\Validator\ValidatorInterface as Validator;
9			use Ramsey\Uuid\Uuid;
10			use Zend\Session\SessionManager;
11			use Zend\Expressive\Router\RouterInterface as Router;
12
13			class ArticleController extends AbstractController
14			{
15			/**
16			* @var Template
17			*/
18			private $template;
19
20			/**
21			* @var \Admin\Model\Repository\ArticleRepositoryInterface
22			*/
23			private $articleRepo;
24
25			/**
26			* @var \Zend\Validator\AbstractValidator
27			*/
28			private $validator;
29
30			/**
31			* @var SessionManager
32			*/
33			private $session;
34
35			/**
36			* @var ROUTER
37			*/
38			private $router;
39
40			/**
41			* ArticleController constructor.
42			*
43			* @param Template $template
44			* @param ArticleRepositoryInterface $articleRepo
45			* @param Validator $validator
46			* @param SessionManager $session
47			* @param Router $routes
			0 ignored issues – show Bug introduced 2016-12-08 23:43 UTC by Report Bug Copy Issue Report There is no parameter named `$routes`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
48			*/
49			public function __construct(
50			Template $template,
51			ArticleRepositoryInterface $articleRepo,
52			Validator $validator,
53			SessionManager $session,
54			Router $router
55			) {
56			$this->template = $template;
57			$this->articleRepo = $articleRepo;
58			$this->validator = $validator;
			0 ignored issues – show Documentation Bug introduced 2016-12-01 22:36 UTC by Report Bug Copy Issue Report It seems like `$validator` of type `object<Admin\Validator\ValidatorInterface>` is incompatible with the declared type `object<Zend\Validator\AbstractValidator>` of property `$validator`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
59			$this->session = $session;
60			$this->router = $router;
			0 ignored issues – show Documentation Bug introduced 2016-12-08 23:43 UTC by Report Bug Copy Issue Report It seems like `$router` of type `object<Zend\Expressive\Router\RouterInterface>` is incompatible with the declared type `object<Admin\Controller\ROUTER>` of property `$router`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
61			}
62
63			public function index() : HtmlResponse
64			{
65			$articleCollection = $this->articleRepo->fetchAllArticles();
66
67			$data = [
68			'message' => 'Article list',
69			'articleCollection' => $articleCollection,
70			];
71
72			return new HtmlResponse($this->template->render('admin::article/index', $data));
73			}
74
75			public function create() : \Psr\Http\Message\ResponseInterface
76			{
77			$data = [
78			'message' => 'Create article',
79			'errors' => false,
80			'data' => $this->request->getParsedBody()
81			];
82
83			if (count($data['data']) > 0) {
84			$user = $this->session->getStorage()->user;
			0 ignored issues – show Bug introduced 2016-12-08 23:43 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `Zend\Session\Storage\StorageInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
85			try {
86			$article = new \Admin\Model\Entity\ArticleEntity();
87			//@TODO fix this
88			$dt = new \DateTime('now');
89			$data['data']['created_at'] = $dt->format('Y-m-d H:i:s');
90
91			//generate uuid
92			$data['data']['article_uuid'] = hex2bin(Uuid::uuid1()->getHex());
93			$data['user_uuid'] = $user->admin_user_uuid;
94			$this->validator->validate($data['data']);
			0 ignored issues – show Bug introduced 2016-12-01 22:36 UTC by Report Bug Copy Issue Report The method `validate()` does not seem to exist on `object<Zend\Validator\AbstractValidator>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
95			$article->exchangeArray($data['data']);
96			if ($this->articleRepo->createArticle($article)) {
97			return $this->response->withStatus(302)->withHeader(
98			'Location',
99			$this->router->generateUri('admin.articles', ['action' => 'index'])
100			);
101			}
102			//@TODO there was an error saving article, set a flesh message for user
103
104			// handle validation errors
105			} catch (\Admin\Validator\ValidatorException $e) {
106			$data['errors'] = $this->validator->getMessages();
107
108			// handle other errors
109			} catch (\Exception $e) {
110			var_dump($e->getMessage());
			0 ignored issues – show Security Debugging Code introduced 2016-12-08 23:43 UTC by Report Bug Copy Issue Report `var_dump($e->getMessage());` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
111			}
112			}
113
114			return new HtmlResponse($this->template->render('admin::article/create', $data));
115			}
116
117			public function doCreate()
118			{
119
120
121			}
122			}

phpsrbija / unfinished

Pull Request — master (#39)

ArticleController::doCreate() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like