AdminUserService::delete() - Code Metrics - phpsrbija/unfinished - Measure and Improve Code Quality continuously with Scrutinizer

AdminUserService::delete() A
last analyzed 2018-11-17 22:30 UTC

↳ Parent: AdminUserService

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Admin\Service;

use Admin\Filter\AdminUserFilter;
use Admin\Mapper\AdminUsersMapper;
use MysqlUuid\Formats\Binary;
use MysqlUuid\Uuid as MysqlUuid;
use Ramsey\Uuid\Uuid;
use Std\FilterException;
use UploadHelper\Upload;
use Zend\Crypt\Password\Bcrypt;
use Zend\Paginator\Adapter\DbSelect;
use Zend\Paginator\Paginator;

/**
 * Class AdminUserService.
 */
class AdminUserService
{
    /**
     * @var Bcrypt
     */
    private $crypt;

    /**
     * @var AdminUsersMapper
     */
    private $adminUsersMapper;

    /**
     * @var AdminUserFilter
     */
    private $adminUserFilter;

    /**
     * @var Upload
     */
    private $upload;

    /**
     * AdminUserService constructor.
     *
     * @param Bcrypt           $crypt            bcrypt password encryption method
     * @param AdminUsersMapper $adminUsersMapper mapper for admin us
     * @param AdminUserFilter  $adminUserFilter
     * @param Upload           $upload
     */
    public function __construct(
        Bcrypt $crypt,
        AdminUsersMapper $adminUsersMapper,
        AdminUserFilter $adminUserFilter,
        Upload $upload
    ) {
        $this->crypt = $crypt;
        $this->adminUsersMapper = $adminUsersMapper;
        $this->adminUserFilter = $adminUserFilter;
        $this->upload = $upload;
    }

    /**
     * Performs user login or throws exception if credentials are not valid.
     *
     * @param string $email    user email
     * @param string $password user password
     *
     * @throws \Exception if user does not exist or password is not valid
     *
     * @return array|\ArrayObject|null
     */
    public function loginUser($email, $password)
    {
        if (!$email || !$password) {
            throw new \Exception('Both email and password are required.', 400);
        }

        $user = $this->adminUsersMapper->getByEmail($email);

        if (!$user) {
            throw new \Exception('User does not exist.');
        }

        if (!$this->crypt->verify($password, $user->password)) {
            throw new \Exception('Password does not match.');
        }

        $this->adminUsersMapper->updateLogin($user->admin_user_id);

        return $user;
    }

    /**
     * Return pagination object to paginate results on view.
     *
     * @param int    $page   Current page set to pagination to display
     * @param int    $limit  Limit set to pagination
     * @param string $userId UUID from DB
     *
     * @return Paginator
     */
    public function getPagination($page, $limit, $userId)

    {
        $select = $this->adminUsersMapper->getPaginationSelect($userId);
        $paginationAdapter = new DbSelect($select, $this->adminUsersMapper->getAdapter());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $pagination = new Paginator($paginationAdapter);

        $pagination->setCurrentPageNumber($page);
        $pagination->setItemCountPerPage($limit);

        return $pagination;
    }

    /**
     * Return one user for given UUID.
     *
     * @param string $userId UUID from DB
     *
     * @return array|\ArrayObject|null
     */
    public function getUser($userId)
    {
        return $this->adminUsersMapper->get($userId);
    }

    public function registerNewUser($data)
    {
        $filter = $this->adminUserFilter->getInputFilter()->setData($data);

        if (!$filter->isValid()) {
            throw new FilterException($filter->getMessages());
        }

        $data = $filter->getValues() + [
            'face_img'    => $this->upload->uploadImage($data, 'face_img'),
            'profile_img' => $this->upload->uploadImage($data, 'profile_img'),
        ];

        unset($data['confirm_password']);
        $data['password'] = $this->crypt->create($data['password']);
        $data['admin_user_id'] = Uuid::uuid1()->toString();
        $data['admin_user_uuid'] = (new MysqlUuid($data['admin_user_id']))->toFormat(new Binary());

        return $this->adminUsersMapper->insert($data);
    }

    /**
     * Refactor it.
     */
    public function updateUser($data, $userId)
    {
        $user = $this->getUser($userId);
        $filter = $this->adminUserFilter->getInputFilter()->setData($data);

        // we dont want to force user to enter the password again
        if ($data['password'] == '') {
            $filter->remove('password');
            $filter->remove('confirm_password');
        }

        // if we want to keep same email
        if ($user->email == $data['email']) {
            $filter->remove('email');
        }

        if (!$filter->isValid()) {
            throw new FilterException($filter->getMessages());
        }

        $data = $filter->getValues() + [
            'face_img'    => $this->upload->uploadImage($data, 'face_img'),
            'profile_img' => $this->upload->uploadImage($data, 'profile_img'),
        ];

        // We don't want to force user to re-upload image on edit
        if (!$data['face_img']) {
            unset($data['face_img']);
        } else {
            $this->upload->deleteFile($user->face_img);
        }

        if (!$data['profile_img']) {
            unset($data['profile_img']);
        } else {
            $this->upload->deleteFile($user->profile_img);
        }

        if (isset($data['password'])) {
            unset($data['confirm_password']);
            $data['password'] = $this->crypt->create($data['password']);
        }

        return $this->adminUsersMapper->update($data, ['admin_user_id' => $userId]);
    }

    /**
     * Delete user by given UUID.
     *
     * @param  $userId
     *
     * @throws \Exception
     *
     * @return bool
     */
    public function delete($userId)
    {
        if (!($adminUser = $this->getUser($userId))) {
            throw new \Exception('Admin user not found.');
        }

        $this->upload->deleteFile($adminUser->face_img);
        $this->upload->deleteFile($adminUser->profile_img);

        return (bool) $this->adminUsersMapper->delete(['admin_user_id' => $userId]);
    }

    /**
     * Fetch random X users to show on homepage.
     *
     * @param int $limit
     *
     * @return null|\Zend\Db\ResultSet\ResultSetInterface
     */
    public function getForWeb($limit = 10)
    {
        return $this->adminUsersMapper->getRandom($limit);
    }

    /**
     * Return all Admin User for select box.
     *
     * @return \Zend\Db\ResultSet\ResultSet
     */
    public function getAll()
    {
        return $this->adminUsersMapper->select();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Admin\Service;
6
7		use Admin\Filter\AdminUserFilter;
8		use Admin\Mapper\AdminUsersMapper;
9		use MysqlUuid\Formats\Binary;
10		use MysqlUuid\Uuid as MysqlUuid;
11		use Ramsey\Uuid\Uuid;
12		use Std\FilterException;
13		use UploadHelper\Upload;
14		use Zend\Crypt\Password\Bcrypt;
15		use Zend\Paginator\Adapter\DbSelect;
16		use Zend\Paginator\Paginator;
17
18		/**
19		* Class AdminUserService.
20		*/
21		class AdminUserService
22		{
23		/**
24		* @var Bcrypt
25		*/
26		private $crypt;
27
28		/**
29		* @var AdminUsersMapper
30		*/
31		private $adminUsersMapper;
32
33		/**
34		* @var AdminUserFilter
35		*/
36		private $adminUserFilter;
37
38		/**
39		* @var Upload
40		*/
41		private $upload;
42
43		/**
44		* AdminUserService constructor.
45		*
46		* @param Bcrypt $crypt bcrypt password encryption method
47		* @param AdminUsersMapper $adminUsersMapper mapper for admin us
48		* @param AdminUserFilter $adminUserFilter
49		* @param Upload $upload
50		*/
51		public function __construct(
52		Bcrypt $crypt,
53		AdminUsersMapper $adminUsersMapper,
54		AdminUserFilter $adminUserFilter,
55		Upload $upload
56		) {
57		$this->crypt = $crypt;
58		$this->adminUsersMapper = $adminUsersMapper;
59		$this->adminUserFilter = $adminUserFilter;
60		$this->upload = $upload;
61		}
62
63		/**
64		* Performs user login or throws exception if credentials are not valid.
65		*
66		* @param string $email user email
67		* @param string $password user password
68		*
69		* @throws \Exception if user does not exist or password is not valid
70		*
71		* @return array\|\ArrayObject\|null
72		*/
73		public function loginUser($email, $password)
74		{
75		if (!$email \|\| !$password) {
76		throw new \Exception('Both email and password are required.', 400);
77		}
78
79		$user = $this->adminUsersMapper->getByEmail($email);
80
81		if (!$user) {
82		throw new \Exception('User does not exist.');
83		}
84
85		if (!$this->crypt->verify($password, $user->password)) {
86		throw new \Exception('Password does not match.');
87		}
88
89		$this->adminUsersMapper->updateLogin($user->admin_user_id);
90
91		return $user;
92		}
93
94		/**
95		* Return pagination object to paginate results on view.
96		*
97		* @param int $page Current page set to pagination to display
98		* @param int $limit Limit set to pagination
99		* @param string $userId UUID from DB
100		*
101		* @return Paginator
102		*/
103	View Code Duplication	public function getPagination($page, $limit, $userId)
		0 ignored issues – show Duplication introduced 2017-08-24 17:35 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		$select = $this->adminUsersMapper->getPaginationSelect($userId);
106		$paginationAdapter = new DbSelect($select, $this->adminUsersMapper->getAdapter());
		0 ignored issues – show Documentation introduced 2016-11-28 13:00 UTC by Report Bug Copy Issue Report `$this->adminUsersMapper->getAdapter()` is of type `object<Zend\Db\Adapter\AdapterInterface>`, but the function expects a `object<Zend\Db\Adapter\A...object<Zend\Db\Sql\Sql>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107		$pagination = new Paginator($paginationAdapter);
108
109		$pagination->setCurrentPageNumber($page);
110		$pagination->setItemCountPerPage($limit);
111
112		return $pagination;
113		}
114
115		/**
116		* Return one user for given UUID.
117		*
118		* @param string $userId UUID from DB
119		*
120		* @return array\|\ArrayObject\|null
121		*/
122		public function getUser($userId)
123		{
124		return $this->adminUsersMapper->get($userId);
125		}
126
127		public function registerNewUser($data)
128		{
129		$filter = $this->adminUserFilter->getInputFilter()->setData($data);
130
131		if (!$filter->isValid()) {
132		throw new FilterException($filter->getMessages());
133		}
134
135		$data = $filter->getValues() + [
136		'face_img' => $this->upload->uploadImage($data, 'face_img'),
137		'profile_img' => $this->upload->uploadImage($data, 'profile_img'),
138		];
139
140		unset($data['confirm_password']);
141		$data['password'] = $this->crypt->create($data['password']);
142		$data['admin_user_id'] = Uuid::uuid1()->toString();
143		$data['admin_user_uuid'] = (new MysqlUuid($data['admin_user_id']))->toFormat(new Binary());
144
145		return $this->adminUsersMapper->insert($data);
146		}
147
148		/**
149		* Refactor it.
150		*/
151		public function updateUser($data, $userId)
152		{
153		$user = $this->getUser($userId);
154		$filter = $this->adminUserFilter->getInputFilter()->setData($data);
155
156		// we dont want to force user to enter the password again
157		if ($data['password'] == '') {
158		$filter->remove('password');
159		$filter->remove('confirm_password');
160		}
161
162		// if we want to keep same email
163		if ($user->email == $data['email']) {
164		$filter->remove('email');
165		}
166
167		if (!$filter->isValid()) {
168		throw new FilterException($filter->getMessages());
169		}
170
171		$data = $filter->getValues() + [
172		'face_img' => $this->upload->uploadImage($data, 'face_img'),
173		'profile_img' => $this->upload->uploadImage($data, 'profile_img'),
174		];
175
176		// We don't want to force user to re-upload image on edit
177		if (!$data['face_img']) {
178		unset($data['face_img']);
179		} else {
180		$this->upload->deleteFile($user->face_img);
181		}
182
183		if (!$data['profile_img']) {
184		unset($data['profile_img']);
185		} else {
186		$this->upload->deleteFile($user->profile_img);
187		}
188
189		if (isset($data['password'])) {
190		unset($data['confirm_password']);
191		$data['password'] = $this->crypt->create($data['password']);
192		}
193
194		return $this->adminUsersMapper->update($data, ['admin_user_id' => $userId]);
195		}
196
197		/**
198		* Delete user by given UUID.
199		*
200		* @param $userId
201		*
202		* @throws \Exception
203		*
204		* @return bool
205		*/
206		public function delete($userId)
207		{
208		if (!($adminUser = $this->getUser($userId))) {
209		throw new \Exception('Admin user not found.');
210		}
211
212		$this->upload->deleteFile($adminUser->face_img);
213		$this->upload->deleteFile($adminUser->profile_img);
214
215		return (bool) $this->adminUsersMapper->delete(['admin_user_id' => $userId]);
216		}
217
218		/**
219		* Fetch random X users to show on homepage.
220		*
221		* @param int $limit
222		*
223		* @return null\|\Zend\Db\ResultSet\ResultSetInterface
224		*/
225		public function getForWeb($limit = 10)
226		{
227		return $this->adminUsersMapper->getRandom($limit);
228		}
229
230		/**
231		* Return all Admin User for select box.
232		*
233		* @return \Zend\Db\ResultSet\ResultSet
234		*/
235		public function getAll()
236		{
237		return $this->adminUsersMapper->select();
238		}
239		}
240

phpsrbija / unfinished

AdminUserService::delete() A last analyzed 2018-11-17 22:30 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AdminUserService::delete() A
last analyzed 2018-11-17 22:30 UTC