Category\View\Helper\CategoryHelper

Complexity

Total Complexity

5

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	__invoke()	0	4	1
A	forSelect()	0	4	1
A	forHomepage()	0	8	2

<?php

declare(strict_types=1);

namespace Category\View\Helper;

use Category\Service\CategoryService;
use Zend\View\Helper\AbstractHelper;

class CategoryHelper extends AbstractHelper
{
    /** @var CategoryService */
    private $categoryService;

    /** @var array */
    private $homepageCategories;

    /**
     * CategoryHelper constructor.
     *
     * @param CategoryService $categoryService
     */
    public function __construct(CategoryService $categoryService)
    {
        $this->categoryService = $categoryService;
    }

    /** @return $this */
    public function __invoke()
    {
        return $this;
    }

    /** @return \Zend\Db\ResultSet\ResultSet */
    public function forSelect()
    {
        return $this->categoryService->getAll();
    }

    /**
     * We need to return X categories with Y posts in every category sorted by
     * magic for homepage. magic = most viewed, most comments, most appropriate
     * for the user etc. etc. for now return just latest.
     */
    public function forHomepage()
    {
        if (!$this->homepageCategories) {

The expression $this->homepageCategories of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->homepageCategories = $this->categoryService->getCategoriesWithPosts(true);

It seems like $this->categoryService->getCategoriesWithPosts(true) of type * is incompatible with the declared type array of property $homepageCategories.

        }

        return $this->homepageCategories;
    }
}