Admin\Middleware\AdminAuth

Complexity

Total Complexity

3

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	__invoke()	0	18	2

<?php

declare(strict_types=1);

namespace Admin\Middleware;

use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as Request;
use Zend\Expressive\Router\RouterInterface as Router;
use Zend\Session\SessionManager;

/**
 * Class AdminAuth.
 */
final class AdminAuth
{
    /**
     * @var Router
     */
    private $router;

    /**
     * @var SessionManager
     */
    private $session;

    /**
     * AdminAuth constructor.
     *
     * @param Router         $router  router
     * @param SessionManager $session session manager
     */
    public function __construct(Router $router, SessionManager $session)
    {
        $this->router = $router;
        $this->session = $session;
    }

    /**
     * Called when middleware is invoked.
     *
     * @param Request       $request  request
     * @param Response      $response response
     * @param callable|null $next     next callable in line
     *
     * @return mixed
     */
    public function __invoke(Request $request, Response $response, callable $next = null)
    {
        /**
         * Check if user is logged in.
         */
        $user = $this->session->getStorage()->user;

Accessing user on the interface Zend\Session\Storage\StorageInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (!$user) {
            return $response->withStatus(302)->withHeader(
                'Location',
                $this->router->generateUri('auth', ['action' => 'login'])
            );
        }

        /*
         * If everything is OK, continue execution middleware
         */
        return $next($request, $response);
    }
}