Admin\Controller\UserController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	121
Duplicated Lines	51.24 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	index()	0	14	3
A	edit()	20	20	2
A	save()	20	20	4
A	delete()	11	11	2

<?php

declare(strict_types=1);

namespace Admin\Controller;

use Admin\Service\AdminUserService;
use Std\AbstractController;
use Std\FilterException;
use Zend\Diactoros\Response\HtmlResponse;
use Zend\Expressive\Router\RouterInterface as Router;
use Zend\Expressive\Template\TemplateRendererInterface as Template;
use Zend\Http\PhpEnvironment\Request;
use Zend\Session\SessionManager;

/**
 * Class UserController.
 */
class UserController extends AbstractController
{
    /**
     * @var Template
     */
    private $template;

    /**
     * @var Router
     */
    private $router;

    /**
     * @var AdminUserService
     */
    private $adminUserService;

    /**
     * @var SessionManager
     */
    private $session;

    /**
     * UserController constructor.
     *
     * @param Template         $template
     * @param Router           $router
     * @param AdminUserService $adminUserService
     * @param SessionManager   $session
     */
    public function __construct(

This method seems to be duplicated in your project.

        Template $template,
        Router $router,
        AdminUserService $adminUserService,
        SessionManager $session
    ) {
        $this->template = $template;
        $this->router = $router;
        $this->adminUserService = $adminUserService;
        $this->session = $session;
    }

    /**
     * Users list, exclude current logged in user from the list.
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function index(): \Psr\Http\Message\ResponseInterface
    {
        $user = $this->session->getStorage()->user;

Accessing user on the interface Zend\Session\Storage\StorageInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $params = $this->request->getQueryParams();
        $page = isset($params['page']) ? $params['page'] : 1;
        $limit = isset($params['limit']) ? $params['limit'] : 15;

        $adminUsers = $this->adminUserService->getPagination($page, $limit, $user->admin_user_id);

        return new HtmlResponse($this->template->render(
            'admin::user/index',
            ['list' => $adminUsers, 'layout' => 'layout/admin'])
        );
    }

    /**
     * Edit one user by givven UUID from route.
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function edit($errors = []): \Psr\Http\Message\ResponseInterface

This method seems to be duplicated in your project.

    {
        $id = $this->request->getAttribute('id');
        $user = $this->adminUserService->getUser($id);

        if ($this->request->getParsedBody()) {
            $user = (object) ($this->request->getParsedBody() + (array) $user);
            $user->admin_user_id = $id;
        }

        return new HtmlResponse(
            $this->template->render(
                'admin::user/edit', [
                    'user'   => $user,
                    'errors' => $errors,
                    'layout' => 'layout/admin',
                ]
            )
        );
    }

    public function save()

This method seems to be duplicated in your project.

    {
        try {
            $userId = $this->request->getAttribute('id');
            $data = $this->request->getParsedBody();
            $data += (new Request())->getFiles()->toArray();

            if ($userId) {
                $this->adminUserService->updateUser($data, $userId);
            } else {
                $this->adminUserService->registerNewUser($data);
            }

            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin.users'));
        } catch (FilterException $fe) {
            return $this->edit($fe->getArrayMessages());
        } catch (\Exception $e) {
            throw $e;
        }
    }

    public function delete()

This method seems to be duplicated in your project.

    {
        try {
            $userId = $this->request->getAttribute('id');
            $this->adminUserService->delete($userId);

            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin.users'));
        } catch (\Exception $e) {
            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin.users'));
        }
    }
}