Admin\Controller\AuthController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	93
Duplicated Lines	18.28 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	login()	3	8	2
A	loginHandle()	3	21	5
A	logout()	0	6	1

<?php

declare(strict_types=1);

namespace Admin\Controller;

use Admin\Service\AdminUserService;
use Std\AbstractController;
use Zend\Diactoros\Response\HtmlResponse;
use Zend\Expressive\Router\RouterInterface as Router;
use Zend\Expressive\Template\TemplateRendererInterface as Template;
use Zend\Session\SessionManager;

/**
 * Class AuthController.
 * Deals with handlers which work with admin user authentication.
 */
final class AuthController extends AbstractController
{
    /**
     * @var Router
     */
    private $router;

    /**
     * @var Template
     */
    private $template;

    /**
     * @var SessionManager
     */
    private $session;

    /**
     * @var AdminUserService
     */
    private $adminUserService;

    /**
     * AuthController constructor.
     *
     * @param Router           $router           router
     * @param Template         $template         template engine
     * @param SessionManager   $session          session manager
     * @param AdminUserService $adminUserService admin user service
     */
    public function __construct(

This method seems to be duplicated in your project.

        Router $router,
        Template $template,
        SessionManager $session,
        AdminUserService $adminUserService
    ) {
        $this->router = $router;
        $this->template = $template;
        $this->session = $session;
        $this->adminUserService = $adminUserService;
    }

    /**
     * Performs session check and redirects user to appropriate page or displays login page.
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function login($error = false): \Psr\Http\Message\ResponseInterface
    {
        if ($this->session->getStorage()->user) {

Accessing user on the interface Zend\Session\Storage\StorageInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin'));
        }

        return new HtmlResponse($this->template->render('admin::login', ['layout' => false, 'error' => $error]));
    }

    /**
     * Performs user credentials check and registers admin session if valid.
     *
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function loginHandle(): \Psr\Http\Message\ResponseInterface
    {
        if ($this->session->getStorage()->user) {

Accessing user on the interface Zend\Session\Storage\StorageInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin'));
        }

        $data = $this->request->getParsedBody();
        $email = isset($data['email']) ? $data['email'] : null;
        $password = isset($data['password']) ? $data['password'] : null;

        try {
            $this->session->getStorage()->user = $this->adminUserService->loginUser($email, $password);

Accessing user on the interface Zend\Session\Storage\StorageInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin'));
        } catch (\Exception $e) {
            return $this->login($e->getMessage());

$e->getMessage() is of type string, but the function expects a boolean.

            //@todo set $e->getMessage() to flash messanger and print messages in next page
            //return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin'));
        }
    }

    /**
     * @return \Psr\Http\Message\ResponseInterface
     */
    public function logout(): \Psr\Http\Message\ResponseInterface
    {
        $this->session->getStorage()->clear('user');

        return $this->response->withStatus(302)->withHeader('Location', $this->router->generateUri('admin'));
    }
}