Issues in Prophet.php (master) - Issues in master - phpspec/prophecy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (117)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Prophecy/Prophet.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Prophecy.
 * (c) Konstantin Kudryashov <[email protected]>
 *     Marcello Duarte <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Prophecy;

use Prophecy\Doubler\CachedDoubler;
use Prophecy\Doubler\Doubler;
use Prophecy\Doubler\LazyDouble;
use Prophecy\Doubler\ClassPatch;
use Prophecy\Prophecy\ObjectProphecy;
use Prophecy\Prophecy\RevealerInterface;
use Prophecy\Prophecy\Revealer;
use Prophecy\Call\CallCenter;
use Prophecy\Util\StringUtil;
use Prophecy\Exception\Prediction\PredictionException;
use Prophecy\Exception\Prediction\AggregateException;

/**
 * Prophet creates prophecies.
 *
 * @author Konstantin Kudryashov <[email protected]>
 */
class Prophet
{
    private $doubler;
    private $revealer;
    private $util;

    /**
     * @var ObjectProphecy[]
     */
    private $prophecies = array();

    /**
     * Initializes Prophet.
     *
     * @param null|Doubler           $doubler
     * @param null|RevealerInterface $revealer
     * @param null|StringUtil        $util
     */
    public function __construct(
        Doubler $doubler = null,
        RevealerInterface $revealer = null,
        StringUtil $util = null
    ) {
        if (null === $doubler) {
            $doubler = new CachedDoubler();
            $doubler->registerClassPatch(new ClassPatch\SplFileInfoPatch);
            $doubler->registerClassPatch(new ClassPatch\TraversablePatch);
            $doubler->registerClassPatch(new ClassPatch\ThrowablePatch);
            $doubler->registerClassPatch(new ClassPatch\DisableConstructorPatch);
            $doubler->registerClassPatch(new ClassPatch\ProphecySubjectPatch);
            $doubler->registerClassPatch(new ClassPatch\ReflectionClassNewInstancePatch);
            $doubler->registerClassPatch(new ClassPatch\HhvmExceptionPatch());
            $doubler->registerClassPatch(new ClassPatch\MagicCallPatch);
            $doubler->registerClassPatch(new ClassPatch\KeywordPatch);
        }

        $this->doubler  = $doubler;
        $this->revealer = $revealer ?: new Revealer;
        $this->util     = $util ?: new StringUtil;
    }

    /**
     * Creates new object prophecy.
     *
     * @param null|string $classOrInterface Class or interface name
     *
     * @return ObjectProphecy
     */
    public function prophesize($classOrInterface = null)
    {
        $this->prophecies[] = $prophecy = new ObjectProphecy(
            new LazyDouble($this->doubler),
            new CallCenter($this->util),
            $this->revealer
        );

        if ($classOrInterface && class_exists($classOrInterface)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $prophecy->willExtend($classOrInterface);
        }

        if ($classOrInterface && interface_exists($classOrInterface)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $prophecy->willImplement($classOrInterface);
        }

        return $prophecy;
    }

    /**
     * Returns all created object prophecies.
     *
     * @return ObjectProphecy[]
     */
    public function getProphecies()
    {
        return $this->prophecies;
    }

    /**
     * Returns Doubler instance assigned to this Prophet.
     *
     * @return Doubler
     */
    public function getDoubler()
    {
        return $this->doubler;
    }

    /**
     * Checks all predictions defined by prophecies of this Prophet.
     *
     * @throws Exception\Prediction\AggregateException If any prediction fails
     */
    public function checkPredictions()
    {
        $exception = new AggregateException("Some predictions failed:\n");
        foreach ($this->prophecies as $prophecy) {
            try {
                $prophecy->checkProphecyMethodsPredictions();
            } catch (PredictionException $e) {
                $exception->append($e);
            }
        }

        if (count($exception->getExceptions())) {
            throw $exception;
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Prophecy.
5			* (c) Konstantin Kudryashov <[email protected]>
6			* Marcello Duarte <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Prophecy;
13
14			use Prophecy\Doubler\CachedDoubler;
15			use Prophecy\Doubler\Doubler;
16			use Prophecy\Doubler\LazyDouble;
17			use Prophecy\Doubler\ClassPatch;
18			use Prophecy\Prophecy\ObjectProphecy;
19			use Prophecy\Prophecy\RevealerInterface;
20			use Prophecy\Prophecy\Revealer;
21			use Prophecy\Call\CallCenter;
22			use Prophecy\Util\StringUtil;
23			use Prophecy\Exception\Prediction\PredictionException;
24			use Prophecy\Exception\Prediction\AggregateException;
25
26			/**
27			* Prophet creates prophecies.
28			*
29			* @author Konstantin Kudryashov <[email protected]>
30			*/
31			class Prophet
32			{
33			private $doubler;
34			private $revealer;
35			private $util;
36
37			/**
38			* @var ObjectProphecy[]
39			*/
40			private $prophecies = array();
41
42			/**
43			* Initializes Prophet.
44			*
45			* @param null\|Doubler $doubler
46			* @param null\|RevealerInterface $revealer
47			* @param null\|StringUtil $util
48			*/
49			public function __construct(
50			Doubler $doubler = null,
51			RevealerInterface $revealer = null,
52			StringUtil $util = null
53			) {
54			if (null === $doubler) {
55			$doubler = new CachedDoubler();
56			$doubler->registerClassPatch(new ClassPatch\SplFileInfoPatch);
57			$doubler->registerClassPatch(new ClassPatch\TraversablePatch);
58			$doubler->registerClassPatch(new ClassPatch\ThrowablePatch);
59			$doubler->registerClassPatch(new ClassPatch\DisableConstructorPatch);
60			$doubler->registerClassPatch(new ClassPatch\ProphecySubjectPatch);
61			$doubler->registerClassPatch(new ClassPatch\ReflectionClassNewInstancePatch);
62			$doubler->registerClassPatch(new ClassPatch\HhvmExceptionPatch());
63			$doubler->registerClassPatch(new ClassPatch\MagicCallPatch);
64			$doubler->registerClassPatch(new ClassPatch\KeywordPatch);
65			}
66
67			$this->doubler = $doubler;
68			$this->revealer = $revealer ?: new Revealer;
69			$this->util = $util ?: new StringUtil;
70			}
71
72			/**
73			* Creates new object prophecy.
74			*
75			* @param null\|string $classOrInterface Class or interface name
76			*
77			* @return ObjectProphecy
78			*/
79			public function prophesize($classOrInterface = null)
80			{
81			$this->prophecies[] = $prophecy = new ObjectProphecy(
82			new LazyDouble($this->doubler),
83			new CallCenter($this->util),
84			$this->revealer
85			);
86
87			if ($classOrInterface && class_exists($classOrInterface)) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-20 22:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$classOrInterface` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
88			return $prophecy->willExtend($classOrInterface);
89			}
90
91			if ($classOrInterface && interface_exists($classOrInterface)) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-20 22:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$classOrInterface` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
92			return $prophecy->willImplement($classOrInterface);
93			}
94
95			return $prophecy;
96			}
97
98			/**
99			* Returns all created object prophecies.
100			*
101			* @return ObjectProphecy[]
102			*/
103			public function getProphecies()
104			{
105			return $this->prophecies;
106			}
107
108			/**
109			* Returns Doubler instance assigned to this Prophet.
110			*
111			* @return Doubler
112			*/
113			public function getDoubler()
114			{
115			return $this->doubler;
116			}
117
118			/**
119			* Checks all predictions defined by prophecies of this Prophet.
120			*
121			* @throws Exception\Prediction\AggregateException If any prediction fails
122			*/
123			public function checkPredictions()
124			{
125			$exception = new AggregateException("Some predictions failed:\n");
126			foreach ($this->prophecies as $prophecy) {
127			try {
128			$prophecy->checkProphecyMethodsPredictions();
129			} catch (PredictionException $e) {
130			$exception->append($e);
131			}
132			}
133
134			if (count($exception->getExceptions())) {
135			throw $exception;
136			}
137			}
138			}
139

phpspec / prophecy

Issues (117)

Security Analysis no request data

src/Prophecy/Prophet.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like